Re: [babel] Rtgdir early review of draft-ietf-babel-hmac

Weronika Kołodziejak <weronika.kolodziejak@gmail.com> Wed, 24 October 2018 12:25 UTC

Return-Path: <weronika.kolodziejak@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C320B130E8B for <babel@ietfa.amsl.com>; Wed, 24 Oct 2018 05:25:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N8dJvp3YFHgf for <babel@ietfa.amsl.com>; Wed, 24 Oct 2018 05:25:20 -0700 (PDT)
Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B06EA126DBF for <babel@ietf.org>; Wed, 24 Oct 2018 05:25:19 -0700 (PDT)
Received: by mail-lj1-x235.google.com with SMTP id l25-v6so2754064lja.9 for <babel@ietf.org>; Wed, 24 Oct 2018 05:25:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=t8dtg3rJPyE+gjkDJaxKeyDxihBTSgc5J7njgvr1xzg=; b=opF1mrQzOIUKmiYZcQ9iZ0v31FxbSxN9+i4v84PhEHGNtvgWd08uWj59KobBk9F52v qonMhhq4ZJYr6w3fRUMvJejh1bwA3Fm2qVQfpJXZYEzQgYorhKNvqli4WGRdSZNIXAYn CjddPHWNBIx+71yB1zt4PSyh2msqlBXSYkm8Cl5kI4cJ/tM7A8ZbtY/Aa1ga8m0GGwK2 bsFFRDacLBlKjycQ6i6g00DIoSnRXJFqlkw0wTcFfkZJRMp6vkRSSz/SzIeUuiSwOrDD TtX8DjNSmDTc5VvvQOsVuO07d09us4srJwhk6T/+A2OfukAADu2LtnQn5Po+tJ4/EXlt K+ow==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=t8dtg3rJPyE+gjkDJaxKeyDxihBTSgc5J7njgvr1xzg=; b=t94tha6Z3NLhZ7r/2CxwvV7Y0xkFrKSG2xS5ko38L0rbiI6b3FQ3JXuEM3Rh9gjBrA 2HkYb61uMmqPykp3PYzJ7QIQ1l67iu0ck7mYqAOFJm3nrwtPkbR3ECo6NVs6BsFvR2f2 XeHFuThDAbyY/Zp5KSY+nEPhmP01RA7eJzfjQ100zJ6uJw7Fy0XHtNH30cxej83hMHVU GALqK0+/rxPlh9xwZyXcxCvJ2wHcUU420JPGhFgaC2wu//fWIlPZ7qDzaXaX9RQ/92k3 +OqSZg3JbZziw3Bv3ZDNTn9homk479BQV6g16zV86Mo0p9tJd2XzvwVDfsBsIJwt5ExQ JFXw==
X-Gm-Message-State: AGRZ1gJZl6ohX9IofQ0oxtjDjwC4aOZLG0Em5D6mo4cpQ42lZCeQiBFc +kVmP6f1pCSFD7aOod4MWQ1OBPDPMQBJEVHPiBk=
X-Google-Smtp-Source: AJdET5fLEfYUDULmb4qMsW3GaAaSJtridhPRZPggiGKa1DpXLg8Vjw1Iv/yKVj7fFURFm2JCOvqQ+sMPn925eAEMsec=
X-Received: by 2002:a2e:824c:: with SMTP id j12-v6mr1610400ljh.168.1540383917881; Wed, 24 Oct 2018 05:25:17 -0700 (PDT)
MIME-Version: 1.0
References: <8CCB28152EA2E14A96BBEDC15823481A1CD5B548@sjceml521-mbs.china.huawei.com>
In-Reply-To: <8CCB28152EA2E14A96BBEDC15823481A1CD5B548@sjceml521-mbs.china.huawei.com>
From: Weronika Kołodziejak <weronika.kolodziejak@gmail.com>
Date: Wed, 24 Oct 2018 14:25:03 +0200
Message-ID: <CAJZdynS8xeq8QVjjtJ3Mc=UnfQYzgLgS+OeEDgUj1UU77Gpfgw@mail.gmail.com>
To: Michael.McBride@huawei.com, babel@ietf.org
Content-Type: multipart/alternative; boundary="0000000000003e3e6a0578f8940b"
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/37ktWgn1zGGwg1jmLy0oGXR_P-s>
Subject: Re: [babel] Rtgdir early review of draft-ietf-babel-hmac
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 12:25:25 -0000

Hello Michael,

Thank you for your review, we took your comments into consideration:

> 1.      Add a Terminology section to include HMAC, Babel, PC, etc
>
I have listened to Juliusz and we've added the definitions of each acronym
on first usage rather than having a dedicated terminology instead, I hope
you don't mind.

> 2.      1.1 Applicability Section: “The protocol defined in this document
> assumes that all interfaces on a given link are equally trusted and share a
> small set of symmetric keys (usually just one, two during key rotation).”
> Consider changing it to: “…(Typically one key. Two keys during a key
> rotation).” Otherwise it can read as “just one or two during key rotation”.
>
We've changed it, thanks.

> 3.      4.2 Packet Transmission Section: “A Babel node may delay actually
> sending TLVs by a small amount…”. Consider giving an example of a small
> amount.
>
It has been already said in section 4 of RFC6126bis which is referenced in
the same sentence.

Thanks again,
Weronika Kolodziejak