[babel] YANG errors in datatracker

Mahesh Jethanandani <mjethanandani@gmail.com> Tue, 19 November 2019 06:00 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 78007120823 for <babel@ietfa.amsl.com>; Mon, 18 Nov 2019 22:00:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TuFWD5LwAutk for <babel@ietfa.amsl.com>; Mon, 18 Nov 2019 22:00:05 -0800 (PST)
Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 53E5D12080F for <babel@ietf.org>; Mon, 18 Nov 2019 22:00:05 -0800 (PST)
Received: by mail-pj1-x1035.google.com with SMTP id f7so2251336pjw.5 for <babel@ietf.org>; Mon, 18 Nov 2019 22:00:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:to; bh=f6bp2SRThe65fLRbDKWOtJL2i6L5va//3Hg98iJDdMY=; b=eWLUQCNN/jDj2TFtDQ4R5iwr19fScbySXRv6/WhGgB2m/vWb2dGupLdzMSgRNjl2xt wvFf+KAnNvjIal9Zu+vyNnSjV909bQrvwOBLJo2Ifq3MWOcVFiHi9p9YWj0CRDBd36L1 BYjR+stX7vnqFNaeRknpsZtZ2mog4YUWvqZR+FL4DdZfTSYDnb99LOKcKayVTY5VXEZA HGSuONDI2XmkT1NBWT2Y4dV4WVA9N5CC1YwFuA8I+6fdizWcghkBbDQiaSL0go/6ICVC Nyli1PG9Y40jDwDa/8uv/nV15fvtrdF89CenNdu4fQFX+MxDeVg7DFFrYlw2JC1zwuer f+Yw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=f6bp2SRThe65fLRbDKWOtJL2i6L5va//3Hg98iJDdMY=; b=o/sU21cGy4D1kfuVWDa2YRimNzIGAoa21FxdDTfhdnMfah2J/u6N7NcXiLvlj8/kMj zizmvExm+DLpZAd6dNPkTr0jMfacObDD0XGqfTOzBXW/dl46fPxLrKagU+VN6Edk7XnK Oq9PjTOycs75EdO/tpA+QWz0OTNqZTCa/5n5qTIE2qd3wbglOdfKm3FstlbYRhIem5X3 dJwptf84bq8cvWR+vozJJoryhlGciRl1ah64/OorNqnjd3/QTTE/sXnlW0fHp3RNlbb3 7RZ4nOOBPaRDAeV/4qSbV9ntm6RKLhgdTNOcMASw+5vxi1SsG4+PmAwnrCZmMjnJO44x eadQ==
X-Gm-Message-State: APjAAAUssDZUow3foIfikWPSQWOy2Ci5by2R4PNtoQvbguYO7YryC4jb JBaITBv17OrKhYjXoNH4ezK7gFmEZEM=
X-Google-Smtp-Source: APXvYqytOTMfiAzJSUmJZT1oc0N4RpZYxgBQFn7hjc1BDr+ZR6Iqi5QooPLi46D9njTTLKlxt/DSjA==
X-Received: by 2002:a17:902:b10b:: with SMTP id q11mr3130120plr.172.1574143204381; Mon, 18 Nov 2019 22:00:04 -0800 (PST)
Received: from dhcp-8d46.meeting.ietf.org (dhcp-8d46.meeting.ietf.org. [31.133.141.70]) by smtp.gmail.com with ESMTPSA id c1sm1577245pjc.23.2019.11.18.22.00.03 for <babel@ietf.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Nov 2019 22:00:03 -0800 (PST)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_35232C3D-0587-48BF-A0EE-185B54246AC6"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Message-Id: <E419D6CE-8F99-450D-8549-846DB1BEE272@gmail.com>
Date: Tue, 19 Nov 2019 14:00:00 +0800
To: Babel at IETF <babel@ietf.org>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/4Z_ZmyJoOZAr-jLXJGrMBjXXonE>
Subject: [babel] YANG errors in datatracker
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Nov 2019 06:00:08 -0000

Hi Donald,

To the question of the two errors being reported in data tracker for the Babel YANG model, I just wanted to confirm that those errors are tooling errors. 

ietf-babel@2019-10-18.yang:96: error: keyword "if-feature" not in canonical order (see RFC 6020, Section 12)
ietf-babel@2019-10-18.yang:103: error: keyword "if-feature" not in canonical order (see RFC 6020, Section 12)

The ABNF grammar for YANG in RFC 7950 (updated version of RFC 6020) says the following for the identity statement where these errors are reported.

identity-stmt       = identity-keyword sep identifier-arg-str optsep
                         (";" /
                          "{" stmtsep
                              ;; these stmts can appear in any order
                              *if-feature-stmt
                              *base-stmt
                              [status-stmt]
                              [description-stmt]
                              [reference-stmt]
                          "}") stmtsep


It is clear that the if-feature statement can appear before/after base-stmt per the above grammar, and as such these errors are tooling errors. I believe that it has been fixed in pyang, but that version of pyang has not been published.

Thanks

Mahesh Jethanandani
mjethanandani@gmail.com