Re: [babel] RtgDir Last Call Review: draft-ietf-babel-source-specific-06

Juliusz Chroboczek <jch@irif.fr> Wed, 28 October 2020 14:06 UTC

Return-Path: <jch@irif.fr>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2BD663A099F; Wed, 28 Oct 2020 07:06:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tAnPp4xAL1VH; Wed, 28 Oct 2020 07:06:28 -0700 (PDT)
Received: from korolev.univ-paris7.fr (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E37CA3A0997; Wed, 28 Oct 2020 07:06:27 -0700 (PDT)
Received: from mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [81.194.30.253]) by korolev.univ-paris7.fr (8.14.4/8.14.4/relay1/82085) with ESMTP id 09SE6Ahj028035; Wed, 28 Oct 2020 15:06:10 +0100
Received: from mailhub.math.univ-paris-diderot.fr (localhost [127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTP id 9E2F8D195A; Wed, 28 Oct 2020 15:06:10 +0100 (CET)
X-Virus-Scanned: amavisd-new at math.univ-paris-diderot.fr
Received: from mailhub.math.univ-paris-diderot.fr ([127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id LEs6TaewgwqV; Wed, 28 Oct 2020 15:06:09 +0100 (CET)
Received: from pirx.irif.fr (82-64-141-196.subs.proxad.net [82.64.141.196]) (Authenticated sender: jch) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTPSA id C46E3D1958; Wed, 28 Oct 2020 15:06:08 +0100 (CET)
Date: Wed, 28 Oct 2020 15:06:07 +0100
Message-ID: <87mu06fnsg.wl-jch@irif.fr>
From: Juliusz Chroboczek <jch@irif.fr>
To: "Hejia (Jia)" <hejia@huawei.com>
Cc: "rtg-ads@ietf.org" <rtg-ads@ietf.org>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-babel-source-specific.all@ietf.org" <draft-ietf-babel-source-specific.all@ietf.org>, "babel@ietf.org" <babel@ietf.org>
In-Reply-To: <38f2e15c65ed40628afe70f73822d1ec@huawei.com>
References: <38f2e15c65ed40628afe70f73822d1ec@huawei.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.1 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (korolev.univ-paris7.fr [194.254.61.138]); Wed, 28 Oct 2020 15:06:10 +0100 (CET)
X-Miltered: at korolev with ID 5F997AD2.003 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Enveloppe: 5F997AD2.003 from mailhub.math.univ-paris-diderot.fr/mailhub.math.univ-paris-diderot.fr/null/mailhub.math.univ-paris-diderot.fr/<jch@irif.fr>
X-j-chkmail-Score: MSGID : 5F997AD2.003 on korolev.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Status: Ham
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/4t3zqYIdQXQ7n73fsSaNsWknCQQ>
Subject: Re: [babel] RtgDir Last Call Review: draft-ietf-babel-source-specific-06
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Oct 2020 14:06:30 -0000

> In Paragraph 5, it is written as

>    This specification
>    extends these messages to optionally carry a Source Prefix sub-TLV,
>    [...]
>    The sub-TLV is marked as mandatory,

> I understand the the Source Prefix sub-TLV is mandatory to support the
> functions defined in this specification.  However, "optionally" used in
> the paragraph above is confusing. One suggestion is to simply delete
> "optionally" in the sentence.

I most respectfully disagree.  The sub-TLV is optional -- non-specific
routes don't carry the sub-TLV, which is the whole reason why the
extension interoperates with unextended Babel.  This is expanded upon in
Section 5:

   A node obeying this specification MUST NOT send a TLV
   with a zero-length source prefix: instead, it sends a TLV with no
   Source Prefix sub-TLV.

I think it's important to stress this fact in this paragraph.  I've
avoided the term "optional", which I believe is what you're objecting to:

   This specification extends these messages so that they may carry
   a Source Prefix sub-TLV,

I don't like the formulation very much, so I'll be grateful if you can
find a better wording.

-- Juliusz