Re: [babel] Éric Vyncke's Discuss on draft-ietf-babel-yang-model-10: (with DISCUSS and COMMENT)

Mahesh Jethanandani <mjethanandani@gmail.com> Wed, 19 May 2021 15:18 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A1C2B3A1421; Wed, 19 May 2021 08:18:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.096
X-Spam-Level:
X-Spam-Status: No, score=-2.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hxgR5i_COK_5; Wed, 19 May 2021 08:18:21 -0700 (PDT)
Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 976A53A1426; Wed, 19 May 2021 08:18:20 -0700 (PDT)
Received: by mail-pg1-x530.google.com with SMTP id v14so6957939pgi.6; Wed, 19 May 2021 08:18:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=XvN23qW6bBeGduRTXJLbnUsLqRGV9rtOK/4Q9LFoG9E=; b=QdxuUBwEHNFSyLAzLZgEi98kd04WEwhVcjQvFDgsAtaD0Awftzu9LAFOxeE8EsNbR7 c+7SMJYE+/cNO1n35hClVsmw1X7ZScXiktGJga2I9tHo9133frmMTznYWYgpQIvUXzUV +vy9PnmvDdoxWGreDTl7o5/fuChODuaqC130g5GeBGgmyifamKY4IhFWPGIOYDH4Gb9p kbW0FJnAV6HxQZX/3iipZ9goKoQWz9BQoIIFUSCAUjY5ysHrVy0pOwLzsEZdtVXzVta7 ck3RWSIqy6UWprQppvrzhJVKnFiLfFx/YPxBoBw3Z5WQZOndrm0z6DVQgqZER+drYiM5 iVUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=XvN23qW6bBeGduRTXJLbnUsLqRGV9rtOK/4Q9LFoG9E=; b=cLH8uUvZCiHVNK6lstuxRkp09AKoeY5rNclnNvH2b4qiwdJsiUN3aI5zTSW1JODpDr XR/W0xGMArC6MnYkKVHi7dRKnU69SUXLYEllZDAInMN+SIoPnvTkLLE63KqItPSP+Vic F7RPWmSjeScNl7QnK2mI1BCixxjpQN4Ew3EITf4PDETHb0xm/C8+PDasP6jYo0w/sECo OaMxL/aID2Mayy2quKQgFm87KapyfcXDkbanGRn2rgwNfLGFG4FKz/TjrHdwS5UsIrCx OJmeK1GOo3vYfK8BdWLPGv7jjbQjJ2vXyLXoKPM+oP1Zp8x0DWZ/LXu2YNovSz58E+J1 G4ow==
X-Gm-Message-State: AOAM530PIToTYduFQtzvrFuIwbG42p2T7W8AgJsZB1N8XaoeKnqAMjRW l110fcjQS0JssYKk1oSbyUg=
X-Google-Smtp-Source: ABdhPJxx7GXGx0p5/JoH/Ttzqzz3fMSfoMvSrHh+bt2SawWuqb44rcvg4oPjtCo3L/c8bJwr6tOaaw==
X-Received: by 2002:aa7:839a:0:b029:27a:8c0b:3f5e with SMTP id u26-20020aa7839a0000b029027a8c0b3f5emr11120916pfm.69.1621437499508; Wed, 19 May 2021 08:18:19 -0700 (PDT)
Received: from ?IPv6:2601:647:5600:5020:2058:9156:1cae:4ffc? ([2601:647:5600:5020:2058:9156:1cae:4ffc]) by smtp.gmail.com with ESMTPSA id t22sm1055589pfg.119.2021.05.19.08.18.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 May 2021 08:18:18 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <A5BAF28D-8856-482A-AA5E-F41ED3BA9BD2@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_F3E36B04-A891-4699-B856-5C22CE633E67"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Wed, 19 May 2021 08:18:16 -0700
In-Reply-To: <20210519.084054.1713468977677987317.id@4668.se>
Cc: =?utf-8?Q?=C3=89ric_Vyncke?= <evyncke@cisco.com>, The IESG <iesg@ietf.org>, draft-ietf-babel-yang-model@ietf.org, babel-chairs <babel-chairs@ietf.org>, Babel at IETF <babel@ietf.org>, Donald Eastlake <d3e3e3@gmail.com>
To: =?utf-8?Q?Martin_Bj=C3=B6rklund?= <mbj+ietf@4668.se>
References: <162124475990.8618.15255310968103028424@ietfa.amsl.com> <39A68691-1C3F-4EF8-8621-D2FC5707B5AA@gmail.com> <20210519.084054.1713468977677987317.id@4668.se>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/5JQqt3chfyidC--BhKtoNdBqJmk>
Subject: Re: [babel] =?utf-8?q?=C3=89ric_Vyncke=27s_Discuss_on_draft-ietf-bab?= =?utf-8?q?el-yang-model-10=3A_=28with_DISCUSS_and_COMMENT=29?=
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 May 2021 15:18:27 -0000

Hi Martin,

> On May 18, 2021, at 11:40 PM, Martin Björklund <mbj+ietf@4668.se> wrote:
> 
> Hi,
> 
>>> 
>>> The YANG module does not compile correctly with PYANG, it should be
>>> easy to fix
>>> though :-) See:
>>> https://yangcatalog.org/results/ietf-babel@2021-05-12_ietf.html
>>> Or is it a PYANG error ?
>> 
>> This is a tooling error (even though I have gone ahead and changed it
>> in the model). The ABNF grammar says the following for identity-stmt
>> in RFC 7950.
>> 
>>   identity-stmt       = identity-keyword sep identifier-arg-str optsep
>>                         (";" /
>>                          "{" stmtsep
>>                              ;; these stmts can appear in any order
>>                              *if-feature-stmt
>>                              *base-stmt
>>                              [status-stmt]
>>                              [description-stmt]
>>                              [reference-stmt]
>>                          "}") stmtsep
>> 
>> According to it, the ‘if-feature’ and ‘base-stmt’ can appear in any
>> order. But for some reason pyang version 2.4.0 insists on a particular
>> order. I will bring this up with tooling folks.
> 
> This is not a tooling error.  The error message is:
> 
>  ietf-babel@2021-05-12.yang <mailto:ietf-babel@2021-05-12.yang>:148: error: keyword "if-feature" not in
>    canonical order (see RFC 6020, Section 12)
> 
> [side note: the RFC ref in this error message should be updated to RFC
> 7950 Section 14]
> 
> The referenced section says:
> 
>   The ABNF grammar [RFC5234] [RFC7405] defines the canonical order.
> 
> When we publish YANG models in RFCs we use the canonical order in
> order to have a consistent format.  pyang checks this when the flag
> --ietf is used.

I am trying to understand, and this is more for my education, what rule within the grammar is determining the canonical order?

Also, should pyang report this as an error, or maybe a warning might be better? After all, this is being done for consistency reasons.

> 
> 
> /martin
> 
> 
> 
>> 
>>> 
>>> 
>>> 
>> ----------------------------------------------------------------------
>>> COMMENT:
>>> 
>> ----------------------------------------------------------------------
>>> 
>>> == COMMENTS ==
>>> 
>>> The related links on should be updated. E.g., the YANG catalog entry
>>> should be:
>>> https://www.yangcatalog.org/yang-search/module_details.php?module=ietf-babel@2021-05-12
>>> 
>>> -- Section 2.2 --
>>> I usually use the expanded tree view rather the YANG module itself to
>>> get a
>>> global view. Is there any reason why the full tree view is not
>>> included?
>> 
>> Added this to the Appendix.
>> 
>>> 
>>> -- Section 5 --
>>> Is there any reason why the doc shepherd is not acknowledged ?
>>> 
>>> == NITS ==
>>> 
>>> -- Section 2.3 --
>>> s/MAC based security/MAC-based security/ ?
>> 
>> Fixed.
>> 
>> Thanks.
>> 
>> Mahesh Jethanandani
>> mjethanandani@gmail.com

Mahesh Jethanandani
mjethanandani@gmail.com