[babel] Éric Vyncke's Discuss on draft-ietf-babel-yang-model-10: (with DISCUSS and COMMENT)

Éric Vyncke via Datatracker <noreply@ietf.org> Mon, 17 May 2021 09:45 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: babel@ietf.org
Delivered-To: babel@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id E48D23A30C2; Mon, 17 May 2021 02:45:59 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Éric Vyncke via Datatracker <noreply@ietf.org>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-babel-yang-model@ietf.org, babel-chairs@ietf.org, babel@ietf.org, Donald Eastlake <d3e3e3@gmail.com>, d3e3e3@gmail.com
X-Test-IDTracker: no
X-IETF-IDTracker: 7.29.0
Auto-Submitted: auto-generated
Precedence: bulk
Reply-To: Éric Vyncke <evyncke@cisco.com>
Message-ID: <162124475990.8618.15255310968103028424@ietfa.amsl.com>
Date: Mon, 17 May 2021 02:45:59 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/5Pxd-FNUDr3y5nnMpmmzkF-mgIE>
Subject: [babel] Éric Vyncke's Discuss on draft-ietf-babel-yang-model-10: (with DISCUSS and COMMENT)
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2021 09:46:00 -0000

Éric Vyncke has entered the following ballot position for
draft-ietf-babel-yang-model-10: Discuss

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-babel-yang-model/



----------------------------------------------------------------------
DISCUSS:
----------------------------------------------------------------------

Thank you for the work put into this document. I really like the fact that the
information model is built before the data model. Congratulations !

Please find below one blocking (but trivial to fix) DISCUSS point, some
non-blocking COMMENT points (but replies would be appreciated), and one nit.

Thank you to Donald Eastlake for his shepherd's write-up (including the WG
consensus).

I hope that this helps to improve the document,

Regards,

-éric

== DISCUSS ==

The YANG module does not compile correctly with PYANG, it should be easy to fix
though :-) See: https://yangcatalog.org/results/ietf-babel@2021-05-12_ietf.html
Or is it a PYANG error ?


----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

== COMMENTS ==

The related links on should be updated. E.g., the YANG catalog entry should be:
https://www.yangcatalog.org/yang-search/module_details.php?module=ietf-babel@2021-05-12

-- Section 2.2 --
I usually use the expanded tree view rather the YANG module itself to get a
global view. Is there any reason why the full tree view is not included?

-- Section 5 --
Is there any reason why the doc shepherd is not acknowledged ?

== NITS ==

-- Section 2.3 --
s/MAC based security/MAC-based security/ ?