Re: [babel] Minor format problem in draft-ietf-babel-yang-model-04

Mahesh Jethanandani <mjethanandani@gmail.com> Thu, 16 January 2020 17:09 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2B2B51200F9 for <babel@ietfa.amsl.com>; Thu, 16 Jan 2020 09:09:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.997
X-Spam-Level:
X-Spam-Status: No, score=-1.997 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U2vaPF7fYiGB for <babel@ietfa.amsl.com>; Thu, 16 Jan 2020 09:09:04 -0800 (PST)
Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 76315120071 for <babel@ietf.org>; Thu, 16 Jan 2020 09:09:04 -0800 (PST)
Received: by mail-pl1-x634.google.com with SMTP id s21so8582135plr.7 for <babel@ietf.org>; Thu, 16 Jan 2020 09:09:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=gxQ/nirg9iN7MfeWmoyHb45baQoLHgeZGsXhjiiP0mg=; b=oJgNToe6ll+URGB89J5xUgtdlfaF1BPoOhHI1DyqVBumyvz5TLjKoEWQWnhIkf7cJF A0Vz6JwS6B1Fiag05dj/R+zq79vlHHhiX/uCMkVhwC5YiVExLdXaLIqD35yg5KN0/Qhp Fj0rmRgAMUdezkD3FXOaWtv/XLp4mHwC14SsAksxwWrHPJ70vzmc8dq51ToGItrUoyYi lLeovYxKVwKMsQ2OFz3qfcKKkVWB/lNjh0qAEgKNw0geN62woNpw0rfWxHInF3himzfG c3ZRi58KPdSWpW2u8cWiq6ukQcgJ6Lb8LNQf4mLgQZ8XRVooMWU2Ix+Ny3DgjT8PEOVa leMQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=gxQ/nirg9iN7MfeWmoyHb45baQoLHgeZGsXhjiiP0mg=; b=dCjuYYPVddcuUHfb15WF8s0dpJI8HZNLgULSHGy5tdAr8yzFg20SsP+g/91BcGgvbP +uit4eJPvUD0X080aUJ2XPid8rnE1qa2rCZe+Kdev60V6gGFeY8KjUokfk2Yw159OYNn Gfkmhwq0+3c9lw7KHK17WeyhGD8mgYuNzeZjDny6Sq1zn8MxHBVGMAJzPQkQBRG9dLYR 3X+yawyAZs3cObqDeDjSUwJHIxei70HZU96XGbV09Phv3co/VXQlj1c9co4+tKI9RmuP 0ZIegRIehktw49hviFiP5sThSS3VVUILmsX5n1Hw4CC/8hOgVjxHhCB+B0H4621Hb6hn EUrA==
X-Gm-Message-State: APjAAAXiUcioyp9edCeuIvmbp9Je9KwZ9qRTl/BaRK1rxDGaQVoAPxTV 6PvKfqxzlRSIsnkM6ov1fLw=
X-Google-Smtp-Source: APXvYqwC4CthUZUtHQBwr/iBvgCn5UDN0a+voA4VHAhcgexCYI3jjNNL4sEr8AFDFU/MjKvdmu/khQ==
X-Received: by 2002:a17:90a:a88d:: with SMTP id h13mr98397pjq.48.1579194543852; Thu, 16 Jan 2020 09:09:03 -0800 (PST)
Received: from ?IPv6:2601:647:5600:5020:e0c6:5b71:3740:4743? ([2601:647:5600:5020:e0c6:5b71:3740:4743]) by smtp.gmail.com with ESMTPSA id r62sm27100265pfc.89.2020.01.16.09.09.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jan 2020 09:09:02 -0800 (PST)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <4C66C87A-5BC7-49D3-9E88-7EA853483398@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_7B027AF1-9426-4B66-82F7-8851A93F9FF1"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Thu, 16 Jan 2020 09:09:01 -0800
In-Reply-To: <CAF4+nEFv69CsadEM78bU3ZJAD_=PM-6aUJDg_5iFD0un19WcxA@mail.gmail.com>
Cc: "STARK, BARBARA H" <bs7652@att.com>, Babel at IETF <babel@ietf.org>
To: Donald Eastlake <d3e3e3@gmail.com>
References: <CAF4+nEF2enPsrNk+RvDRBJiycpjKe17W50=OJV2XOK7rKdjgfA@mail.gmail.com> <CC940348-5659-4FF3-9ECD-BA67043EB02B@gmail.com> <CAF4+nEGmi3nOBw+CrNdQpg8rQsu3GOdX2KG0tmzOw1Hi3VEgGg@mail.gmail.com> <98799C32-6591-475E-B9F3-B6E31D828154@gmail.com> <2D09D61DDFA73D4C884805CC7865E61153729C3E@GAALPA1MSGUSRBF.ITServices.sbc.com> <1149EE36-765D-449B-BF23-A68DFB55E3B2@gmail.com> <CAF4+nEFv69CsadEM78bU3ZJAD_=PM-6aUJDg_5iFD0un19WcxA@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/5TO5mCpthrkvKAQNlIZOnKWzfBg>
Subject: Re: [babel] Minor format problem in draft-ietf-babel-yang-model-04
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Jan 2020 17:09:09 -0000

Hi Donald,

> On Jan 15, 2020, at 6:38 PM, Donald Eastlake <d3e3e3@gmail.com>; wrote:
> 
> Hi Mahesh,
> 
> Thanks for posting an update to the Babel YANG draft. Does this includes all the changes you currently think needed?

Yes.

> If so, I think we could just do a brief WG Last Call and then proceed to request publication.

Okay.

Thanks.

> 
> For people's information, the diff against the previous version is
> https://tools.ietf.org/rfcdiff?url2=draft-ietf-babel-yang-model-05.txt <https://tools.ietf.org/rfcdiff?url2=draft-ietf-babel-yang-model-05.txt>
> 
> Thanks,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  2386 Panoramic Circle, Apopka, FL 32703 USA
>  d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>
> 
> On Mon, Jan 6, 2020 at 2:07 PM Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>> wrote:
> Hi Barbara,
> 
> You bring up a good point.
> 
> Have added feature statements for security, MAC and certificate types, and made the identity statements conditional on the features being declared. Also beefed up the example to show how the system could be configured for HMAC-SHA256 MAC algorithm.
> 
> Thanks.
> 
>> On Jan 6, 2020, at 6:39 AM, STARK, BARBARA H <bs7652@att.com <mailto:bs7652@att.com>> wrote:
>> 
>> Hi Mahesh,
>> In looking over this change, I’m trying to understand how indicating supported metric computation algorithms (expressed through feature + identity statements, but no leaf-list) differs from indicating supported security mechanisms, MAC algorithms, and certificate types (expressed through identity statements + leaf-list).
>>  
>> Why would we not use the same approach for all 4 of these?
>> Barbara
>>  
>> From: babel <babel-bounces@ietf.org <mailto:babel-bounces@ietf.org>> On Behalf Of Mahesh Jethanandani
>> Sent: Friday, January 03, 2020 4:22 PM
>> To: Donald Eastlake <d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>>
>> Cc: Babel at IETF <babel@ietf.org <mailto:babel@ietf.org>>
>> Subject: Re: [babel] Minor format problem in draft-ietf-babel-yang-model-04
>>  
>> Hi Donald,
>>  
>> In trying to make the changes you requested, I came across another change that needs to be pushed.
>>  
>> The information model suggests that babel-information-obj should maintain a list of metric-comp-algorithm that are supported by an implementation. The problem with just keeping a list in YANG is that there is no way to enforce that the implementation uses only those algorithms. To address the issue we had introduced the concept of features in -04 version of the draft.
>>  
>> Using the feature statement, the implementation can declare which of the metric-comp-algorithms it supports, which was the intention of having a list of those algorithms in the first place. As such, we do not need the global list anymore, and needs to be removed. I will be adding that change in the -05 version of the draft.
>>  
>> If you feel that it requires a short LC to be issued, please feel free to do so after I post the draft.
>>  
>> Thanks.
>> 
>> 
>> On Jan 3, 2020, at 10:32 AM, Donald Eastlake <d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>> wrote:
>>  
>> Hi Mahesh,
>>  
>> You're welcome. My apologies for not noticing it earlier. Can you go ahead and post a revision with this trivial change?
>> 
>> Thanks,
>> Donald
>> ===============================
>>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>>  2386 Panoramic Circle, Apopka, FL 32703 USA
>>  d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>
>>  
>>  
>> On Fri, Jan 3, 2020 at 2:21 AM Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>> wrote:
>> Hi Donald,
>>  
>> Yes, that should be ok. And thanks for catching it.
>>  
>> Cheers.
>> 
>> Mahesh Jethanandani
>> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
>> 
>> On Jan 2, 2020, at 8:27 PM, Donald Eastlake <d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>> wrote:
>> 
>> Hi Mahesh,
>> 
>> Happy New Year!
>> 
>> There seems to be a minor format problem in this draft, in particular four lines, all identical, that are 76 characters long. Lines over 72 characters are not allowed in Internet Drafts.
>> 
>> On page 34, page 35, page 36, and page 38 the following line occurs:
>>             xmlns:babel="urn:ietf:params:xml:ns:yang:ietf-babel">babel:babel
>> Is it possible to fold this into something like
>>             xmlns:babel=
>>                 "urn:ietf:params:xml:ns:yang:ietf-babel">babel:babel
>> or just reduce the indent of those lines?
>> 
>> Thanks,
>> Donald
>> ===============================
>>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>>  2386 Panoramic Circle, Apopka, FL 32703 USA
>>  d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>
>>  
>> Mahesh Jethanandani
>> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
> 
> 
>