IETF Logo Mail Archive

Re: [babel] [Gen-art] Genart last call review of draft-ietf-babel-dtls-05

Alissa Cooper <alissa@cooperw.in> Thu, 08 August 2019 13:13 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C5093120075; Thu, 8 Aug 2019 06:13:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.699
X-Spam-Level:
X-Spam-Status: No, score=-2.699 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=1zI2hptd; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=UTRTLPa0
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id olZTtexWBv0r; Thu, 8 Aug 2019 06:13:00 -0700 (PDT)
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E3C5A12001B; Thu, 8 Aug 2019 06:12:56 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id ECD0B3FD; Thu, 8 Aug 2019 09:12:55 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 08 Aug 2019 09:12:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= from:message-id:content-type:mime-version:subject:date :in-reply-to:cc:to:references; s=fm3; bh=yfncU4XsQLUA10MnGeSu5dU EXTPgjpXsNWWrf+BQ+N0=; b=1zI2hptdwoGXeHNMJInvAYMrz1P8EO5FDKNUl43 AXVkP4loQ9VyDnMwca1kzENzzExikYzyfsxfw1rphhcpgzt69kMjwX8K50mG4r+0 nMc7NckU1/lobkyhp/US4Gb5Dj5egh18JQm2YLjiPZcqCge/V03Vwd0OyyfGd7bx hdGkm953CymDSVa6xJ59FsQ+2xp873C0nmdaefia1SCow+1ZxsD8yX85ciQK0q1F RPlG5sNCYlULzO9Y1n4kcXm0uBLSmCdUYXqNRN+odvr0+aQsHtII4uxJ086ldqu0 v+SYqueH0HFELspjo7zymloKy+4+/RFikhcZ62JjkEAk5Sg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=yfncU4 XsQLUA10MnGeSu5dUEXTPgjpXsNWWrf+BQ+N0=; b=UTRTLPa0oj2w+EkX20xlz/ YHPJh4GIq0aK4mb4FpEo625B4K7BRnIwYMwN/I/0WH3vyapoueoCkoz1sHChVCPk svEDa6Z7Q0NU+qM6LxVrlL5PMoPYxGV1NUSqHXi1pUS47mJ/cQzc1Lc0hBPw4YpP If8waqqH4X/A7Y947MFBdkZ5OY/yw+HYME1+F4iXpPHGg1DTsq4DOZJtWE75pzvs jcuaUC9IUs7kwUNP268Jp0Ccy81W+jV269+IehZssPWpYoqYn24JHP56XRjRGPtG au7aWIloNVXvH8OuipW6exOLF2J24bpxMbxm4ETSH6CTNVmMTgeemqKM9Al2X3Fw ==
X-ME-Sender: <xms:1x9MXVWkZbZBpfpEkvbQZ_JDfkon3OBrK77KCYV9zeUwGhVCWdqrSw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduhedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgfvfhfosegrtdhmrehhtddvnecuhfhrohhmpeetlhhishhs rgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomhgrih hnpehgihhthhhusgdrtghomhdpihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddu jedrjeefnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfi drihhnnecuvehluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:1x9MXWAdtEoV1zEWC5yk6NqNgf38s612TcGFOI3Qwtqd9d3GJuiehQ> <xmx:1x9MXW0FU8o5yefRiPc3n4TMMg_MgeNJUl1moXPtNSIZ3TKuPGDAIw> <xmx:1x9MXWSU7VhTL4MRRY58p83gGxPRqteM03mbcS8gybHN72Deaeg7Cw> <xmx:1x9MXa93TsGr_yUrqMs-ARxbqjy9s265TM9QxZJYwLwdSrjmBC8BJg>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.73]) by mail.messagingengine.com (Postfix) with ESMTPA id A92F9380086; Thu, 8 Aug 2019 09:12:54 -0400 (EDT)
From: Alissa Cooper <alissa@cooperw.in>
Message-Id: <F7755073-A62E-49F4-BDFE-48F0A93E6ABD@cooperw.in>
Content-Type: multipart/alternative; boundary="Apple-Mail=_11E64E68-54FF-4C1E-A105-348142153C20"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Thu, 08 Aug 2019 09:12:53 -0400
In-Reply-To: <CAPDSy+72+4PUqnTb6ohW6rXovPMm=8Pw2x1o7OH_ngubxQiqSA@mail.gmail.com>
Cc: draft-ietf-babel-dtls.all@ietf.org, gen-art <gen-art@ietf.org>, IETF Discussion <ietf@ietf.org>, Babel at IETF <babel@ietf.org>
To: David Schinazi <dschinazi.ietf@gmail.com>, Dan Romascanu <dromasca@gmail.com>
References: <156148141106.31261.11148445355862352575@ietfa.amsl.com> <CAPDSy+5RSzULfPF71Uq-Jkrm7XH7Quj00_jZ9WcdpbaX3qk5bA@mail.gmail.com> <CAFgnS4Wmk9C1fVjMZa_Q0MXbSCoxd+fUDK62kKTJsdwHA8YROg@mail.gmail.com> <CAPDSy+72+4PUqnTb6ohW6rXovPMm=8Pw2x1o7OH_ngubxQiqSA@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/5gOWKKBOkempBzxMwRthIcxPPbY>
Subject: Re: [babel] [Gen-art] Genart last call review of draft-ietf-babel-dtls-05
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Aug 2019 13:13:02 -0000

Dan, thanks for your review. David, thanks for the update. I entered a No Objection ballot.

Alissa


> On Jun 25, 2019, at 3:19 PM, David Schinazi <dschinazi.ietf@gmail.com> wrote:
> 
> Thanks Dan. I've pushed a commit with your suggestions:
> https://github.com/jech/babel-drafts/commit/8d6a6fc05ce4c621b38d2c7621c4157300380078 <https://github.com/jech/babel-drafts/commit/8d6a6fc05ce4c621b38d2c7621c4157300380078>
> 
> We'll upload -06 at the end of this round of comments.
> 
> David
> 
> On Tue, Jun 25, 2019 at 11:41 AM Dan Romascanu <dromasca@gmail.com <mailto:dromasca@gmail.com>> wrote:
> Thanks for the quick reply. 
> 
> See in-line. 
> 
> regards,
> 
> Dan
> 
> 
> On Tue, Jun 25, 2019 at 9:29 PM David Schinazi <dschinazi.ietf@gmail.com <mailto:dschinazi.ietf@gmail.com>> wrote:
> Hello Dan, and thanks for your review. Comments inline.
> 
> 1. In section 2.1:
> 
> > The default port
>    for Babel over DTLS is registered with IANA as the "babel-dtls" port
>    (UDP port TBD, see Section 4), and the port exchanging unencrypted
>    Babel traffic is registered as the "babel" port (UDP port 6696).
> 
> A reference would be desirable here.
> 
> What reference do you have in mind? This paragraph already has a
> reference to Section 4 (IANA Considerations).
> 
> the section in the Babel spec that defines the "babel" port (UDP port 6696, see ....)
> 
> 
>  
> 2. In section 2.4
> 
> > Nodes MUST silently ignore any unprotected
>    packet sent over unicast.  When parsing an unprotected packet, a node
>    MUST silently ignore all TLVs that are not of type Hello.  Nodes MUST
>    also silently ignore any unprotected Hello with the Unicast flag set.
> 
> Is the last sentence necessary? Is this case not covered by the statement in
> the first sentence?
> 
> The Unicast flag is a bit in the Babel packet. This statement instructs nodes
> to ignore a Hello TLV which was received over multicast but has the unicast flag set.
> 
> Thanks for the clarification. 
> 
> 
> Thanks,
> David
>  
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

v2.23.0 | Report a Bug | By Email