Re: [babel] Genart last call review of draft-ietf-babel-yang-model-09

Mahesh Jethanandani <mjethanandani@gmail.com> Thu, 06 May 2021 22:13 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DD2363A0B69; Thu, 6 May 2021 15:13:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.096
X-Spam-Level:
X-Spam-Status: No, score=-2.096 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FOXXzwDv2ME8; Thu, 6 May 2021 15:13:36 -0700 (PDT)
Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E23813A0B6C; Thu, 6 May 2021 15:13:35 -0700 (PDT)
Received: by mail-pl1-x62b.google.com with SMTP id t21so4147222plo.2; Thu, 06 May 2021 15:13:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=YfWffnF8ag9ZepBz4gDgJmdGPvXq09FlNVk/SoeHcUI=; b=kdjmyK0Rcl5c6w9eXYFuysde/8cmxg0kZirqgh1WZZ8lkEshMxabSZDgL1PND29oT6 gB1px1UTKoKYF/q3+1KbRjUU6FZAk0krisTmI4KJdSGj7cJm4a6BI6ELXiRs7dkUcgEi eJVe1VHn52Fs3MZxPd9fOYyTzld0tcVjKf4VY7mOVPF0Y7NmJD542CSDao4zj8kx5wxc Q/5zPFufP3OAofTff2awbg2nqJvyuxRioOVhYina+2izu9JcKQoLX1KNoTiWVnZHrg9r aJ3bv/KAvphPz/MTcyrJg2uD2urtKQJWzpW7BKv/fkY0yQgbIp6OMX/w+J1VvvAWEGhq WLcA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=YfWffnF8ag9ZepBz4gDgJmdGPvXq09FlNVk/SoeHcUI=; b=pcHsBAQ04O/ESWrClESzhWkdscrGyr3OqFz2S5vOgzIZ69OyRzJeDgmpEPoSOmxTid ACaQXDy1i+1JWD6Zmsnzac8IU3XAVKJJTyA2pb+F8JZRpdwpvSA4sRSgpIS3/zxhJdJY vBSDNEF+e7Ow0XlrMj/wkp6RZdGKevSGTnKkSP/Htn34LZh52Dm5hyoqSm6L/u9xn9WJ D7rpxen+ZbOkuB0NJQ2xKgLEdZgkmqBqvjlza/fXAH8JEDFDBs9BKrHRdztPU9QriENr z70rMC0WZTtvCmDYk0oEq8mfcy///y/ucs6mfA0FXJtQEgO5bX6P5L4gyyCfrkhhGB7E r2dQ==
X-Gm-Message-State: AOAM531wl2UKE0Jk0N6hJ+3R2ySZ3SRkTDcTXdSE+hLoW6gJ7FWcIxEW 7r+YlrgXOwBh6bF4lF2Udj4=
X-Google-Smtp-Source: ABdhPJybTRG2B/vI4TGoRPUJeBlvKknYiFDZrMawauswEE9qQx4yK1Pe+vZHA0bPd5gJsI2yldXB9Q==
X-Received: by 2002:a17:90a:df08:: with SMTP id gp8mr7125396pjb.199.1620339214068; Thu, 06 May 2021 15:13:34 -0700 (PDT)
Received: from ?IPv6:2601:647:5600:5020:5982:1aa9:1959:d934? ([2601:647:5600:5020:5982:1aa9:1959:d934]) by smtp.gmail.com with ESMTPSA id q11sm2835744pjq.6.2021.05.06.15.13.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 May 2021 15:13:33 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <675244A6-E079-498E-8D65-8D420A060F07@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_316BA69A-D0F1-4E78-B8D8-E0A98F976F04"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Thu, 6 May 2021 15:13:32 -0700
In-Reply-To: <162014997938.23614.6494865677211981729@ietfa.amsl.com>
Cc: gen-art@ietf.org, babel@ietf.org, draft-ietf-babel-yang-model.all@ietf.org, last-call@ietf.org
To: Stewart Bryant <stewart.bryant@gmail.com>
References: <162014997938.23614.6494865677211981729@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/6px_9znpST_We0Qq2yHP-uDr9jM>
Subject: Re: [babel] Genart last call review of draft-ietf-babel-yang-model-09
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 May 2021 22:13:42 -0000

Hi Stewart,

Thanks for reviewing the document. I have addressed your nits and will be available as part of -10 version of the draft.

Cheers.

> On May 4, 2021, at 10:39 AM, Stewart Bryant via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Stewart Bryant
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-babel-yang-model-09
> Reviewer: Stewart Bryant
> Review Date: 2021-05-04
> IETF LC End Date: 2021-04-22
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: A well written text that is ready for publication. Just one note and a
> couple of minor nits.
> 
> Major issues: None
> 
> Minor issues:
> 
> 5.  Acknowledgements
> Juliusz Chroboczek provided most of the example configurations for babel that
> are shown in the Appendix.
> 
> The Appendix seems seems quite substantive, I am surprised that Juliusz was not
> listed as an author.
> 
> Nits/editorial comments:
> 2.1.  Information Model
> 
> " attributes are marked a read-only objects in the information module"
> SB> s/marked a/marked as/
> 
> 2.3.  YANG Module
> "On other hand, for a"
> 
> SB> s/On other hand/On the other hand/
> 
> 

Mahesh Jethanandani
mjethanandani@gmail.com