Re: [babel] [Last-Call] RtgDir review: draft-ietf-babel-information-model-11.txt

Mahesh Jethanandani <mjethanandani@gmail.com> Tue, 20 October 2020 20:16 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2DF7A3A135A; Tue, 20 Oct 2020 13:16:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8kB56eX9jmKL; Tue, 20 Oct 2020 13:15:59 -0700 (PDT)
Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id CA8FD3A1356; Tue, 20 Oct 2020 13:15:59 -0700 (PDT)
Received: by mail-pg1-x530.google.com with SMTP id o7so25871pgv.6; Tue, 20 Oct 2020 13:15:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=7sopEZgAElrZvNUVhvjrvtlMpOHi/8RqRd8mXHvxYLo=; b=DhstvAg/Uuk1U0Ewcsevk+HZLiCu9OrjMppNHwqKLX8Fv+TFDRc5V23xAtlySH1nJM XQQNIMkgcqBkRXJm9vyPPsgYmEledoJpeUi174zJTM/4GHopqLvMwcpv4FwuweIxd6n8 L9MQK3jYS4EBm+vi3YVX8Pqw+k36cBSx5NAMDB8RUjrc17M0bESmLUgQsYIZPbg0/oDG z9z6oJ+OoEnys3C7av1uZP0YMC8mQ9JJS2WB8WmHEHIk202cCPC5hKx7zdQt3KfMSSzh /NcxRfcAOD/Swp1xmc0L4bMCzTxFDTYHq/9y0Fp32qA7blSme60jBaxFE+LZJOt84s/Q hPiQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=7sopEZgAElrZvNUVhvjrvtlMpOHi/8RqRd8mXHvxYLo=; b=jZv2xZrGFk6c9kT9OE8GfLwS5QMSJCCSGiHGGEY+VyigjCOpz3dNGr11jBbUnOQb46 rlL4QL2kHybbsh8g24LSZx9sIk2mEdyz09xk7xayXm+AGSpLCGbjRH46E4QXo8+JOYDV ++oUkMfa9tuSH1+Qm1cdG5I2UXizf7OQF6kkhpBVYmQn7N+mBPn4t/oLt1SvJnK7CpRS BxYRqXzjFsJ6EqZbKPhK1oJXMj5mEz5eDjFPJ01kl2OLJ39dAeUdodVCX9JIylXHQpSG Rz4JkQ8pPOe5ttxreGsfg8dvlysj6Z8MPrJptiUzxA/bYwTfxOREpvXXaGEn+So0HcFQ QiLA==
X-Gm-Message-State: AOAM533meSc+DHElPKwIbBfXJceuBudWBEPBxKPBweiYzx6i1ZTekz5O MDaXrFmoSuaJG62Vb/q6Dfs=
X-Google-Smtp-Source: ABdhPJzvc0/H+UpSNU8DbkWO2gAIC3tFNQZSv6q1xb0BwXE3ANxZ3mRJYOyB6eE5DZaXTBpSPm/H4Q==
X-Received: by 2002:a63:210d:: with SMTP id h13mr57293pgh.280.1603224959272; Tue, 20 Oct 2020 13:15:59 -0700 (PDT)
Received: from ?IPv6:2601:647:5600:5020:8843:8d02:a04f:df46? ([2601:647:5600:5020:8843:8d02:a04f:df46]) by smtp.gmail.com with ESMTPSA id bj17sm41720pjb.15.2020.10.20.13.15.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Oct 2020 13:15:57 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <353238C9-012E-4426-B8AD-41B28510D019@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_E0F960E7-6A5F-4026-A829-5D07D202CAD3"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Tue, 20 Oct 2020 13:15:56 -0700
In-Reply-To: <8A4D5F57-4F4D-4DE3-BEC2-EB7118069CA2@apnic.net>
Cc: Juliusz Chroboczek <jch@irif.fr>, Joe Abley <jabley@hopcount.ca>, rtg-ads@ietf.org, rtg-dir@ietf.org, draft-ietf-babel-information-model.all@ietf.org, babel@ietf.org, last-call@ietf.org
To: Geoff Huston <gih@apnic.net>
References: <8EAB2DD3-8337-42D6-ACC6-82197CC958E9@apnic.net> <C24C7E7B-DDE9-42BD-B71E-7FF48263CA8B@hopcount.ca> <87v9f5vz8v.wl-jch@irif.fr> <8A4D5F57-4F4D-4DE3-BEC2-EB7118069CA2@apnic.net>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/D04TYvgl_4O_hfNIlsFHFalv3BE>
Subject: Re: [babel] [Last-Call] RtgDir review: draft-ietf-babel-information-model-11.txt
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2020 20:16:01 -0000

Hi Geoff,

Appreciate your review and pointing out the nits as you see them.

> On Oct 20, 2020, at 9:36 AM, Geoff Huston <gih@apnic.net> wrote:
> 
> Why define some intergers as unsigned 16 bit values yet leave strings of undefined maximum length. Can I stuff a novel into the field? How about all of wikipedia? The point is why is the document inconsistent about its treatment opf the range of acceptable values in terms of size?

The reason some variables have fixed length by virtue of the fact that they are unsigned int or unsigned short is because we have a better sense of what the range of those values are. For example, you do not want the babel-mcast-hello-interval to be more than 32 bit long. The same is not true for something like babel-interface-metric-algorithm, which is a name. While we could artificially limit the string value to say 40 characters, what is to say that someone cannot come up with a name that is 41 characters long.

Implementations of this information model, whether they are YANG data model or some other modeling language can choose to further restrict the size of the string. But even there, I have seen YANG models deferring it to particular implementations to refine the definition by adding a size attribute to the node. At an information model level we are poor judges of what size string is ok for any given variable.

Thanks.

Mahesh Jethanandani
mjethanandani@gmail.com