[babel] Yangdoctors last call review of draft-ietf-babel-yang-model-09

Radek Krejčí via Datatracker <noreply@ietf.org> Sat, 01 May 2021 20:29 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: babel@ietf.org
Delivered-To: babel@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1EAFA3A0DBA; Sat, 1 May 2021 13:29:46 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Radek Krejčí via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: babel@ietf.org, draft-ietf-babel-yang-model.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.28.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161990098603.26817.6467081462726716234@ietfa.amsl.com>
Reply-To: Radek Krejčí <radek.krejci@gmail.com>
Date: Sat, 01 May 2021 13:29:46 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/FZDJONCdnqmJwQMrGqG-isUC8So>
Subject: [babel] Yangdoctors last call review of draft-ietf-babel-yang-model-09
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 01 May 2021 20:29:46 -0000

Reviewer: Radek Krejčí
Review result: Ready with Nits

This is my YANG doctor review of draft-ietf-babel-yang-model containing
ietf-babel@2021-03-12.yang module. The draft and the module are well written
and I have just two minor comments:

- The copyright year in the YANG module should be probably 2021, not 2020.

- Some values of the specific statements (e.g. min-elements) are quoted despite
it is not necessary (the value must be a number or a single word). I propose to
use pyang/yanglint to generate the module since it also unifies all the
formatting and quoting.