[babel] Yangdoctors last call review of draft-ietf-babel-yang-model-09

Radek Krejčí via Datatracker <noreply@ietf.org> Sat, 01 May 2021 20:29 UTC

MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
From: Radek Krejčí via Datatracker <noreply@ietf.org>
To: yang-doctors@ietf.org
Cc: babel@ietf.org, draft-ietf-babel-yang-model.all@ietf.org, last-call@ietf.org
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161990098603.26817.6467081462726716234@ietfa.amsl.com>
Reply-To: Radek Krejčí <radek.krejci@gmail.com>
Date: Sat, 01 May 2021 13:29:46 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/FZDJONCdnqmJwQMrGqG-isUC8So>
Subject: [babel] Yangdoctors last call review of draft-ietf-babel-yang-model-09

Reviewer: Radek Krejčí
Review result: Ready with Nits

This is my YANG doctor review of draft-ietf-babel-yang-model containing
ietf-babel@2021-03-12.yang module. The draft and the module are well written
and I have just two minor comments:

- The copyright year in the YANG module should be probably 2021, not 2020.

- Some values of the specific statements (e.g. min-elements) are quoted despite
it is not necessary (the value must be a number or a single word). I propose to
use pyang/yanglint to generate the module since it also unifies all the
formatting and quoting.

[babel] Yangdoctors last call review of draft-iet… Radek Krejčí via Datatracker
Re: [babel] Yangdoctors last call review of draft… Mahesh Jethanandani