Re: [babel] Éric Vyncke's Discuss on draft-ietf-babel-yang-model-10: (with DISCUSS and COMMENT)

Mahesh Jethanandani <mjethanandani@gmail.com> Wed, 19 May 2021 04:10 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D2613A1CEB; Tue, 18 May 2021 21:10:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EMg92n2MJm4T; Tue, 18 May 2021 21:10:24 -0700 (PDT)
Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0EFFC3A1CEC; Tue, 18 May 2021 21:10:20 -0700 (PDT)
Received: by mail-pj1-x1032.google.com with SMTP id o17-20020a17090a9f91b029015cef5b3c50so2766153pjp.4; Tue, 18 May 2021 21:10:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=AjMGJIjYo6YcbM9kfF1zDrJi+HP9q+vKr8CcxDvz75s=; b=k5nO+6kwrgDYOUAGCoq2Pg4ECn7Cdl1zSJ/gcEi6scnCY4+BlXaTW+gedvxOipM4UI rRjw3d6FP+RwMakPLHtvWhW4GHq+C2haj8A/2SzVo4KUouvxqFt5AUJCWvb0eyPAg4Tb O9ySmNiExeogGEN+8+hg11qfsH+HzxHo36jgvcMW5kZzwn/H1yHsLy8urYXq81tgOFQe l2TfCurQdX50/4BZ9A2pLeRiY0arg4Oto+9P+dnscxf/p6OUr72Fgwhr2hlWVHUMZUE2 xUpNvNrOCNZZQn9lE7AUCrCx8jbvABjYJmnc5RqadhfQ6zVINMsx+JUxxPFqgoXkM5N5 RSUQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=AjMGJIjYo6YcbM9kfF1zDrJi+HP9q+vKr8CcxDvz75s=; b=J/d88X+PWCjIL9DsXKr1wX1kcsxvxXuteRIUAou9iVuLXBp1aWAsgBEnHKQ3HhUVdt 3tsR1W7IixqyDkl3jWt/j+KRqsGpbusoOUnjqRRRLxHA1zTSx5kCjogukhw2E6skikr8 RvpmLB/mFs7Vrba8CeBbrDunJ0hiuF9F+LYjUDIjdRGt1NFPPgdYklLoLFa//E3V26ZD pgdBW02/q60cw3sDeHrRUmaSDOpN63ERA2EgZbRd7UO4Rz5f060kTnPBA8MMtFjX9nRm RDAbIExE29oTYiA0OGJ9Ffa4t4kaM002N8J57ZeI0cwSn5+DKCky3zWcFXfN/faME3tZ 5rDQ==
X-Gm-Message-State: AOAM532kv0CJ4TBg45WTBvkacIveXxZmlHwBZbyhvtDJJZikOGolG8pd uHmIKmprZl66qlXQTeq6LAY=
X-Google-Smtp-Source: ABdhPJxDN6VGd34HPfh00wvJukgAUfO97zJn4oDiNNxS3tnPXBZt8EY6XxDz6cwnsNk9XoNdf7w1Vg==
X-Received: by 2002:a17:90a:8902:: with SMTP id u2mr9386477pjn.143.1621397418956; Tue, 18 May 2021 21:10:18 -0700 (PDT)
Received: from ?IPv6:2601:647:5600:5020:6d33:9714:88ad:dd50? ([2601:647:5600:5020:6d33:9714:88ad:dd50]) by smtp.gmail.com with ESMTPSA id v18sm13826206pff.90.2021.05.18.21.10.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 May 2021 21:10:18 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <39A68691-1C3F-4EF8-8621-D2FC5707B5AA@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_2AAB24A4-C81F-482B-BF2A-483D7E086F46"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Tue, 18 May 2021 21:10:17 -0700
In-Reply-To: <162124475990.8618.15255310968103028424@ietfa.amsl.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-babel-yang-model@ietf.org, babel-chairs <babel-chairs@ietf.org>, Babel at IETF <babel@ietf.org>, Donald Eastlake <d3e3e3@gmail.com>, =?utf-8?Q?Martin_Bj=C3=B6rklund?= <mbj+ietf@4668.se>
To: =?utf-8?Q?=C3=89ric_Vyncke?= <evyncke@cisco.com>
References: <162124475990.8618.15255310968103028424@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/LNt4r5P2RJAFxyE-UChsDubM4Dc>
Subject: Re: [babel] =?utf-8?q?=C3=89ric_Vyncke=27s_Discuss_on_draft-ietf-bab?= =?utf-8?q?el-yang-model-10=3A_=28with_DISCUSS_and_COMMENT=29?=
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 19 May 2021 04:10:29 -0000

Hi Eric,

Thank you for the review. See inline.

> On May 17, 2021, at 2:45 AM, Éric Vyncke via Datatracker <noreply@ietf.org> wrote:
> 
> Éric Vyncke has entered the following ballot position for
> draft-ietf-babel-yang-model-10: Discuss
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-babel-yang-model/
> 
> 
> 
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
> 
> Thank you for the work put into this document. I really like the fact that the
> information model is built before the data model. Congratulations !
> 
> Please find below one blocking (but trivial to fix) DISCUSS point, some
> non-blocking COMMENT points (but replies would be appreciated), and one nit.
> 
> Thank you to Donald Eastlake for his shepherd's write-up (including the WG
> consensus).
> 
> I hope that this helps to improve the document,
> 
> Regards,
> 
> -éric
> 
> == DISCUSS ==
> 
> The YANG module does not compile correctly with PYANG, it should be easy to fix
> though :-) See: https://yangcatalog.org/results/ietf-babel@2021-05-12_ietf.html
> Or is it a PYANG error ?

This is a tooling error (even though I have gone ahead and changed it in the model). The ABNF grammar says the following for identity-stmt in RFC 7950.

   identity-stmt       = identity-keyword sep identifier-arg-str optsep
                         (";" /
                          "{" stmtsep
                              ;; these stmts can appear in any order
                              *if-feature-stmt
                              *base-stmt
                              [status-stmt]
                              [description-stmt]
                              [reference-stmt]
                          "}") stmtsep

According to it, the ‘if-feature’ and ‘base-stmt’ can appear in any order. But for some reason pyang version 2.4.0 insists on a particular order. I will bring this up with tooling folks.

> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> == COMMENTS ==
> 
> The related links on should be updated. E.g., the YANG catalog entry should be:
> https://www.yangcatalog.org/yang-search/module_details.php?module=ietf-babel@2021-05-12
> 
> -- Section 2.2 --
> I usually use the expanded tree view rather the YANG module itself to get a
> global view. Is there any reason why the full tree view is not included?

Added this to the Appendix.

> 
> -- Section 5 --
> Is there any reason why the doc shepherd is not acknowledged ?
> 
> == NITS ==
> 
> -- Section 2.3 --
> s/MAC based security/MAC-based security/ ?

Fixed.

Thanks.

Mahesh Jethanandani
mjethanandani@gmail.com