Re: [babel] Éric Vyncke's Discuss on draft-ietf-babel-yang-model-10: (with DISCUSS and COMMENT)

[Mahesh Jethanandani <[e-mail]>]

Hi Eric,

Thank you for the review. See inline.

> On May 17, 2021, at 2:45 AM, Éric Vyncke via Datatracker <[e-mail]> wrote:
> 
> Éric Vyncke has entered the following ballot position for
> draft-ietf-babel-yang-model-10: Discuss
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-babel-yang-model/
> 
> 
> 
> ----------------------------------------------------------------------
> DISCUSS:
> ----------------------------------------------------------------------
> 
> Thank you for the work put into this document. I really like the fact that the
> information model is built before the data model. Congratulations !
> 
> Please find below one blocking (but trivial to fix) DISCUSS point, some
> non-blocking COMMENT points (but replies would be appreciated), and one nit.
> 
> Thank you to Donald Eastlake for his shepherd's write-up (including the WG
> consensus).
> 
> I hope that this helps to improve the document,
> 
> Regards,
> 
> -éric
> 
> == DISCUSS ==
> 
> The YANG module does not compile correctly with PYANG, it should be easy to fix
> though :-) See: https://yangcatalog.org/results/ietf-babel@2021-05-12_ietf.html
> Or is it a PYANG error ?

This is a tooling error (even though I have gone ahead and changed it in the model). The ABNF grammar says the following for identity-stmt in RFC 7950.

   identity-stmt       = identity-keyword sep identifier-arg-str optsep
                         (";" /
                          "{" stmtsep
                              ;; these stmts can appear in any order
                              *if-feature-stmt
                              *base-stmt
                              [status-stmt]
                              [description-stmt]
                              [reference-stmt]
                          "}") stmtsep

According to it, the ‘if-feature’ and ‘base-stmt’ can appear in any order. But for some reason pyang version 2.4.0 insists on a particular order. I will bring this up with tooling folks.

> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> == COMMENTS ==
> 
> The related links on should be updated. E.g., the YANG catalog entry should be:
> https://www.yangcatalog.org/yang-search/module_details.php?module=ietf-babel@2021-05-12
> 
> -- Section 2.2 --
> I usually use the expanded tree view rather the YANG module itself to get a
> global view. Is there any reason why the full tree view is not included?

Added this to the Appendix.

> 
> -- Section 5 --
> Is there any reason why the doc shepherd is not acknowledged ?
> 
> == NITS ==
> 
> -- Section 2.3 --
> s/MAC based security/MAC-based security/ ?

Fixed.

Thanks.

Mahesh Jethanandani
[e-mail]