Re: [babel] Minor format problem in draft-ietf-babel-yang-model-04

Mahesh Jethanandani <mjethanandani@gmail.com> Fri, 03 January 2020 21:21 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C2542120045 for <babel@ietfa.amsl.com>; Fri, 3 Jan 2020 13:21:47 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.998
X-Spam-Level:
X-Spam-Status: No, score=-0.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xP35ivACcLAF for <babel@ietfa.amsl.com>; Fri, 3 Jan 2020 13:21:46 -0800 (PST)
Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4F706120026 for <babel@ietf.org>; Fri, 3 Jan 2020 13:21:46 -0800 (PST)
Received: by mail-pj1-x102b.google.com with SMTP id bg7so5172702pjb.5 for <babel@ietf.org>; Fri, 03 Jan 2020 13:21:46 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=NL+mQogA4YGF7S5nXkZjrDX0YUmQZwvMC11Zi+/E+7M=; b=HkNctMqjsQUckUzV+0I8j3lWlDfVz8g1IDhagxUuqJbXzxmcRf4fTmm/gLhOJjoD4q Kjhb/uY+tQA0kMUFvfNgfH1C9S5rpjJEW1U7QWywiOE44pjcv5jJey8yw4/zENKckLL4 aB/WUONyDV/UngA1br8RJclcUFZa2iUumwRULbg9PCXX1iOpxr01CcEmrRGLCHoe0T2P bqFMuYk1a2IOkn5H6dPf2NKeNM267evX0IPdLBfhIewd0mNwRBopzH4V2VAb6YPj6PrT fmvp5icUvlCm+OLknDFlwZ2/zgoIi0h/rZuJZmQRlKs6pMqzpXfAZLRrlwcJueDFwzYl 9iZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=NL+mQogA4YGF7S5nXkZjrDX0YUmQZwvMC11Zi+/E+7M=; b=rBnmGg4Ij75PIUBMPBb/7paHIxVQmDbtHh0Hfbj+ZNPp7T1Q/B5QdbF3O6cGqgTPaj fDeRoPlFr2YA8yGIooe3Hu7toclFB3WXT0ltDOygyK+YTFWYb4qyzxrRffLe54YvrX54 p/ZHaYBIUnTuMpH1a3J5FCHhHK7SiwTofI9Zypu1ku8bdKC1VDzL7F3wYM1dIjzvdCoT ly/AJ3OPe70gveRLjsnaFm1LgdOwCt8ios1ccawb7Zi6fM3kMl4uDeI/WjD6ifj2d0F2 7Izfk4ZiA/bg0mRDOtWiep+Jqd2I2elGsSlJG/39UX2gXU5yHADyzucSQGeoSvOhh4lm /3hA==
X-Gm-Message-State: APjAAAUq2m5s7xCxpmoQKg9Z9a+gvY8DfD7w9HCqAMONdTTbnblfniDQ j6ffHoNmtyPqkp/otmsRQRk=
X-Google-Smtp-Source: APXvYqzVd0RZnZ8tEgpY0TgHpXDY0jwR1jgIfpHHp0nmU4JdAUJrgsT+Zuhh8K7o2RHiecqovwdlhQ==
X-Received: by 2002:a17:902:32b:: with SMTP id 40mr37860539pld.22.1578086505728; Fri, 03 Jan 2020 13:21:45 -0800 (PST)
Received: from [192.168.1.122] (c-73-93-49-153.hsd1.ca.comcast.net. [73.93.49.153]) by smtp.gmail.com with ESMTPSA id n188sm64936458pga.84.2020.01.03.13.21.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jan 2020 13:21:44 -0800 (PST)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <98799C32-6591-475E-B9F3-B6E31D828154@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_EA9B2188-0F28-4CFE-9DA9-5BE637A96067"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Date: Fri, 3 Jan 2020 13:21:43 -0800
In-Reply-To: <CAF4+nEGmi3nOBw+CrNdQpg8rQsu3GOdX2KG0tmzOw1Hi3VEgGg@mail.gmail.com>
Cc: Babel at IETF <babel@ietf.org>
To: Donald Eastlake <d3e3e3@gmail.com>
References: <CAF4+nEF2enPsrNk+RvDRBJiycpjKe17W50=OJV2XOK7rKdjgfA@mail.gmail.com> <CC940348-5659-4FF3-9ECD-BA67043EB02B@gmail.com> <CAF4+nEGmi3nOBw+CrNdQpg8rQsu3GOdX2KG0tmzOw1Hi3VEgGg@mail.gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/gEXbzCpxuvODz7Ywgj2Ujy4UCJk>
Subject: Re: [babel] Minor format problem in draft-ietf-babel-yang-model-04
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Jan 2020 21:21:48 -0000

Hi Donald,

In trying to make the changes you requested, I came across another change that needs to be pushed.

The information model suggests that babel-information-obj should maintain a list of metric-comp-algorithm that are supported by an implementation. The problem with just keeping a list in YANG is that there is no way to enforce that the implementation uses only those algorithms. To address the issue we had introduced the concept of features in -04 version of the draft.

Using the feature statement, the implementation can declare which of the metric-comp-algorithms it supports, which was the intention of having a list of those algorithms in the first place. As such, we do not need the global list anymore, and needs to be removed. I will be adding that change in the -05 version of the draft.

If you feel that it requires a short LC to be issued, please feel free to do so after I post the draft.

Thanks.

> On Jan 3, 2020, at 10:32 AM, Donald Eastlake <d3e3e3@gmail.com>; wrote:
> 
> Hi Mahesh,
> 
> You're welcome. My apologies for not noticing it earlier. Can you go ahead and post a revision with this trivial change?
> 
> Thanks,
> Donald
> ===============================
>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>  2386 Panoramic Circle, Apopka, FL 32703 USA
>  d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>
> 
> On Fri, Jan 3, 2020 at 2:21 AM Mahesh Jethanandani <mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>> wrote:
> Hi Donald,
> 
> Yes, that should be ok. And thanks for catching it.
> 
> Cheers.
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
> 
> On Jan 2, 2020, at 8:27 PM, Donald Eastlake <d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>> wrote:
> 
>> Hi Mahesh,
>> 
>> Happy New Year!
>> 
>> There seems to be a minor format problem in this draft, in particular four lines, all identical, that are 76 characters long. Lines over 72 characters are not allowed in Internet Drafts.
>> 
>> On page 34, page 35, page 36, and page 38 the following line occurs:
>>             xmlns:babel="urn:ietf:params:xml:ns:yang:ietf-babel">babel:babel
>> Is it possible to fold this into something like
>>             xmlns:babel=
>>                 "urn:ietf:params:xml:ns:yang:ietf-babel">babel:babel
>> or just reduce the indent of those lines?
>> 
>> Thanks,
>> Donald
>> ===============================
>>  Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
>>  2386 Panoramic Circle, Apopka, FL 32703 USA
>>  d3e3e3@gmail.com <mailto:d3e3e3@gmail.com>
Mahesh Jethanandani
mjethanandani@gmail.com