Re: [babel] Éric Vyncke's Discuss on draft-ietf-babel-yang-model-10: (with DISCUSS and COMMENT)

Martin Vigoureux <martin.vigoureux@nokia.com> Wed, 02 June 2021 20:04 UTC

Return-Path: <martin.vigoureux@nokia.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C42073A1920; Wed, 2 Jun 2021 13:04:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, MSGID_FROM_MTA_HEADER=0.001, NICE_REPLY_A=-0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3B8ZCGVvAfhZ; Wed, 2 Jun 2021 13:04:26 -0700 (PDT)
Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130103.outbound.protection.outlook.com [40.107.13.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9FF1D3A191E; Wed, 2 Jun 2021 13:04:25 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HtYFy9QqsL8JVLwUSv6b6DwQx2T/BGFVMvjzpd6Jrpynw88sPGekh51s4ZwFDLQdKpN/qlhTOLdyxUWn5ZkDtUCE+LVdkfuQ3NLhpsLR/2RuCmt63wGyyBb1S2NLu+DMHzRMIxnkSqhmS+gatO61C+tp23dcuvPHYjtGcDygNFsyujM6pEhMcYzmOmseH9/Jy4+oF6i8IYL8yEV+fKNhIibqF8VtflFGWhRLyejiWAlaGkNZp6LRR+sRQoSqEzGUOHmbZQc11bxrlnxH/CkFGpRBIDYXTHwhN1c7eviMnBbkLi+H8Fj3/4Yp9ncZFe+Da71aLN+Ris+nC7ndPicmHQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86i0lWKzzYoFnE11yIXW+vvVZN4gwzfCMv2my0xcqsI=; b=nLhjcyqlRxgfc2Poltl7+i017jRGEjhNR3ekSwdOl+4AIrF+L6/f3Go10KVx7Zr+LQifwPBn/aRa9emqV7+D9qB3Dn2k3WFjtHFU9M4yEA1O2cINrIgRakatGuXSGBUka7HVJj3oBk+rBgL4rTKzHzj2yiKZN8Tv1n1jFirT2btUTzIhUCrfIJ5fIwASzsLt3h4uLoZ7MKZsfH7vx4JfjatD36JM3H8AItu3Ax5osPpdAgoU3liYNlhkPWyeFj7/Mr/apqpYn4RcdXVAuMXtk4/a3MPnOKSYNmJDFUnlgPn2acMNd0QM8+F29G3W0IOs6+FA1wyz3fO3qdhyewaTaw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86i0lWKzzYoFnE11yIXW+vvVZN4gwzfCMv2my0xcqsI=; b=w6g2my2251/tyzowRngCozBKxc4gli+UmbY6wv7LStJ9W7fr9PXCdNzgGt4+/sLpeJ5NEgrY/Wc21WHYAayjLH3SQ4mQW/lWxvettt7tiz+1maUiV+KhILFt1t6L1HPzlKwSZxxYZtTlQnd4YlSx8qST+QMyDrDhdX149hsA2Jc=
Authentication-Results: cisco.com; dkim=none (message not signed) header.d=none;cisco.com; dmarc=none action=none header.from=nokia.com;
Received: from AM6PR07MB5560.eurprd07.prod.outlook.com (2603:10a6:20b:6f::22) by AM6PR07MB3975.eurprd07.prod.outlook.com (2603:10a6:209:33::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.14; Wed, 2 Jun 2021 20:04:22 +0000
Received: from AM6PR07MB5560.eurprd07.prod.outlook.com ([fe80::79ba:ddfb:6bf3:9a66]) by AM6PR07MB5560.eurprd07.prod.outlook.com ([fe80::79ba:ddfb:6bf3:9a66%5]) with mapi id 15.20.4195.019; Wed, 2 Jun 2021 20:04:22 +0000
To: Mahesh Jethanandani <mjethanandani@gmail.com>, =?UTF-8?Q?Martin_Bj=c3=b6rklund?= <mbj+ietf@4668.se>
Cc: babel-chairs <babel-chairs@ietf.org>, Babel at IETF <babel@ietf.org>, draft-ietf-babel-yang-model@ietf.org, The IESG <iesg@ietf.org>, Donald Eastlake <d3e3e3@gmail.com>, =?UTF-8?Q?=c3=89ric_Vyncke?= <evyncke@cisco.com>
References: <162124475990.8618.15255310968103028424@ietfa.amsl.com> <39A68691-1C3F-4EF8-8621-D2FC5707B5AA@gmail.com> <20210519.084054.1713468977677987317.id@4668.se> <A5BAF28D-8856-482A-AA5E-F41ED3BA9BD2@gmail.com>
From: Martin Vigoureux <martin.vigoureux@nokia.com>
Message-ID: <b9b31f02-31fd-a75c-4892-649c0bd68695@nokia.com>
Date: Wed, 2 Jun 2021 22:04:01 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0
In-Reply-To: <A5BAF28D-8856-482A-AA5E-F41ED3BA9BD2@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
X-Originating-IP: [131.228.2.21]
X-ClientProxiedBy: CH0PR07CA0017.namprd07.prod.outlook.com (2603:10b6:610:32::22) To AM6PR07MB5560.eurprd07.prod.outlook.com (2603:10a6:20b:6f::22)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [172.30.2.231] (131.228.2.21) by CH0PR07CA0017.namprd07.prod.outlook.com (2603:10b6:610:32::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.15 via Frontend Transport; Wed, 2 Jun 2021 20:04:17 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 936ffe00-2ff1-457f-0d1b-08d926019d46
X-MS-TrafficTypeDiagnostic: AM6PR07MB3975:
X-Microsoft-Antispam-PRVS: <AM6PR07MB39758A8B238D322D3BFB38F68C3D9@AM6PR07MB3975.eurprd07.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1vxS0jo8SJAdfoRcXxWJaHEWUQYdOslmLjeMgED2A20g0UeMVEOxiYDi4W0uBhzJkkqiMRC2u7xQxqJr0ypZQMir3+dIMFtVi4Mb0oPRXPb+tXBvdHRE4/VfGZRBquBpDUpilZa9Th9QlfGcH96YhhpK4TcqasJ6mAVJiXg7wKROE2USJqVXlqPFomh1y3gnxDcTAwqumO4GIbWpBXBIEmrrhY1k1QbLLcVwaOWyY6pL8MIVexforTICg0r8ri9ZFgS63B9NBGwCyKj+uLXAWwANUSDsazcjfAT5skPfCY4lEWbm5PTuPdpJEk0uneN8+jOMz0oQ5nsN7i4VjW3ct2vbtuU88J7As4bDcDkwk2lICHstOC8O91WnA1P7ubp9Qpon2MNGzOC7SQlVsoxOygqy5meUHlVrTcde2700RFDf4yfF4meSAfFLCJN7jpAjeqY5jGP93uhXNMg4D8uo4xh93Rq2H4TXIdxpPML63hpm/EsEc5ftLejAUhkVGIWrA7QOCQjGS7bfywBki3+Luqm5U7GPyYNHi6LbF1QEAKQ5YhVoVdQOInQix8e5Wwcfjlync5a3IUdSxkP3NzMWT5ihn7znA514eFUyZ0JEvmqrtH66TLNifNXY1mJoO/Pe9h845puyKTWtkVqVkDWAI9UAj0mv7io8cIrFgOD7MGpal1QvbxhxBF7fHhpz1Uxkgcb5W0e/1FL+xvq4/200PQoONLPr908pCgYWWicbGO/2o/w5GLd5iJVLz7a30GWszOkVMNekQjIS8hHBmCNCWTzcMVKhnm25wICrKjl6Q+M3KqLChbzFO5WKCHHNNeg04rMf81+HwG34LMgkVEqXKQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM6PR07MB5560.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(376002)(396003)(39860400002)(110136005)(54906003)(31696002)(956004)(966005)(16799955002)(2616005)(26005)(478600001)(6486002)(66946007)(16526019)(36756003)(316002)(224303003)(52116002)(44832011)(83380400001)(8936002)(4326008)(66556008)(186003)(86362001)(38350700002)(31686004)(16576012)(66476007)(2906002)(38100700002)(5660300002)(66574015)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OVlTR3ZuOGxPY2x2Nko4Qy9BZ1ZRbzUzT0RTcVhndUo3QnBhN05hR285Vkox?= =?utf-8?B?T3pMMlF2anFjbE0rSHRTUGRqUHQzMlBTOHQveHg1SnJGcURqTHdpcHU3N2xU?= =?utf-8?B?ZFJtWHgwYkZSdkR2Qk0rY2ZCb2lCSFR5UExkc09TMlgxVjZZbDRzS1pnWk1z?= =?utf-8?B?bmxwdmNmbE0yV1FRcVZJZGFlckoxdGJNVEZIRXR6QkRGSCt2TDBCRWQ4Q2NZ?= =?utf-8?B?YzBiSlJxLzh2RVlWRVE0bzMzb1JGTlVmbUVpM1kwUkN0SjdISlFDRUx1d1Rh?= =?utf-8?B?dUJDazUvSFF4SEdnTnpmNW80bWpkbGdKQVorUWRyZFF3UXlkM0g0RWZZbHFl?= =?utf-8?B?UEVoMHRVblM0SW5rK3ZDRnNkSlNQM2dwM3owK1JNZVNSMENxWUZVa0RSWVBU?= =?utf-8?B?Mm9TTTRIS2NFaXJhb0swaG5MVlA1bWNtZWwvK2dmdU9oSyt4Qm5aOWR5U3NY?= =?utf-8?B?UDc3UkRwOTUzR1dsUERtOUZOTXpJZUQ5Qnh0S29IdTRoWVZGa3J6ZXJpRGg1?= =?utf-8?B?bnlUb1Q2c3VKMjE5R3Q0NHJsdTBkbGtQaDFWRnhwVDZUS2JBTitnWjIyMzBP?= =?utf-8?B?anpJbE9JUHdlUlR0TWZYbW5TdzU0Y0E3alRUejJabmNacUtzM2RzYmFHVDVn?= =?utf-8?B?S09mOEQ5ZWJtcnByamdaQU5LcC96aEI3cVNSWll3ekpRd0I3RnJjNHU0Z3FQ?= =?utf-8?B?TjF4RWJqV0k4czYzbnZDSDVkai9ySmUydVlDWDFUeEd5UDZkWmVvTk5uWVZI?= =?utf-8?B?bE1ncjg0RDJ1NVYvSnFoZTd6RTRpRU9iUjFMRjNPWmx6SWhWRFVqQzJ3a3RK?= =?utf-8?B?QzRMMlNqa290ek8vQzBCNUwvZXRJblZHaklJTnAzWkVJMCtxN1FaN3V5L2hm?= =?utf-8?B?YnlrMW1KQU9UUXhxVm9STkFYU0MzWUNaamdLcE1aZXhFNU4wOWlRWmF2Q2s0?= =?utf-8?B?TktCckVxOGJsOHU0RGcyV2thQ3hPWkFRSWQrS3loUkt5QVREcGhQc1d5UEFt?= =?utf-8?B?Wnd0bTBaRmMwN1ZmUTlUN09ZZktSRmVwQmZMRWI1K2Q5bW51YmtucUovMHBi?= =?utf-8?B?TkorcTI3Q1g3bkZ4U0pXZXhYQ1dIUDJFVFZ3KytlZHoyZGpZd0UxQWlidmcw?= =?utf-8?B?S2xJRHdNNDF6MnE4Qkt3amc2c3VyeG5OdVc1YkZ0NWFSalNrZzRZS3JxR0Y4?= =?utf-8?B?eWNvaTFjMlBocnhjYWZOSEZ5Sk9mMGlhelhZR0tpQmxOMnJWeTRRR0Y2U2lT?= =?utf-8?B?S1B2djUrVlVWWVN3ZmtyNi80VnNldnZpbEFTdDVRbk5aM3FxSDlNeDEzWmNs?= =?utf-8?B?dXZWTk10V1NqWnZHODAxSk5UdFp6TGFXbkFuT0R5c202enNBQ01RMk9FQ3dI?= =?utf-8?B?UjBOYlNZSlR2UEJabjQ1dXhUc3cxbG1KSVB4aHIrenBpMDMyK04vU1ZuVDda?= =?utf-8?B?eGw5eXNVNVNMa2ZGakhDcU13QVZHaFB4QXZPeEI4T2E3elBBbHJaeW9uNXJ2?= =?utf-8?B?ai9EeHVtMWZiS0lha0YveDM1ZThpVWZVWHdLQjFHUUI4cVZnN2paQnI0dkph?= =?utf-8?B?WUhWL0hmMFQzTXQ4RVNpbDdtQnlDQjJwalRVQ084dWFJblREU2FsUS8xZTA2?= =?utf-8?B?NStMTjNMRUJuNU5KQzlSbE4zQ1hhQW1xMWUzT3UycVNFbThYYTJybTNTUWgx?= =?utf-8?B?aGllc3pERFh4QU5NbmhsTTZLR1ZOM3hYMEJxMW9hVEhCbnF4em1oaVNmL2tQ?= =?utf-8?Q?NOwEl7USfcAb71i8V92Mhv5YPtiOc3OTBWnwemW?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 936ffe00-2ff1-457f-0d1b-08d926019d46
X-MS-Exchange-CrossTenant-AuthSource: AM6PR07MB5560.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2021 20:04:22.6091 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: S6+A/5nz5Gh1y3we/XLP1RaLglsppNVYQU+tLHUaiv/WmxcVEI+2L9qaHD0c7hHSHvcJb9tELmXQ1B8JuNY/7Hh1woj7zbh/YO02sUNuQRk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB3975
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/iEUneTABc2_Z4K74xIE2MNbmOlQ>
Subject: Re: [babel] =?utf-8?q?=C3=89ric_Vyncke=27s_Discuss_on_draft-ietf-bab?= =?utf-8?q?el-yang-model-10=3A_=28with_DISCUSS_and_COMMENT=29?=
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Jun 2021 20:04:31 -0000

Martin, Mahesh,

so what is the conclusion on that?

Thank you
-m

Le 2021-05-19 à 17:18, Mahesh Jethanandani a écrit :
> Hi Martin,
> 
>> On May 18, 2021, at 11:40 PM, Martin Björklund <mbj+ietf@4668.se 
>> <mailto:mbj+ietf@4668.se>> wrote:
>>
>> Hi,
>>
>>>>
>>>> The YANG module does not compile correctly with PYANG, it should be
>>>> easy to fix
>>>> though :-) See:
>>>> https://yangcatalog.org/results/ietf-babel@2021-05-12_ietf.html
>>>> Or is it a PYANG error ?
>>>
>>> This is a tooling error (even though I have gone ahead and changed it
>>> in the model). The ABNF grammar says the following for identity-stmt
>>> in RFC 7950.
>>>
>>>   identity-stmt       = identity-keyword sep identifier-arg-str optsep
>>>                         (";" /
>>>                          "{" stmtsep
>>>                              ;; these stmts can appear in any order
>>>                              *if-feature-stmt
>>>                              *base-stmt
>>>                              [status-stmt]
>>>                              [description-stmt]
>>>                              [reference-stmt]
>>>                          "}") stmtsep
>>>
>>> According to it, the ‘if-feature’ and ‘base-stmt’ can appear in any
>>> order. But for some reason pyang version 2.4.0 insists on a particular
>>> order. I will bring this up with tooling folks.
>>
>> This is not a tooling error.  The error message is:
>>
>> ietf-babel@2021-05-12.yang <mailto:ietf-babel@2021-05-12.yang>:148: 
>> error: keyword "if-feature" not in
>>    canonical order (see RFC 6020, Section 12)
>>
>> [side note: the RFC ref in this error message should be updated to RFC
>> 7950 Section 14]
>>
>> The referenced section says:
>>
>>   The ABNF grammar [RFC5234] [RFC7405] defines the canonical order.
>>
>> When we publish YANG models in RFCs we use the canonical order in
>> order to have a consistent format.  pyang checks this when the flag
>> --ietf is used.
> 
> I am trying to understand, and this is more for my education, what rule 
> within the grammar is determining the canonical order?
> 
> Also, should pyang report this as an error, or maybe a warning might be 
> better? After all, this is being done for consistency reasons.
> 
>>
>>
>> /martin
>>
>>
>>
>>>
>>>>
>>>>
>>>>
>>> ----------------------------------------------------------------------
>>>> COMMENT:
>>>>
>>> ----------------------------------------------------------------------
>>>>
>>>> == COMMENTS ==
>>>>
>>>> The related links on should be updated. E.g., the YANG catalog entry
>>>> should be:
>>>> https://www.yangcatalog.org/yang-search/module_details.php?module=ietf-babel@2021-05-12
>>>>
>>>> -- Section 2.2 --
>>>> I usually use the expanded tree view rather the YANG module itself to
>>>> get a
>>>> global view. Is there any reason why the full tree view is not
>>>> included?
>>>
>>> Added this to the Appendix.
>>>
>>>>
>>>> -- Section 5 --
>>>> Is there any reason why the doc shepherd is not acknowledged ?
>>>>
>>>> == NITS ==
>>>>
>>>> -- Section 2.3 --
>>>> s/MAC based security/MAC-based security/ ?
>>>
>>> Fixed.
>>>
>>> Thanks.
>>>
>>> Mahesh Jethanandani
>>> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
> 
> Mahesh Jethanandani
> mjethanandani@gmail.com <mailto:mjethanandani@gmail.com>
> 
> 
> 
> 
>