Re: [babel] [Last-Call] Genart last call review of draft-ietf-babel-yang-model-09

Lars Eggert <lars@eggert.org> Mon, 17 May 2021 08:49 UTC

Return-Path: <lars@eggert.org>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 133013A2F35; Mon, 17 May 2021 01:49:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.098
X-Spam-Level:
X-Spam-Status: No, score=-2.098 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pWfDpUD2E-8j; Mon, 17 May 2021 01:49:14 -0700 (PDT)
Received: from mail.eggert.org (mail.eggert.org [IPv6:2a00:ac00:4000:400:211:32ff:fe22:186f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E89A33A2F13; Mon, 17 May 2021 01:49:13 -0700 (PDT)
Received: from smtpclient.apple (unknown [212.68.24.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 49016600C7B; Mon, 17 May 2021 11:49:07 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1621241347; bh=fsi9U3GMGcaFxuMRaOJi4RlaX6LAoVTydz2HzwIlHvE=; h=From:Subject:Date:In-Reply-To:Cc:To:References; b=hZzHlmw2dIE18ex0Z4iRBm+YjllsAAxsynSnWj3WftlImngLYkmzGRhSIDqt66ykD 73cky37XGdgRh/tZdBnUNJ5nRIvV2fLV5qxLTBhkMk8QDl2Tjon9z3jDglUIG2Z4or BA1C0N18540/OdKaZ9/mXJ2UXRZFgRxepdwIRHhs=
From: Lars Eggert <lars@eggert.org>
Message-Id: <41E67DF8-41CF-44A3-AEA5-789F5D9BB432@eggert.org>
Content-Type: multipart/signed; boundary="Apple-Mail=_F0EDCB68-939B-4890-A2E3-F1A2987F0347"; protocol="application/pgp-signature"; micalg=pgp-sha512
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\))
Date: Mon, 17 May 2021 11:49:06 +0300
In-Reply-To: <162014997938.23614.6494865677211981729@ietfa.amsl.com>
Cc: General Area Review Team <gen-art@ietf.org>, last-call@ietf.org, draft-ietf-babel-yang-model.all@ietf.org, babel@ietf.org
To: Stewart Bryant <stewart.bryant@gmail.com>
References: <162014997938.23614.6494865677211981729@ietfa.amsl.com>
X-MailScanner-ID: 49016600C7B.AFC02
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/lvzrXcRiZtOuk9eLITp4U7X46ag>
Subject: Re: [babel] [Last-Call] Genart last call review of draft-ietf-babel-yang-model-09
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 May 2021 08:49:27 -0000

Stewart, thank you for your review. I have entered a No Objection ballot for this document.

Lars


> On 2021-5-4, at 20:39, Stewart Bryant via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Stewart Bryant
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-babel-yang-model-09
> Reviewer: Stewart Bryant
> Review Date: 2021-05-04
> IETF LC End Date: 2021-04-22
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: A well written text that is ready for publication. Just one note and a
> couple of minor nits.
> 
> Major issues: None
> 
> Minor issues:
> 
> 5.  Acknowledgements
> Juliusz Chroboczek provided most of the example configurations for babel that
> are shown in the Appendix.
> 
> The Appendix seems seems quite substantive, I am surprised that Juliusz was not
> listed as an author.
> 
> Nits/editorial comments:
> 2.1.  Information Model
> 
> " attributes are marked a read-only objects in the information module"
> SB> s/marked a/marked as/
> 
> 2.3.  YANG Module
> "On other hand, for a"
> 
> SB> s/On other hand/On the other hand/
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call