Re: [babel] Shepherd Review of draft-ietf-babel-source-specific-04

Juliusz Chroboczek <jch@irif.fr> Thu, 11 April 2019 15:30 UTC

Return-Path: <jch@irif.fr>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 512811200F5; Thu, 11 Apr 2019 08:30:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id be4XtIV6oZ-2; Thu, 11 Apr 2019 08:30:12 -0700 (PDT)
Received: from korolev.univ-paris7.fr (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 681B5120098; Thu, 11 Apr 2019 08:30:12 -0700 (PDT)
Received: from potemkin.univ-paris7.fr (potemkin.univ-paris7.fr [IPv6:2001:660:3301:8000::1:1]) by korolev.univ-paris7.fr (8.14.4/8.14.4/relay1/82085) with ESMTP id x3BFU6WM013816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 11 Apr 2019 17:30:06 +0200
Received: from mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [81.194.30.253]) by potemkin.univ-paris7.fr (8.14.4/8.14.4/relay2/82085) with ESMTP id x3BFU7re026887; Thu, 11 Apr 2019 17:30:07 +0200
Received: from mailhub.math.univ-paris-diderot.fr (localhost [127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTP id 5A76A7A378; Thu, 11 Apr 2019 17:30:10 +0200 (CEST)
X-Virus-Scanned: amavisd-new at math.univ-paris-diderot.fr
Received: from mailhub.math.univ-paris-diderot.fr ([127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id or3Sy3d4iYuy; Thu, 11 Apr 2019 17:30:09 +0200 (CEST)
Received: from lanthane.irif.fr (unknown [172.23.36.89]) (Authenticated sender: jch) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTPSA id 1E7757A373; Thu, 11 Apr 2019 17:30:09 +0200 (CEST)
Date: Thu, 11 Apr 2019 17:30:09 +0200
Message-ID: <87ef68h85a.wl-jch@irif.fr>
From: Juliusz Chroboczek <jch@irif.fr>
To: Donald Eastlake <d3e3e3@gmail.com>
Cc: Babel at IETF <babel@ietf.org>, babel-chairs <babel-chairs@ietf.org>
In-Reply-To: <CAF4+nEEfEvg_ktoudURqvCPshrA8SzL+TMGjQm6vUOFX65q==A@mail.gmail.com>
References: <CAF4+nEEfEvg_ktoudURqvCPshrA8SzL+TMGjQm6vUOFX65q==A@mail.gmail.com>
User-Agent: Wanderlust/2.15.9
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]); Thu, 11 Apr 2019 17:30:06 +0200 (CEST)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (potemkin.univ-paris7.fr [194.254.61.141]); Thu, 11 Apr 2019 17:30:07 +0200 (CEST)
X-Miltered: at korolev with ID 5CAF5D7E.001 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-Miltered: at potemkin with ID 5CAF5D7F.001 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Enveloppe: 5CAF5D7E.001 from potemkin.univ-paris7.fr/potemkin.univ-paris7.fr/null/potemkin.univ-paris7.fr/<jch@irif.fr>
X-j-chkmail-Enveloppe: 5CAF5D7F.001 from mailhub.math.univ-paris-diderot.fr/mailhub.math.univ-paris-diderot.fr/null/mailhub.math.univ-paris-diderot.fr/<jch@irif.fr>
X-j-chkmail-Score: MSGID : 5CAF5D7E.001 on korolev.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Score: MSGID : 5CAF5D7F.001 on potemkin.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Status: Ham
X-j-chkmail-Status: Ham
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/mrY1SBi7RHQ3Uhlm5eRf4Fkf4WE>
Subject: Re: [babel] Shepherd Review of draft-ietf-babel-source-specific-04
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2019 15:30:15 -0000

> Section 6, page 7, first parenthetical:
>    I think instead of "and all of its extensions" it should say something a bit
> more limited. How about "and all previously standardized extensions"?

Done.

> Section 7, page 8, 2nd paragraph:
>    Generally, cases where different routers can interpret routing protocol
> messages differently make me very nervous. It is almost always possible to
> construct a situation where this causes persistent looping. It seems to me that
> you need to unambiguously specify what is done if there is a malformed TLV with
> multiple Source Prefix sub-TLVs. Such TLVs could always be ignored or the first
> or the last Source Prefix sut-TLV could be the effective sub-TLV with other
> Source Prefix sub-TLVs ignored. But whatever is specified, it needs to be
> mandatory unambiguous behavior.

Done.

> Section 7.1, Page 9:
>    What do you do when you get a malformed Source Prefix sub-TLV with a zero
> Source Plen?

Done.  This leads to some repetition (the case of wildcard requests and
retractions was already specified in Section 5.2), but what the hell.

> Typos:

Done.

> Minor textural comments:
> ===================
>    These are just minor cases where I think the draft would read slightly
> better with a wording change.

Done.

Thanks for your help,

-- Juliusz