Re: [babel] Yangdoctors last call review of draft-ietf-babel-yang-model-09

Mahesh Jethanandani <mjethanandani@gmail.com> Thu, 06 May 2021 22:08 UTC

Return-Path: <mjethanandani@gmail.com>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 638933A0AE4; Thu, 6 May 2021 15:08:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SgI2PqOSkcDg; Thu, 6 May 2021 15:08:05 -0700 (PDT)
Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 48CE03A0AE7; Thu, 6 May 2021 15:08:02 -0700 (PDT)
Received: by mail-pl1-x62b.google.com with SMTP id s20so4113825plr.13; Thu, 06 May 2021 15:08:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=+pM2KCSMevZOJ1KVlad9/5h9yvE0E12zWcHCX2j64I8=; b=k30sUFNXJ72wdhka+Coi+vj9dr9O6DxoAN7jwMoBonPA3Prn7jF1y4eRQw391ZAcWw 5RYbRgrqzgL4nf/vVsDKdGd5mhWSrfZ2+zTlQzCCKzTKyZsIEb+188VMntJ+aNF9qbBS HRqC9M+1bWA4JLOywh1u/SkTxw42di0hqN1Gqx3NHHFm4kJnrT4IkayFuCzKS0aQez7n QJrFB98Q1cRMb2oJMJBJfBOc1McKWEUeqGYrpUYJRKswvsbdakeOPvqZJfQ4wpmlIimm Fojc2DmlEQk5c7p2/HyCAGmcZaik5I0i7Xwedw27UNN8tHPZl2ljn18sskr9ku1R6IJr cuJw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=+pM2KCSMevZOJ1KVlad9/5h9yvE0E12zWcHCX2j64I8=; b=OT4lLgbTSco3qo3zKg046FFMgYMk30cvo6qmCT8KAoHM/BgDC5PzSbwGzQu3cqu2Ey CJOmkThrZ5jk7vqefRcqIEwx7h/CXO73qaHpebfy7F/y0tOa/nC6Uw3DczgvPOxPg0nb fKeKc5EQSw0YDLMXgXTyXthfcKQ8vrERCqn2CmVRfRdZDJbTj386vv8+urEjV61ftZAA U5HdyaHt1nj9ng5+8P9Wr/b8snRQH7GvrEJBzgl+13iqOxqEJ2hmGPutpXAC20U2L7Lm jteJ9xCWzIMJwuhDLqGDTandVcEvdlpWXHShVEovLrEZzqa+Au6ZM2AW68fHk0hlSbM+ 1FRg==
X-Gm-Message-State: AOAM531oAwkuGWNBgmmxYvS/se9INCBVoyNbbDtcDseTZOlt1m4TCj91 +0I2ghwItphSV7+aW0NZIfE=
X-Google-Smtp-Source: ABdhPJyAnxIK+fp/MaN3ui2KIB2AXPllRIK7XvlxQjRLDVuq4PxoDtzwyEk0a0u8PIlFQGOHFGTf8A==
X-Received: by 2002:a17:90a:cb0e:: with SMTP id z14mr20480056pjt.128.1620338881371; Thu, 06 May 2021 15:08:01 -0700 (PDT)
Received: from ?IPv6:2601:647:5600:5020:5982:1aa9:1959:d934? ([2601:647:5600:5020:5982:1aa9:1959:d934]) by smtp.gmail.com with ESMTPSA id cm22sm2680766pjb.32.2021.05.06.15.08.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 May 2021 15:08:00 -0700 (PDT)
From: Mahesh Jethanandani <mjethanandani@gmail.com>
Message-Id: <9784697B-E02F-4034-9515-3CB5F3A59426@gmail.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_7BDE8DA2-EC5C-452A-AFBE-324A85C0CF30"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Thu, 6 May 2021 15:07:59 -0700
In-Reply-To: <161990098603.26817.6467081462726716234@ietfa.amsl.com>
Cc: yang-doctors@ietf.org, babel@ietf.org, draft-ietf-babel-yang-model.all@ietf.org, last-call@ietf.org
To: =?utf-8?B?UmFkZWsgS3JlasSNw60=?= <radek.krejci@gmail.com>
References: <161990098603.26817.6467081462726716234@ietfa.amsl.com>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/oetDnwoe7icP9FuX3Yem1OlR4rc>
Subject: Re: [babel] Yangdoctors last call review of draft-ietf-babel-yang-model-09
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 06 May 2021 22:08:12 -0000

Hi Radek,

Thanks for reviewing the YANG model. See comments inline.

> On May 1, 2021, at 1:29 PM, Radek Krejčí via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Radek Krejčí
> Review result: Ready with Nits
> 
> This is my YANG doctor review of draft-ietf-babel-yang-model containing
> ietf-babel@2021-03-12.yang module. The draft and the module are well written
> and I have just two minor comments:
> 
> - The copyright year in the YANG module should be probably 2021, not 2020.

Fixed.

> 
> - Some values of the specific statements (e.g. min-elements) are quoted despite
> it is not necessary (the value must be a number or a single word). I propose to
> use pyang/yanglint to generate the module since it also unifies all the
> formatting and quoting.

Ok. I ran pyang on the module to addresses statements that should be quoted or not, and fixed all of them. 

p.s. While I was at it, I also fixed the prefix issue as it relates to import of ietf-yang-types that Tom Petch brought up.

Cheers.

> 
> 

Mahesh Jethanandani
mjethanandani@gmail.com