Re: [babel] WG adoption call for draft-do-babel-hmac (7/19 - 8/6)

Markus Stenberg <markus.stenberg@iki.fi> Sat, 28 July 2018 22:35 UTC

Return-Path: <fingon@kapsi.fi>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 54FD9131152 for <babel@ietfa.amsl.com>; Sat, 28 Jul 2018 15:35:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.351
X-Spam-Level:
X-Spam-Status: No, score=-2.351 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=kapsi.fi
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iE1x6DuyhY5v for <babel@ietfa.amsl.com>; Sat, 28 Jul 2018 15:35:20 -0700 (PDT)
Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B8075130DD8 for <babel@ietf.org>; Sat, 28 Jul 2018 15:35:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=To:References:Message-Id:Content-Transfer-Encoding:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Content-Type:Sender:Reply-To:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=KVEOCpBrYyx+gLNen1fCuihQeLxRvUq42lPcx07s084=; b=zn+OldQawdOXO5vVqtgD1kO0R5 NSnpNPyZD2NjibWUeMA+rPoFu+G73+mtDdWNtY1YntOZM5j4s0Othe1fCOIbX/VyiquLPyqS68p9L k8FJSgqhff2zsRamrBgt2rBOmdodoxOg9alxhNVgUk+bZxzXKAe0Z9lrgvVK0N1U7+TmhZJH7FB4I hYyd8LclGCy89L1Zu2i195nOVHryDmvqTqSgyqvM7DA1p8kL8kRv/eTqENUdfpQUSMgMZs1Ar7k6N DzRKirL14wHM8mH66/14FNf/nUgJuMO+xaatmwRvKCv3ObGCaUL564x+ywivNg81qRtUCH/Qv4+9E VG0KCMPA==;
Received: from 91-155-69-202.elisa-laajakaista.fi ([91.155.69.202] helo=poro.lan) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from <markus.stenberg@iki.fi>) id 1fjXnz-0003Dq-4X; Sun, 29 Jul 2018 01:35:19 +0300
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Markus Stenberg <markus.stenberg@iki.fi>
In-Reply-To: <CAF4+nEEubyH7dHmPpdO3P-G-ma3GtVynpGm6=iy_44Ef5wCM_w@mail.gmail.com>
Date: Sun, 29 Jul 2018 01:35:18 +0300
Cc: Babel at IETF <babel@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C94064CD-72E9-4D16-AFFE-9F744D5AD409@iki.fi>
References: <CAF4+nEEubyH7dHmPpdO3P-G-ma3GtVynpGm6=iy_44Ef5wCM_w@mail.gmail.com>
To: Donald Eastlake <d3e3e3@gmail.com>
X-Mailer: Apple Mail (2.3445.9.1)
X-SA-Exim-Connect-IP: 91.155.69.202
X-SA-Exim-Mail-From: markus.stenberg@iki.fi
X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/pOVSFZINQJ5JW6AuQj4V2y593XI>
Subject: Re: [babel] WG adoption call for draft-do-babel-hmac (7/19 - 8/6)
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Jul 2018 22:35:23 -0000

I have read the draft and support adoption.

That said..nit or two :-)

   Whenever B resets its PC, or whenever B doesn't know whether
   its PC has been reset, it picks an index that it has never used
   before (either by drawing it randomly or by using a reliable hardware
   clock) and starts sending PCs with that index.

I think there are 3 potential sources for index:

- nvram/flash (truly unique, frequently but not always available)
- magic timestamp (e.g. GPS, magical secure NTP might give us ~unique timestamp, or RTC that never goes backward for this purpose.. but typical routers do not have strictly monotonic hardware clocks the text notes)
- something pseudorandom that has sufficiently low collision likelihood given the number of bits of index

so I think the text (and some of the following) is slightly optimistic. I would probably just settle for a sufficiently low collision chance.

Also, I would like to have byte(/few bits) somewhere indicating the algorithm used for HMAC. Maybe I’m just tired and can’t see one that is already there.

Cheers,

-Markus