IETF Logo Mail Archive

Re: [babel] Shepherd Review of draft-ietf-babel-source-specific-04

Juliusz Chroboczek <jch@irif.fr> Wed, 10 April 2019 10:42 UTC

Return-Path: <jch@irif.fr>
X-Original-To: babel@ietfa.amsl.com
Delivered-To: babel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 54BCC120291 for <babel@ietfa.amsl.com>; Wed, 10 Apr 2019 03:42:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0LQYO1qnz2zi for <babel@ietfa.amsl.com>; Wed, 10 Apr 2019 03:42:19 -0700 (PDT)
Received: from korolev.univ-paris7.fr (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EBE661201C7 for <babel@ietf.org>; Wed, 10 Apr 2019 03:42:18 -0700 (PDT)
Received: from potemkin.univ-paris7.fr (potemkin.univ-paris7.fr [IPv6:2001:660:3301:8000::1:1]) by korolev.univ-paris7.fr (8.14.4/8.14.4/relay1/82085) with ESMTP id x3AAgCeY016162 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 10 Apr 2019 12:42:12 +0200
Received: from mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [81.194.30.253]) by potemkin.univ-paris7.fr (8.14.4/8.14.4/relay2/82085) with ESMTP id x3AAgDPx021161; Wed, 10 Apr 2019 12:42:13 +0200
Received: from mailhub.math.univ-paris-diderot.fr (localhost [127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTP id 416906E2F7; Wed, 10 Apr 2019 12:42:16 +0200 (CEST)
X-Virus-Scanned: amavisd-new at math.univ-paris-diderot.fr
Received: from mailhub.math.univ-paris-diderot.fr ([127.0.0.1]) by mailhub.math.univ-paris-diderot.fr (mailhub.math.univ-paris-diderot.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id PMNZxQznYS8e; Wed, 10 Apr 2019 12:42:15 +0200 (CEST)
Received: from pirx.irif.fr (unknown [78.194.40.74]) (Authenticated sender: jch) by mailhub.math.univ-paris-diderot.fr (Postfix) with ESMTPSA id 568DE6E2E6; Wed, 10 Apr 2019 12:42:11 +0200 (CEST)
Date: Wed, 10 Apr 2019 12:42:11 +0200
Message-ID: <874l76xhto.wl-jch@irif.fr>
From: Juliusz Chroboczek <jch@irif.fr>
To: Toke Høiland-Jørgensen <toke@toke.dk>
Cc: Babel at IETF <babel@ietf.org>, Donald Eastlake <d3e3e3@gmail.com>
In-Reply-To: <CAF4+nEEfEvg_ktoudURqvCPshrA8SzL+TMGjQm6vUOFX65q==A@mail.gmail.com>
References: <CAF4+nEEfEvg_ktoudURqvCPshrA8SzL+TMGjQm6vUOFX65q==A@mail.gmail.com>
User-Agent: Wanderlust/2.15.9
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset="US-ASCII"
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (korolev.univ-paris7.fr [IPv6:2001:660:3301:8000::1:2]); Wed, 10 Apr 2019 12:42:12 +0200 (CEST)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (potemkin.univ-paris7.fr [194.254.61.141]); Wed, 10 Apr 2019 12:42:13 +0200 (CEST)
X-Miltered: at korolev with ID 5CADC884.001 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-Miltered: at potemkin with ID 5CADC885.001 by Joe's j-chkmail (http : // j-chkmail dot ensmp dot fr)!
X-j-chkmail-Enveloppe: 5CADC884.001 from potemkin.univ-paris7.fr/potemkin.univ-paris7.fr/null/potemkin.univ-paris7.fr/<jch@irif.fr>
X-j-chkmail-Enveloppe: 5CADC885.001 from mailhub.math.univ-paris-diderot.fr/mailhub.math.univ-paris-diderot.fr/null/mailhub.math.univ-paris-diderot.fr/<jch@irif.fr>
X-j-chkmail-Score: MSGID : 5CADC884.001 on korolev.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Score: MSGID : 5CADC885.001 on potemkin.univ-paris7.fr : j-chkmail score : . : R=. U=. O=. B=0.000 -> S=0.000
X-j-chkmail-Status: Ham
X-j-chkmail-Status: Ham
Archived-At: <https://mailarchive.ietf.org/arch/msg/babel/r2CTMFsZu12Qmc5a1ykjYMCZruI>
Subject: Re: [babel] Shepherd Review of draft-ietf-babel-source-specific-04
X-BeenThere: babel@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "A list for discussion of the Babel Routing Protocol." <babel.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/babel>, <mailto:babel-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/babel/>
List-Post: <mailto:babel@ietf.org>
List-Help: <mailto:babel-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/babel>, <mailto:babel-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2019 10:42:21 -0000

> It seems to me that you need to unambiguously specify what is done if
> there is a [...] TLV with multiple Source Prefix sub-TLVs. Such TLVs
> could always be ignored or the first or the last Source Prefix sut-TLV
> could be the effective sub-TLV with other Source Prefix sub-TLVs
> ignored. But whatever is specified, it needs to be mandatory unambiguous
> behavior.

[...]

> What do you do when you get a malformed Source Prefix sub-TLV with a zero
> Source Plen?

[...]

> Continuing the theme of some of the comments above, what do you do with
> a wildcard request that does contain a Source Prefix sub-TLV?

Toke, I could use some advice here.  Please have a look at your code and
let me know whether requiring (MUST) dropping the enclosing TLV in all of
these cases complicates your implementation or not.  (I'll do the same on
my side.)

Thanks,

-- Juliusz

v2.23.0 | Report a Bug | By Email