[bess] Document shepherd review of draft-ietf-bess-evpn-geneve-08
"Matthew Bocci (Nokia)" <matthew.bocci@nokia.com> Mon, 30 September 2024 12:03 UTC
Return-Path: <matthew.bocci@nokia.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 345C4C14F686; Mon, 30 Sep 2024 05:03:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.254
X-Spam-Level:
X-Spam-Status: No, score=-2.254 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.148, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=nokia.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x6k-ksDAwYcF; Mon, 30 Sep 2024 05:03:09 -0700 (PDT)
Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2081.outbound.protection.outlook.com [40.107.22.81]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 561A4C151094; Mon, 30 Sep 2024 05:03:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hh+EEyS4z1BMf4u7OPcasdmLfKkgfYq7qNedVdjvvEETW8RDxJhgD0kCS+dw7VDmHB5rRQiops125RsPEtAjjOxeUj3LgaycE1rhjSY2tNF8Rn2jsZdXThAa0sjULjF7UACRSh5Pj+WFou0sJdD8C5aFgBRMGZPYTISeWoZfnEnLjxs5iNItaQE2VyCoSm/r/NBTnvk3WvqrKozGHRTOwYJ3f/MUlgRtXtz0NrO4Qmsg5s6/7NmKQj7MLsC729kD6Gdy43f8xJXzR6sv6m3n9Dc0OS1rf/tBA6CqkS6GXBjEE9HeQkmFd2u9y6DEV86qWAM5d4QuS2gMWUQzIfqjoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jl2deCr8+NEhyo2+sZKSd9LpKAGp5DTpIOio4kXvozU=; b=RpdP3X3aGSYsxIbcfsZSXwHCQveECEbD1Z7mdfT4lgoAuROBKznUlZDSbQeTM5u210/anmd5QPllPAqxkBTegDXk1VG6Au9d078Z7MUjsBA6zg7azMits2XSSaWW+QmvWCPUyft4YJX8pfatwpSTW/io+AywLa/eEftx1xpb/UFhYIvfrLc60BGciJclZzKLBC842z3VmSk2TI09jTG3WxVHggmlhFYOxywyTk27CxByAH4jZqyXuH9LpAFX8HGbwl9caPaY29GJ9FUImn1fMBRrhFJl6x8cftA6P0fljmdeWNl6ekpOOrYSSwJ9DCTCHTjjlQm8xwZxRdqvPMOz2A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jl2deCr8+NEhyo2+sZKSd9LpKAGp5DTpIOio4kXvozU=; b=XOVjfqtEIL3/wsOy27sk80qDM7ACwpMBtyqHGtL6xZkDx9xunF0bBNl/fqlxivBC0gclv7fypCo/5dIW48t519nHvhoL+ozbwvn7xwGd0r4O8VMOaqrkDGfaxhvwXgZfUgfSTD0y2Qsq7EpgBQ48PqvhoGaUtz/G5R9KurKFW8x1+6H+JFkalZgosYZPsVDbWymHGw4y8NipnqecMrcHE40q7R+FsEJmegrfpLhsXog/WzWq27klkrabflop8LcEXHBA3GhRS7Px/KtkEtpQ6HgNvONXpO67qs9qxr5Kv9+X2vAeFSclnKdA/bVSQ99JKBxtELGKSpCbMTJJ9isvWQ==
Received: from VI1PR0702MB3567.eurprd07.prod.outlook.com (2603:10a6:803:c::10) by AM8PR07MB8230.eurprd07.prod.outlook.com (2603:10a6:20b:325::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.26; Mon, 30 Sep 2024 12:03:00 +0000
Received: from VI1PR0702MB3567.eurprd07.prod.outlook.com ([fe80::3bd2:999:b00c:394a]) by VI1PR0702MB3567.eurprd07.prod.outlook.com ([fe80::3bd2:999:b00c:394a%3]) with mapi id 15.20.8005.020; Mon, 30 Sep 2024 12:02:59 +0000
From: "Matthew Bocci (Nokia)" <matthew.bocci@nokia.com>
To: "bess@ietf.org" <bess@ietf.org>, "draft-ietf-bess-evpn-geneve@ietf.org" <draft-ietf-bess-evpn-geneve@ietf.org>
Thread-Topic: Document shepherd review of draft-ietf-bess-evpn-geneve-08
Thread-Index: AQHbEyvug8wLHzQSAku1cuEPAJ8ZYQ==
Date: Mon, 30 Sep 2024 12:02:41 +0000
Message-ID: <VI1PR0702MB3567DD80BB2C67BD7C6AFBECEB762@VI1PR0702MB3567.eurprd07.prod.outlook.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: VI1PR0702MB3567:EE_|AM8PR07MB8230:EE_
x-ms-office365-filtering-correlation-id: 28092774-82b9-4971-f0d5-08dce147d42c
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700018;
x-microsoft-antispam-message-info: uc63ro0OWrXZ2BuFbQdx8oR5QWQImR+hy3L+FwBugBBcAVvblrIWoRB+wvWp/JdII7h7lwJCz6YYCm3ChZTYPvvaDpE77MSNIualUfbY/grWFIXzXTeDS9KbNy6ghfFprN0E3sDoJoey5VStB2M/mldUpDQsqMeJIvbIGf1b8Kcij6t1Ngj7OZJMOWamA/ZdubYJ9Hi8fHe9/kASR1f4D7+gnJ7Wz5kGN3ZlVVzBIeNDj+XxeXXmbUYOVMCiiJlbe4qZTPgYukhyL71Nasx4FG15eA1BtvljtQVa/t+zDde6iBnsQs/jSLUD/MLPAWXC3+vjDXQ6fPJV6ZcYT5mmTcyLSQ9I31xfd5+N0rPwO+izuwRR4r81bg39H5r6/UfE9ONRfHArsGZJw6DnlMLMCbVFPfKxGnXioy9iiLoOESiju4uiQCGxgXgl/TEjkTHHjKUn5wIytrYAs2QQpReaqdH1Jeil1iMf7xiir978mbB6xHf3s49qwGFk1V1l61z6ts5bGeXtr00K07MTooFcIoHpy6Cdc8nnCovje0XJztrjrV8IjImaM1rEDmHBvBZ78FncdU23c/zAZplAj4iacr6gCIJGKibv0AGWeAKCdPVRhbPUD40y/Wx59AlnZJPUIV9TlQv05VzDfR52yWIY/ZDUcQgNtz3JD/MrItBpyo8goW3/cW8ENHQooGnpfbSo0Cs1mTN/JbHMKBpiJh3bnoGLcdIWADpBoKJ19dJ8Wdz2wHQdxHLl/RR0GSitz8L05pxj+tOWKs0q6qgGAQ/zqUCFGq/RQRdpkcTNf6ZGUKrW5FiOvtYpSdLuP0BgM9LIGb0BKNd27kXI3JLs1Qhf/amo+qRdykHt2fL9ppieI8c+9NTrJDWvvekDqGr3YE0L0277hIbntD84LclB9OWx6I2YVQjSofWrKZrKD8pwEr138mXABDbZzN0VMHbcH+C95Mc0Ef6n6N9dBUr7C8idXujTwvf2laBt8RK1bSXi2UnA9hYkSgwslZ7nzOiGtIM3G27lOUm7/QYfM90vM0pTtT7oetJBL8UG8EU2NGSnDRwBjR81k1gqJDXt/6QCe520b4Z6vLSZH1qrC3qMHP7MVAlzl/7DjxF5pt06okhE8B15qenwVOcrRrSA36n5GTQeK8uZ+nl4QSwTttjVU0uci7bVHhAFO8hoormCHGuDyWbbxR+FbiHYLNI5s/NnkZy7eYZlt3HSCf/OyKTHViSiOr7VFN95RTZ1UTz2ngOUh6ZzbkwrmOqU0rBPzeJE8lmaVT9p1nZgKI3dM1rgRoI/8R0ChqTlGJhpjo4nmcGAWqDPr/h+nGmUxAzmx/rd3WzpLMHrI7QXMcfrLxRJVw+tWS/9iyVOMpQi4zQNMykFBTU=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0702MB3567.eurprd07.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700018);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: uQcY/F6nWbp1QwEfBczdZ1cTbx+cv1aJi6HLe3xtwIs/AGptNTD0fIQpEl8KErCaZkKnFO/fz4oK98SCNWOoNEeTX2O5TDVZagUZPh3GNHJ6tZy4/BYRTVfp1CRKKwBDQiJy5ucEb2C+GgRUkrsc9tuUai74lwg/Pmdc0mfU863mOXKBqpUN9/S6U35wskbpRGaueChcQXNUW8y+ud0XYnLjLYG4Wxsfh4XlUgDLHUFf4EFsCq99ENq9HRyt3K6qiBpwVTVIFpHfpXDVC9zKx9BvwhFgkYgXLGzorR0y+fbCx6Bm7nwvbxXMKQzL5hhkmUic/ir6PClGIw72A/XF9LDy0Fgot6tVvHIUGNTfqEh2o9eOVEl5TgJ/bplXzVwnkG3bk6oUv7ax6txl7R/Pb13nFPCeKlamGHLo/AUKeioeT/u1/D9a/qPLBf7gmFDFPoiImWhk/LjvwzN1aXh7pAB2UhmhtF1M1Lvbp7wc1pZKmXBTyMQV5U38cMpxvUuLMAHmaThnJEQ8tAOfZa94IckqJdD1xecogPwqconNGebPnU+Je2TPGL5zGOfaM9nfIyushsXX7tFmuaIfKPUwVjvOApXYN3RcR+QUZojyhVcdhG9rkFaVVVQun5eAotxPRrUPPaz7uwlyeN+vLR7frnlM5tkp1tL81FONgiqyCaDK5dIeCYh7Xf0kY4kBN3NoVTv7XOnq3piI6vdy2Mdtm4GvQxblVqmstnC4n9TSc2EJPg9FMWAk0hVmH4zH+gX+/eKE3F0Uua8r82E7IILfwxUQCCxfKHjwMr6ydcE36+Q3eatCKIngGoGfiotr3GLhUCK3sk7yi/MN3roFRdFHv6APyJ6g5cnNYvqqrJ4RbrRKp7oJIzu3zgUqSMaF2M08oTImvUJblNNj6kIi79oQWxfFcobeNvGSfNh5cotYFC7b05u2X+bUZJ3Fy9LbA2K76f3w82zGD+5AjsMlFuBFU76fAWFMuHmjFzePEe02CJmc8KuXe7BK9JxYTNplOilzT4AHpRAhemYxv7nILDMllBXZ6gOCrO67FKzZ/358ihLWMPIxEdSfGaMwFhws15UUXoiMdHJ+Fy2UoururEXqZEGN5EHYJva53QGuV6HNBXRmZI43RetVAU/bQMaecr80GTL9VWoVrNM5KnWTGaeLOH1/MEBZUfgqofyaDhBJ/zmvA4mNR/j1vJJ74mDR5GMCvcSBcvRZZHdry7i4GSzplTKbSXpMmOpIQdgmVW1RuA1aHi9cZkAf1Reod3hn/vsZQ+NFBwNbYvQwhVhBP144AeUdGw6quKnC0dxYTMpYpzG0d97/vDo+weXg0j3yluhJQfMN/R2N1B2huPh0HKbqNid0nXxFbyxiMLuCDSdZ0/lx3PUlJ1XWnD5ut/WTxYXDPC/zaaNoGNOB+WcxiwWfPIwqySajqU2WBIqRA7JyRiIGQprHgFqrWSDVNJPb2Mg3jtmN34KKzqSDUKnS/w8zdArn+F8kGiAdh3YzlOmjeNAa0G6IC/5QvqZ3zuMahCPIQScfU4q5hG4rXrJULyTQNBjfam3CUN2a9TMnvNU+SRGLWY9CaOi8XeF3elDwsk2b
Content-Type: multipart/alternative; boundary="_000_VI1PR0702MB3567DD80BB2C67BD7C6AFBECEB762VI1PR0702MB3567_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0702MB3567.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 28092774-82b9-4971-f0d5-08dce147d42c
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2024 12:02:59.8040 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iAdLusKGWjSwErlWazz1wLk0spXbSTdJrexGI/AWfyACa8FzeYAvG/2mo3n+LPX/KC063KDR5sHha6mQ/sjfHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR07MB8230
Message-ID-Hash: QD6ALVU6V5TM7IQF6DRVZOFWM6QHFADY
X-Message-ID-Hash: QD6ALVU6V5TM7IQF6DRVZOFWM6QHFADY
X-MailFrom: matthew.bocci@nokia.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-bess.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [bess] Document shepherd review of draft-ietf-bess-evpn-geneve-08
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/1e4g0MjyQjMlQwuU_2aHrLW5nXA>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Owner: <mailto:bess-owner@ietf.org>
List-Post: <mailto:bess@ietf.org>
List-Subscribe: <mailto:bess-join@ietf.org>
List-Unsubscribe: <mailto:bess-leave@ietf.org>
Hi Authors, This is the document shepherd review of draft-ietf-bess-evpn-geneve-08. Thanks for a clear and readable draft. I have just a few editorial comments prefixed by MB>, below. Please treat these as you would any other working group last call comments. The line numbers below are extracted from the I-D Nits check. Thanks Matthew ================== I-D Nits throws up a couple of issues. Please correct these: Checking nits according to https://www.ietf.org/id-info/checklist : ---------------------------------------------------------------------------- ** There is 1 instance of too long lines in the document, the longest one being 8 characters in excess of 72. Checking references for intended status: Experimental ---------------------------------------------------------------------------- == Unused Reference: 'RFC7365' is defined on line 433, but no explicit reference was found in the text ** Obsolete normative reference: RFC 5512 (Obsoleted by RFC 9012) ========== 14 EVPN control plane for Geneve 15 draft-ietf-bess-evpn-geneve-08 17 Abstract 19 This document describes how Ethernet VPN (EVPN) control plane can be MB> s/Ethernet VPN / the Ethernet VPN 20 used with Network Virtualization Overlay over Layer 3 (NVO3) Generic 21 Network Virtualization Encapsulation (Geneve) encapsulation for NVO3 22 solutions. 24 EVPN control plane can also be used by Network Virtualization Edges MB> s / EVPN control / the EVPN control 25 (NVEs) to express Geneve tunnel option TLV(s) supported in the 26 transmission and/or reception of Geneve encapsulated data packets. [snip] 77 1. Introduction 79 The Network Virtualization over Layer 3 (NVO3) solutions for network 80 virtualization in data center (DC) environment are based on an IP- 81 based underlay. An NVO3 solution provides layer 2 and/or layer 3 82 overlay services for virtual networks enabling multi-tenancy and 83 workload mobility. MB> I suggest rephrasing the last sentence and adding a reference to Geneve, as follows: An NVO3 solution provides layer 2 and/or layer 3 overlay services for virtual networks enabling multi-tenancy and workload mobility. Geneve [RFC8926] is an encapsulation for networks providing such solutions. 85 This document describes how the EVPN control plane defined in 86 [RFC7432] can signal Geneve encapsulation type in the BGP Tunnel 87 Encapsulation Extended Community defined in [RFC9012]. In addition, 88 this document defines how to communicate the Geneve tunnel option 89 types using BGP Tunnel Encapsulation Attribute sub-TLV. The Geneve 90 tunnel options are encapsulated as TLVs after the Geneve base header 91 in the Geneve packet as described in [RFC8926]. 93 [I-D.ietf-nvo3-encap] recommends that a control plane determine how 94 Network Virtualization Edges (NVEs) use the Geneve option TLVs when 95 sending/receiving packets. In particular, the control plane MB> s/ sending/receiving / sending or receiving 96 negotiates the subset of option TLVs supported, their order and the 97 total number of option TLVs allowed in the packets. This negotiation 98 capability allows, for example, interoperability with hardware-based 99 NVEs that can process fewer options than software-based NVEs. 101 This EVPN control plane extension will allow an NVE to express what 102 Geneve option TLV types it is capable of receiving, or sending over MV> s/ receiving or sending over / receiving, or sending, over 103 the Geneve tunnel with its peers. 105 In the datapath, a transmitting NVE MUST NOT encapsulate a packet 106 destined to another NVE with any option TLV(s) the receiving NVE is 107 not capable of processing. 109 Furthermore, the document defines a new ethernet option TLV to handle 110 BUM traffic, etree root and leaf indication, and split horizon. 112 2. Terminology 114 The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", 115 "SHOULD", "SHOULD NOT", "RECOMMENDED", "MAY", and "OPTIONAL" in this 116 document are to be interpreted as described in [RFC2119]. 118 3. Abbreviations and Terminology 120 NVO3: Network Virtualization Overlays over Layer 3 MB> Just “Network Virtualization over Layer 3” since this is the way NVO3 is expanded in NVO3 RFCs. 122 Geneve: Generic Network Virtualization Encapsulation. [snip] 153 4.1. Ethernet option TLV 155 [RFC8365] describes when an ingress NVE uses ingress replication to 156 flood unknown unicast traffic to the egress NVEs, the ingress NVE 157 needs to indicate to the egress NVE that the Encapsulated packet is a 158 BUM packet. This is required to avoid transient packet duplication 159 in all-active multi-homing scenarios. For Geneve, we need a bit for 160 this purpose. 162 [RFC8317] uses an MPLS label for leaf indication of BUM traffic 163 originated from a leaf attachment circuit (AC) in an ingress NVE so 164 that the egress NVEs can filter BUM traffic toward their leaf ACs. 165 For Geneve, we need a bit for this purpose. MB> I suggest changing the last sentence to: “For Geneve, a bit is required for this purpose.” 167 Although the default mechanism for split-horizon filtering of BUM 168 traffic on an Ethernet segment for IP-based encapsulations such as 169 VxLAN, GPE, NVGRE, and Geneve, is local-bias as defined in section 170 8.3.1 of [RFC8365], there can be an incentive to leverage the same 171 split-horizon filtering mechanism of [RFC7432] that uses a 20-bit 172 MPLS label so that a) the a single filtering mechanism is used for 173 all encapsulation types and b) the same PE can participate in a mix 174 of MPLS and IP encapsulations. For this purpose a 20-bit label field 175 MAY be defined for Geneve encapsulation. The support for this label 176 is OPTIONAL. MB> I think you mean that a 20-bit label field is defined, but its support is OPTIONAL. I suggest rephrasing the penultimate sentence to: “For this purpose a 20-bit label field is defined for Geneve encapsulation.” 178 If an NVE wants to use local-bias procedure, then it sends the new MB> s/use local-bias procedure / the local bias procedure 179 option TLV with ESI-label=0 180 0 1 2 3 181 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 182 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 183 | Option Class=Ethernet |C| EVPN-OPTION|R|R|R| Len=0x2 | 184 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 185 |B|L|H| Rsvd | = 0 | 186 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ [snip] 278 0 1 2 3 279 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 280 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 281 | Option Class | Type |R|R|R| Length | 282 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 283 | Option Class | Type |R|R|R| Length | 284 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ 286 Figure 4: Geneve Option TLVs 288 An NVE informs its peers which Geneve option TLVs it can receive by 289 including the first 4 bytes of each option TLV in the Geneve Tunnel 290 Option Types sub-TLV. The peers MUST send Geneve packets to this NVE 291 with only the option TLVs that it has specified here, following the 292 same order. MB> The last sentence above is unclear to me. I propose to rephrase this to: “Peers MUST send Geneve packets to this NVE containing only the specified Option TLVs and in the same order That they are received in the Geneve Option Types Sub-TLV.” 294 The above sub-TLV(s) MAY be included with Ethernet A-D per-ES routes 295 and MUST NOT be included with other routes. [snip] 345 7. Security Considerations 347 The mechanisms in this document uses EVPN control plane as defined in 348 [RFC7432]. Security considerations described in [RFC7432] are 349 equally applicable. 351 This document uses IP-based tunnel technologies to support data plane 352 transport. Security considerations described in [RFC7432] and in 353 [RFC8365] are equally applicable. 355 8. IANA Considerations 357 IANA is requested to assign a new option class from the "Geneve Option Class" 358 First Come First Served ranges registry for the Ethernet option TLV. MB> I suggest rephrasing the above to: “IANA is requested to assign a new option class from the First Come First Served ranges of the "Geneve Option Class" registry for the Ethernet option TLV. 360 Option Class Description Reference 361 ------------ --------------- ------------- 362 XXXX Ethernet option This document 364 IANA is requested to assign a new BGP Tunnel Encapsulation Attribute 365 Sub-TLV from the BGP Tunnel Encapsulation Attribute Sub-TLVs 366 First Come First Served ranges registry. MB> I suggest rephrasing this to: “IANA is requested to assign a new BGP Tunnel Encapsulation Attribute Sub-TLV from the First Come First Served ranges of the BGP Tunnel Encapsulation Attribute Sub-TLVs registry.” 368 BGP Tunnel Attribute Sub-TLV Description Reference 369 ---------------------------- ------------------------- ------------- 370 XXXX Geneve tunnel option type This document 372 9. Acknowledgements 374 The authors wish to thank T. Sridhar, for his input, feedback, and 375 helpful suggestions. 377 10. References 379 10.1. Normative References 381 [I-D.ietf-nvo3-encap] 382 Boutros, S. and D. E. Eastlake, "Network Virtualization 383 Overlays (NVO3) Encapsulation Considerations", Work in 384 Progress, Internet-Draft, draft-ietf-nvo3-encap-12, 19 385 February 2024, <https://datatracker.ietf.org/doc/html/ 386 draft-ietf-nvo3-encap-12>. MB> Please update this to [RFC9638]. Also, I don’t think this needs to be a normative reference. I suggest moving this to the informative references section
- [bess] Document shepherd review of draft-ietf-bes… Matthew Bocci (Nokia)