Return-Path: X-Original-To: bess@ietfa.amsl.com Delivered-To: bess@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DBECAC151991; Fri, 5 Jul 2024 14:56:02 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -2.802 X-Spam-Level: X-Spam-Status: No, score=-2.802 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=ciena.com Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XXFkFYdyxzGB; Fri, 5 Jul 2024 14:55:58 -0700 (PDT) Received: from mx0b-00103a01.pphosted.com (mx0b-00103a01.pphosted.com [67.231.152.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 710E9C16942C; Fri, 5 Jul 2024 14:55:58 -0700 (PDT) Received: from pps.filterd (m0222748.ppops.net [127.0.0.1]) by mx0a-00103a01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 465CQXrE008469; Fri, 5 Jul 2024 17:55:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ciena.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=06252019; bh=jH0UvTWGFd6YU35G3o0bmZD/Z cKtGue8opuGBvDl2fU=; b=acacK3Uv6PEmt3YfQEKzLFPSZsdKmHnTf1NsrZQC4 FQIWSOnIeWHlXW3sZaJiu2LbZSs/AG35yPJjHS4qk93ns6FQr5O5BfafNyfKawEp fv4EGaMPjsYaqABvJi6h6cWrWpDELJZBH4MHXpia86KfeAg8vs8OzBhBCYYYlW41 gkAd2BRZlfej4RvxPVITirZ+2eYiPiZ3MOWHytdLNZAiGiFw/Whm/1uCHWjDZy6d MZ1rILC3Y1UbnPkDosg8XhtdLVRNmCZGxRFyht92z5qcRs1W1wRVq+0BlOrLFdI3 6tfmwHDhc9XrZ8+DFYYyKSq0h5Ekiym+Ux6GLC/xQxo1w== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazlp17011027.outbound.protection.outlook.com [40.93.14.27]) by mx0a-00103a01.pphosted.com (PPS) with ESMTPS id 406gu1915m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 05 Jul 2024 17:55:57 -0400 (EDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eYHVHjLANUEbf3+1FbalEd+Cw3skyu3vqm158F+eZwgxFTq39hqNGxXCdKbbwXoI8TZUha1i81OirZYYZUFlh9oLyox/41ltKU3ZhQRIrhyKvoNJ5jzMzdM0bL8xTCCwPm46v/lLFDDl2SLU3jj3YXHeOCj+LTGQy770EIxXtFef1bK4AOT2mtSGnhMKc6FPppWaujcRTf6DocA7rLVT9VKam+wwGvlDUrSpxlidHScvzCYnINfRQeF6z570j2F0dQ3Buidqp9gLqLl9AW7vCpE4LSJboDXZs/PID4W0U06+YO2xB6a9QT84YmoiZ/7Wz92HyPTM6t5thD+ehsYy8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jH0UvTWGFd6YU35G3o0bmZD/ZcKtGue8opuGBvDl2fU=; b=WQZVk5wztgsvmHchIl1VKdGUOvUEFf9/mPDGHWuqinkLkSqasUxqw7HPzDdqo00YJrn9K9sE88wLc5XkLg48d8FgjANG2BvO6OwosMTWpNjCKFIzLIVykxumNtg07EBfgcxUW8A5l/H2JMEVtPCemgZseIeQelFWQZzs5UahAAyS2Tpj+FxQw+F8P3EjPSO2UOxW+ZsRlELwMisIz2qgLji4PuIeqx80LdpFa7xlgQCDAEcDYW6btAdlwRAJSSxX4Tc9sWz355zW6XDK+fgi4dGeOXPcnYglQtfMMQFIqn0GVRKw/+LEgCyxJ8Fq0Z3mVEav9Kl9s1Bd/esGeIjVvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ciena.com; dmarc=pass action=none header.from=ciena.com; dkim=pass header.d=ciena.com; arc=none Received: from PH7PR04MB8973.namprd04.prod.outlook.com (2603:10b6:510:2f9::13) by BN8PR04MB6337.namprd04.prod.outlook.com (2603:10b6:408:dd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.30; Fri, 5 Jul 2024 21:55:55 +0000 Received: from PH7PR04MB8973.namprd04.prod.outlook.com ([fe80::c6de:7d7a:10fb:ae61]) by PH7PR04MB8973.namprd04.prod.outlook.com ([fe80::c6de:7d7a:10fb:ae61%7]) with mapi id 15.20.7719.029; Fri, 5 Jul 2024 21:55:55 +0000 From: "Boutros, Sami" To: "Matthew Bocci (Nokia)" , Jonathan Hardwick , "rtg-dir@ietf.org" Thread-Topic: Rtgdir early review of draft-ietf-bess-evpn-geneve-07 Thread-Index: AQHauzW4Kj8YN6zY906bXHj9X93EvLHox8CK Date: Fri, 5 Jul 2024 21:55:54 +0000 Message-ID: References: <171759251614.32632.9190523396903949071@ietfa.amsl.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR04MB8973:EE_|BN8PR04MB6337:EE_ x-ms-office365-filtering-correlation-id: 49c4b0de-dc10-4cb0-d220-08dc9d3d3ead x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?W/URwLLnZPByMzLQUwqhHTozJFQ8aIlu2Yiadxx+W1+o5i5sIWur8crM+WuJ?= =?us-ascii?Q?tkGF8Nk8vxuZKnfdeKM4p8hZtqVNMFQkwhstvz6rmxLXUfjDTITUwbV0P8SV?= =?us-ascii?Q?nuFS8zjn1yG2qXo7WFkYOo0LEvlkhYsUL8tVtz2YtfFXGnuLdL5Jv4K4dBrj?= =?us-ascii?Q?ic39IV8gnx1C1XiCiYteuiGsYRlNCyvUlwoBEjCIvJwlzHQW5/xJyUpEDMhg?= =?us-ascii?Q?2xKv6JAlhVD0X4c8p0tPKK7N9wGmpgr9ClsSxB9BXObGkABz+hTTj7WvMBcF?= =?us-ascii?Q?YogKlLeZp3LvE5tuwivZVBbW9279H0rZX5RYzyKrno1Dgu6e1QWFTxCSR5VY?= =?us-ascii?Q?lGzYU7zhLui1NaTqgAy6ZWiEjnSgCE7vUX4EUelZQfCwnr1ETpajrJp35fn8?= =?us-ascii?Q?7XxeFZ7TsjKUtMwLXr9lNgBy2mIrXhPTHS+aLr5HWSe4oZX0K/gckPHm9J04?= =?us-ascii?Q?dNCMXi2MR90aZ3h7BE19k5CeXViB8/zq+zX3ZwjY4QxdESwq/rVP3cUnlay1?= =?us-ascii?Q?ExC7enU5ORdpqys2y51YiNyrq1v7aWNWt3cuOsrOSyyJCLfVfF1oXNc3J0u+?= =?us-ascii?Q?4mfG+izUa8TOZqfdpji2txJUMCK9bNF0Y0Fmi5NjUU7ncZNY1x7RNMkTumGL?= =?us-ascii?Q?pmV4I6YiZWqB5C4ZwNXYfAcw34YJv/9km+J7BW7bL8JXLC7N92e+Q4y7Jwvc?= =?us-ascii?Q?xFDLwIbs0Hd5zbmlnjgqh6p6iNwRy7ZYnIj2FKQQyOfGrnGr9OAp5pLAmO3c?= =?us-ascii?Q?+wSnoPJKlSLP+1EqWkbOT0ztof2rmvB3YiNkU6rpsHhmmAVOYhNfQdQgS+7s?= =?us-ascii?Q?HLrnTLyqjOFMqRgix7ZgGHQ6+HUaP3j8pqhUrN4+6ivR/oOG9dmxPEDqW8L0?= =?us-ascii?Q?79sg/pXArK88dcqjxov3zzj9sZu/fq9ogaQm6YV+xshqb3otjELjhZIhGKSC?= =?us-ascii?Q?NrlRTbeUOccZKz+23/mlu+LRoYShapmbs86SsIzfq1QM64fkmWab2nLJ58VL?= =?us-ascii?Q?jvLx/BJ374hG5I0uZdVDSuZ7p/gmUTiNc/m7qh9ZGjysmtfDgjYP8D4blhDg?= =?us-ascii?Q?YSvIigGx5aEpKWqvKhTGBfVLAxp129gTPdBAE4PvImIBDxQGRGMoNypMXuPF?= =?us-ascii?Q?vFdTvs4PiccxYBOz3pmfwctjDtWB9fUhFU8Bf1+oSd5ujR/4QwKZQJK7r+XP?= =?us-ascii?Q?/SAuAle5JOYM+k8otpFVs8/Mqg/MrZRb1dDhSwPi97U4NY03Et1gwMosUo19?= =?us-ascii?Q?2CbkushCAoQ208Q/DKiIsp42zMnPTmxLBBU8QbWnLGkdLgg+Davzf7hQlWdI?= =?us-ascii?Q?YcCMpGy703DnPSfxmcZsBRRJ21VVpE0TKGo/400571HYm4ngCG4MNNBtmo6N?= =?us-ascii?Q?dmGF8AA=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR04MB8973.namprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aeoIa7MLL2gamO+a4v0t58SLCC5mlyrXqyUwyHAoMXmnfY54wz8EoPr/5je0?= =?us-ascii?Q?52H1VRYlcFJsru3aZcigrUnAsvuUYGn+pJjsfrbgD2NqICEJb4btsTpV40xR?= =?us-ascii?Q?LQlW2V5PKjFBR4o7fZPQuE9epjXfNAyAtgZ3GynlOVQkzdQ7pBKNE62Mkxyi?= =?us-ascii?Q?iGLgtdo+RAk8W+sGLsudmlNfVWTZ5nVUAPKxrc4kuufHc79P52LONTGYWP4v?= =?us-ascii?Q?pHF/gaMRqu9a/F7cDivRq7QW3CGxt7JPz1w7VFHr+1tjAnoK7odhSpAIQl9e?= =?us-ascii?Q?BiX/byiCgkyCDAc1nonoZK4m/Sm+MA/qOfEXrgP30NHrhTU9Vzb1ctE6lVP4?= =?us-ascii?Q?smQnnsKz+xh1C3WxaRHn5McFfREs5dhdQQ9B3eSx0VwGNZPm9DfKugethvVJ?= =?us-ascii?Q?p9erZbSBfxASn4CFN0mTPo0fUdhW9+DGxwUjuJRHWOqaJlfRj2PiT2w0aNvn?= =?us-ascii?Q?yeLsu5npqFc0hfG4iwN06ofDhVBoHZVNbrsZcfsEyvKm2ihrAqu+XDJazVQ0?= =?us-ascii?Q?FLaEIwVebdVurdn9bCHE3A/yidfSXXq4PtMMEg6ioqTnhDCDLU2GOFH3JHEy?= =?us-ascii?Q?9TgMKXJTXTtryv6WyMOQMXdrZxOM2UM4G7z/V/VknQV0xGGVAte6MKkkaYiO?= =?us-ascii?Q?/iI63xecXIaMQNMPHAcb+l1g+YkwSjF5LrS7MF9431H5xYNYTCul1CkGctA3?= =?us-ascii?Q?LY6WYrigkgA25F3Itc+7BMh3m3L00ncNJEG7KqJVdyQQ4EMFN3KBtv64IjxU?= =?us-ascii?Q?jbD90pUy1X88K9xGqXrC6RZlCcq08O9W5uZ30rodf133+Oa3QzYm4Y0ZkYoj?= =?us-ascii?Q?MTyZU4c7JJMwOYC1c5Jif5Lwinae8wzr+K3ZgMoto6WqPQ5Ngrq2hsoMfiUe?= =?us-ascii?Q?mPx6K77WD+/cl/0xHBvJIk0YZ40B3vWVbJd4CmLl1lmRKYcCRHJmjAzBTqFi?= =?us-ascii?Q?ZvdGsRjIfwTGBugjgSDx83CNffcm7KJWXGH3SRcF/yGnlFBZ8NDKy5SPotSF?= =?us-ascii?Q?gcVLVoxJTqBdrgROAUp1Kb+mq5h658ATLE7/Geb/pWobAdMxGnRbH50Q/6MW?= =?us-ascii?Q?RislWIQDkQ/O8E48jgNfatTPcx6/ICoA25yOFwn0zs8rOeE3yMgIYc39Re6B?= =?us-ascii?Q?pffDy3p9cDLUno7g23r2R+1x2jFyOKiqNKUAxbubMc1sGdduGS6meGA5r7A0?= =?us-ascii?Q?/M6LDTHC9Mog0W5rsJgtMsA9bcG+sO10vjLbdR7ZW7jqRrwFIKA/bOdyluuO?= =?us-ascii?Q?sYZKtbzE5ho29SIHBfjgvUoF4NdhGzp61k8CHvcfVUa3h+M6poFHERqkQ1HI?= =?us-ascii?Q?SmAb8wHkWimwVZ51JCsueOLspLo4A6LWWrGhMSEWrm/L8T7KrM9ztRdqlVa1?= =?us-ascii?Q?T7Keum71dJbQXbarUuGIQ2oul9ZI5pt27a0xtf2plIDki2YdL2WfUBZ7b8fz?= =?us-ascii?Q?OeWo1unOVVyrZk54kuRMsvzhivkZnr8yiE+Y8yDRvczSCGNxniFZyb471Pkz?= =?us-ascii?Q?VMpIumOKbaOedhXlyFoGQMcN58STYqrN5L9V7LNi1zt6s4YP0lgrl1+cLgfH?= =?us-ascii?Q?4+LYDlqG9Gw6rNEXGjkz+J+NPMyxVMkhpb0sszLR3eyjYmtp/XI+NruOSJbz?= =?us-ascii?Q?3g=3D=3D?= Content-Type: multipart/alternative; boundary="_000_PH7PR04MB89733354BA6E94941FDE560DC4DF2PH7PR04MB8973namp_" MIME-Version: 1.0 X-OriginatorOrg: ciena.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR04MB8973.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49c4b0de-dc10-4cb0-d220-08dc9d3d3ead X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2024 21:55:54.9627 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 457a2b01-0019-42ba-a449-45f99e96b60a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XzUwmZOx6bcrBa275s9IHdCknwcz6OODupvMYlteT/in7CSJRCgJref3zeIJ+LixwBRX8BHAWJg0m5+2RH90Sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB6337 X-Proofpoint-GUID: y7iC6jZUoYYpjiL7-CBJW2F8Q1O4rwHU X-Proofpoint-ORIG-GUID: y7iC6jZUoYYpjiL7-CBJW2F8Q1O4rwHU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-05_16,2024-07-05_01,2024-05-17_01 Message-ID-Hash: 7CLFLJA6ROPIYYZ6YQKDFEYDEUNQTCML X-Message-ID-Hash: 7CLFLJA6ROPIYYZ6YQKDFEYDEUNQTCML X-MailFrom: prvs=6916620711=sboutros@ciena.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-bess.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: "bess@ietf.org" , "draft-ietf-bess-evpn-geneve.all@ietf.org" X-Mailman-Version: 3.3.9rc4 Precedence: list Subject: =?utf-8?q?=5Bbess=5D_Re=3A_Rtgdir_early_review_of_draft-ietf-bess-evpn-genev?= =?utf-8?q?e-07?= List-Id: BGP-Enabled ServiceS working group discussion list Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --_000_PH7PR04MB89733354BA6E94941FDE560DC4DF2PH7PR04MB8973namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Jonathan for the review, I updated the documents to address your concerns. And submitted https://www.ietf.org/archive/id/draft-ietf-bess-evpn-geneve-0= 8.txt Please see comments inline. Reviewer: Jonathan Hardwick Review result: Has Issues Document: draft-ietf-bess-evpn-geneve-07 Reviewer: Jon Hardwick Review Date: 5 June 2024 Summary: I have some minor concerns about this document that I think should be resol= ved as part of the normal WGLC process. Comments: --- Section 1 - please could you also mention that you are adding a new Etherne= t Option TLV to Geneve (i.e. the thing in section 4) to account for BUM traff= ic and split-horizon control? SB:> Added the following Furthermore, the document defines a new ethernet option TLV to handle BUM traffic, etree root and leaf indication, and split horizon. SB:> Section 1 final paragraph - Introduction section is not the place for norma= tive statements. Suggest removing this sentence ("a transmitting NVE MUST NOT...= ") as you say the same thing in 5.1. SB:> I prefer to keep it, given that we added to section 1 a description of sect= ion 4. SB:> Section 4.1 - since Length field is given in 4-byte multiples, please could= you change "length=3D4" to either "length=3D4 octets" or "length=3D0x1"? Simila= r for "length=3D8". SB:> ok Section 4.1 - The B,L,R bits are being defined where these three bits were previously reserved, is that right? I assume you are doing this just for option-class=3DEthernet and that they continue to be reserved for other opt= ion classes? Given that these reserved bits are part of the common Option TLV header I'm not sure it's correct to give them a meaning just for one Option= TLV type and not others. This is likely to lead to confusion, at least. I sug= gest that they should be part of the Option TLV payload. That is, make the Ethe= rnet Option TLV always like Figure 2 (8 octets long), with the new flags in the = Rsvd field, and an extra flag to indicate whether the ESI label is included or n= ot. Section 4.1 - I wonder if you should use a different letter for the Root-Indication flag, as R is commonly used to mean "Reserved" (particularl= y by RFC 8926). SB:> I took your suggestion, and changed the Root-indication bit to be H in= stead of R. Section 4.1 - "Type is set to EVPN-OPTION with value =3D 0" - do you just m= ean " Type is set to 0"? SB:> Correct. Section 5 para 2 - typo "Typei" Section 5.1 diagram - I believe that length is always 2 octets and never 1 octet, since the type is in the range 192-252 (any type >128 has a 2-octet length per RFC 9012). Section 5.1 - Regarding the following sentence: BEGIN QUOTE An NVE receiving the above sub-TLV, MUST send Geneve packets to the originator NVE with only the option TLVs the receiver NVE is capable of receiving, and following the same order. END QUOTE Does the "receiver NVE" in this sentence (2nd line) refer to the NVE that receives the Geneve Tunnel Option Types sub-TLV or to the NVE that receives= the subsequent Geneve packets (that is, the one referred to in the same sentenc= e as the "originator NVE")? I think it must be the latter - "receiver NVE" and "originator NVE" in this sentence are the same NVE. If so, that's confusin= g! Here is a suggested rewording. BEGIN NEW: An NVE informs its peers which Geneve option TLVs it can receive by including the first 4 bytes of each option TLV in the Geneve Tunnel Option Types sub-TLV. The peers MUST send Geneve packets to this NVE with only the option TLVs that it has specified here, following the same order. END NEW: SB:> Updated the text. Section 5.1 - the final sentence needs rewording because it makes two diffe= rent normative statements. OLD: "The above sub-TLV(s) MAY be included with only Ethernet A-D per-ES route= s" NEW: "The above sub-TLV(s) MAY be included with Ethernet A-D per-ES routes and MUST NOT be included with other routes." SB:> Updated the text. Thanks, Sami --_000_PH7PR04MB89733354BA6E94941FDE560DC4DF2PH7PR04MB8973namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Thanks Jonathan for= the review,

 

I updated the docum= ents to address your concerns.

 

And submitted https://www.ietf.org/archive/id/draft-ietf-bess-evpn-geneve-08.txt=

 

Please see comments= inline.

Reviewer: Jonathan Hardwick
Review result: Has Issues

Document: draft-ietf-bess-evpn-geneve-07
Reviewer: Jon Hardwick
Review Date: 5 June 2024

Summary:
I have some minor concerns about this document that I think should be resol= ved
as part of the normal WGLC process.

Comments:
---

Section 1 - please could you also mention that you are adding a new Etherne= t
Option TLV to Geneve (i.e. the thing in section 4) to account for BUM traff= ic
and split-horizon control?

SB:> Added the following

   <t= >Furthermore, the document defines a new ethernet option TLV to handle

   BUM t= raffic, etree root and leaf indication, and split horizon.</t>=

SB:>


Section 1 final para= graph - Introduction section is not the place for normative
statements. Suggest removing this sentence ("a transmitting NVE MUST N= OT...")
as you say the same thing in 5.1.

SB:>

I prefer to keep it, given that= we added to section 1 a description of section 4.

SB:>


Section 4.1 - since Length field is given in 4-byte multiples, please could= you
change "length=3D4" to either "length=3D4 octets" or &q= uot;length=3D0x1"? Similar for
"length=3D8".

SB:> ok


Section 4.1 - The B,L,R bits are being defined where these three bits were<= br> previously reserved, is that right?  I assume you are doing this just = for
option-class=3DEthernet and that they continue to be reserved for other opt= ion
classes?  Given that these reserved bits are part of the common Option= TLV
header I'm not sure it's correct to give them a meaning just for one Option= TLV
type and not others.  This is likely to lead to confusion, at least.&n= bsp; I suggest
that they should be part of the Option TLV payload.  That is, make the= Ethernet
Option TLV always like Figure 2 (8 octets long), with the new flags in the = Rsvd
field, and an extra flag to indicate whether the ESI label is included or n= ot.

Section 4.1 - I wonder if you should use a different letter for the
Root-Indication flag, as R is commonly used to mean "Reserved" (p= articularly by
RFC 8926).

SB:> I took your suggestion,= and changed the Root-indication bit to be H instead of R.


Section 4.1 - "Type is set to EVPN-OPTION with value =3D 0" - do = you just mean "
Type is set to 0"?

SB:> Correct.


Section 5 para 2 - typo "Typei"

Section 5.1 diagram - I believe that length is always 2 octets and never 1<= br> octet, since the type is in the range 192-252 (any type >128 has a 2-oct= et
length per RFC 9012).

Section 5.1 - Regarding the following sentence:
BEGIN QUOTE
   An NVE receiving the above sub-TLV, MUST send Geneve packets t= o the
   originator NVE with only the option TLVs the receiver NVE is c= apable
   of receiving, and following the same order.
END QUOTE

Does the "receiver NVE" in this sentence (2nd line) refer to the = NVE that
receives the Geneve Tunnel Option Types sub-TLV or to the NVE that receives= the
subsequent Geneve packets (that is, the one referred to in the same sentenc= e as
the "originator NVE")?  I think it must be the latter - &quo= t;receiver NVE" and
"originator NVE" in this sentence are the same NVE.  If so, = that's confusing!
Here is a suggested rewording.

BEGIN NEW:
   An NVE informs its peers which Geneve option TLVs it can recei= ve
   by including the first 4 bytes of each option TLV in the Genev= e Tunnel
   Option Types sub-TLV.  The peers MUST send Geneve packets= to this
   NVE with only the option TLVs that it has specified here, foll= owing the
   same order.
END NEW:

SB:> Updated the text.<= /o:p>


Section 5.1 - the final sentence needs rewording because it makes two diffe= rent
normative statements. OLD:
  "The above sub-TLV(s) MAY be included with only Ethernet A-D pe= r-ES routes"
NEW:
  "The above sub-TLV(s) MAY be included with Ethernet A-D per-ES = routes and
  MUST NOT be included with other routes."

SB:> Updated the text.<= /o:p>

Thanks,

Sami

--_000_PH7PR04MB89733354BA6E94941FDE560DC4DF2PH7PR04MB8973namp_--