Re: [bess] MIBDoc review of draft-ietf-bess-l2l3-vpn-mcast-mib-07

Glenn Mansfield Keeni <glenn@cysols.com> Sun, 09 July 2017 12:12 UTC

Return-Path: <glenn@cysols.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8479C129B15; Sun, 9 Jul 2017 05:12:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K00LmJ_OGBUi; Sun, 9 Jul 2017 05:12:12 -0700 (PDT)
Received: from niseko.cysol.co.jp (niseko.cysol.co.jp [210.233.3.236]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3C935129A97; Sun, 9 Jul 2017 05:12:11 -0700 (PDT)
Received: from [192.168.0.88] (cysvpn01.priv.cysol.co.jp [192.168.0.88]) (authenticated bits=0) by aso.priv.cysol.co.jp (8.14.9/8.14.9) with ESMTP id v69CC2rd024932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 9 Jul 2017 21:12:03 +0900 (JST) (envelope-from glenn@cysols.com)
To: Hiroshi Tsunoda <tsuno@m.ieice.org>
Cc: Mach Chen <mach.chen@huawei.com>, "mib-doctors@ietf.org" <mib-doctors@ietf.org>, "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>, "EXT - thomas.morin@orange.com" <thomas.morin@orange.com>, Martin Vigoureux <martin.vigoureux@nokia.com>, "bess@ietf.org" <bess@ietf.org>
References: <56E7D219.7000902@orange.com> <BLUPR0501MB1715A3B288A27A39E99203B8D4490@BLUPR0501MB1715.namprd05.prod.outlook.com> <c757a323-24a7-2696-657e-88f8e15e8a36@cysols.com> <CAPbjwkyFeX-S=sJwNMX-fgWThnMMiu_nF8xvcMow_BgJSfwsSQ@mail.gmail.com> <5e663cf0-1418-c410-bcf8-b235ee73fc29@cysols.com> <CAPbjwkyN0yLkpOXWt8D2-Niw7BCoujF+8JLjrPwgWobF03hZ7g@mail.gmail.com> <6f89f1f2-31e9-bf4a-05e9-1bb6e02f339e@cysols.com> <CAPbjwkyEnCGZEsGKjHozWmg-X-P3483=205BBGV9+DxbfJsDmQ@mail.gmail.com> <03f83a27-e397-818d-65e7-27f95cd6e6e0@cysols.com> <CAPbjwkzkKOULh98QBmbArFWXv=o_pyd7J82u7_GvwkWELdY0Pg@mail.gmail.com> <8f9aaac8-f44d-4844-d376-9c37bd7a81e0@cysols.com> <1848f053-9a5e-2f52-09b4-ce0e1688b557@cysols.com> <CAPbjwkzgORotsvYPWF2fqC7icJFXi5z10D1UHDTtYp1wojxw0Q@mail.gmail.com> <CAPbjwkw=zTUB+RL2MN7g2CeW07Xc6o39g6sf6ZpKap1+49ENiw@mail.gmail.com> <3bb4da95-ce97-385d-ae59-963d8c6f3db0@cysols.com> <CAPbjwky5ixKXn60bdqD=9mW=ut4rANiQ7AKMCjZw8UTEzxfrqw@mail.gmail.com>
From: Glenn Mansfield Keeni <glenn@cysols.com>
Message-ID: <6c61efa2-a2fc-728d-2870-4771b7abccb0@cysols.com>
Date: Sun, 9 Jul 2017 21:11:57 +0900
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CAPbjwky5ixKXn60bdqD=9mW=ut4rANiQ7AKMCjZw8UTEzxfrqw@mail.gmail.com>
Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/EE8mj1x05nNjEKwBfZiRjicIkLA>
Subject: Re: [bess] MIBDoc review of draft-ietf-bess-l2l3-vpn-mcast-mib-07
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Jul 2017 12:12:14 -0000

Dear Tsuno/Zhang,
  > Thank you for your comments. I posted a new revision (-09)
This draft looks good. Thank you very much.

L2L3-VPN-MCAST-TC-MIB is almost OK.
smilint gives warnings
   L2L3-VPN-MCAST-TC-MIB:63: [5] {type-unref} warning: current type
   `L2L3VpnMcastProviderTunnelType' is not referenced in this module
   L2L3-VPN-MCAST-TC-MIB:112: [5] {type-unref} warning: current type
   `L2L3VpnMcastProviderTunnelId' is not referenced in this module
These may be ignored.
   L2L3-VPN-MCAST-TC-MIB:112: [5] {type-without-format} warning: type
   `L2L3VpnMcastProviderTunnelId' has no format specification
This may be avoided by specifying a format in which the
L2L3VpnMcastProviderTunnelId should be printed.
Is there a preferred format? How will this be printed?
One continuous octet string?

L2L3-VPN-MCAST-MIB is also syntactically OK.

But before we go on to the next stage could you please confirm that
A. The l2L3VpnMcastPmsiTunnelAttributeTable needs all of the following
    four MOs as index for its rows
              l2L3VpnMcastPmsiTunnelAttributeFlags,
              l2L3VpnMcastPmsiTunnelAttributeType,
              l2L3VpnMcastPmsiTunnelAttributeLabel,
              l2L3VpnMcastPmsiTunnelAttributeId
    The l2L3VpnMcastPmsiTunnelAttributeId by itself is inadequate? If yes
    please explain it to me. Or point to the text that contains the
    explanation.
I have been unable to confirm the above from the draft - that is very
likely due to my lack of understanding of the l2L3VpnMcast technology.

Glenn

On 2017/06/22 2:35, Hiroshi Tsunoda wrote:
> Dear Glenn,
> 
> Thank you for your comments. I posted a new revision (-09) as follows.
> 
> URL:
> https://www.ietf.org/internet-drafts/draft-ietf-bess-l2l3-vpn-mcast-mib-09.txt
> Htmlized:
> https://tools.ietf.org/html/draft-ietf-bess-l2l3-vpn-mcast-mib-09
> Htmlized:
> https://datatracker.ietf.org/doc/html/draft-ietf-bess-l2l3-vpn-mcast-mib-09
> Diff:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-bess-l2l3-vpn-mcast-mib-09
> 
> In the new revision, all of your comments are addressed and
> the following additional changes are made.
> 
> -   Update the definition and description of L2L3VpnMcastProviderTunnelType
>      Describe the enumerated values and the corresponding
>      tunnel type.
>      I added new valule, transportTunnel (8) defined in [RFC7524].
> 
>   - Add some description related to transportTunnel (8)
>     into the defi L2L3VpnMcastProviderTunnelId
> 
>   - Update the description of l2L3VpnMcastPmsiTunnelAttributeFlags
>     according to [RFC7902]
> 
>   -  Added a new object, l2L3VpnMcastPmsiTunnelAttributeAddlFlags.
>      This is defined in [RFC7902]
> 
> I also removed some paragraph from 1.1 Terminology section,
> because those seem verbose.
> 
> Please see some other notes below.
> 
> 2017-06-05 12:24 GMT+02:00 Glenn Mansfield Keeni <glenn@cysols.com>om>:
>> 1. The explanations for the size of the identifiers for each tunneling
>>     technology in TC L2L3VpnMcastProviderTunnelId
>>     is nicely done. These are aligned with definitions in rfc6514.
>>     In
>>             noTunnelId         (0), -- No tunnel information
>>     is there a specific reason to name it 'noTunnelId' instead of
>>     'noTunnelInfo'.
> 
> Fixed.
> 
>> 2. The TCs
>>         L2L3VpnMcastProviderTunnelPointerType, and
>>         L2L3VpnMcastProviderTunnelPointer
>>     Are probably not required. The value of the RowPointer [rfc2579]
>>     object is ' the name of the instance of the first
>>                 accessible columnar object in the conceptual row'
>>     So the pointer will explicitly contain the name of the table.
>>     An auxilliary type object to indicate the table name is not
>>     necessary.
>>    [This is an oversight on my part. I should have noticed this earlier.]
> 
> These TCs were removed and related descriptions in other parts
> in the document were updated.
> 
>> Other Editorials:
>> P-2. Sec-1.
>> 1.   para-1 makes tedious reading. Could this be improved?
>>
>> 2.       "Border Gateway Protocol/ MultiProtocol Label Switching (BGP/MPLS)"
>>       The usage of the '/' here is unclear.
> 
> Updated.
> In the new revision, BGP/MPLS VPN is explained in para-1, and
> multicast support in BGP/MPLS Layer 2 and Layer 3 is explained in para-2
> separately.
> 
>> 3.       "and L3 VPNs.  Therefore, TCs and MOs defined"
>>       The context of the 'Therefore' is not clear.
> 
> Fixed. I removed the related sentence because it seemed not
> required already.
> 
>> 4.       "The are two type"
>>       Probably s/The/There/ ?
> 
> Fixed. Thank you for pointing it out.
> 
> -- tsuno
> 
> _______________________________________________
> BESS mailing list
> BESS@ietf.org
> https://www.ietf.org/mailman/listinfo/bess
>