Re: [bess] comment on draft-ietf-bess-evpn-yang

Hi,

Thanks for pointing out the correction.
I have changed it accordingly.

1.       I moved the control-word from evpn-pw yang model to evpn yang model.
And changed the type as Boolean.

2.       EVPN Instance Context is actually referring to evpn-instance; which is already part of EVPN yang model, so I am reverting the comments regarding that.

Below are my changes according to your comments:

    augment /pw:pseudowires/pw:pseudowire/pw:pw-type:
       +-:(evpn-pw)
          +-rw evpn-pw
             +-rw remote-id?   uint32
             +-rw local-id?    uint32
          +-rw mtu?                     uint32

   module: ietf-evpn
       +--rw evpn
          +--rw common
          |  +--rw (replication-type)?
          |     +--:(ingress-replication)
          |     |  +--rw ingress-replication?   boolean
          |     +--:(p2mp-replication)
          |        +--rw p2mp-replication?      boolean
          +--rw control-word?            Boolean
          +--rw evpn-instances
             +--rw evpn-instance* [name]
                +--rw name                                string
               +--rw evi?                                uint32
                +--rw pbb-parameters {evpn-pbb-params}?
                |  +--rw source-bmac?   yang:hex-string
                +--rw bgp-parameters

Yang changes:
     /* augments */

     augment "/pw:pseudowires/pw:pseudowire/pw:pw-type" {
       description "Augment for an L2VPN instance to add EVPN VPWS " +
                   "pseudowire";
       case evpn-pw {
         container evpn-pw {
           description "EVPN pseudowire";
           leaf remote-id {
             type uint32;
             description "Remote pseudowire ID";
           }
           leaf local-id {
             type uint32;
             description "Local pseudowire ID";
           }
         }
       }
    /*
    mtu (vpws-mtu)
    */
    leaf mtu {
      type uint32 {
        range "0..4294967295";
      }
      description
        "Configure MTU";
    }
  }

    /*
    control-word
    */
    leaf control-word {
      type boolean;
      default "true";
      description
        "Enable/Disable control-word";
    }
  }

Regards,
Lavanya Sundarraj.

From: Yu Tianpeng [mailto:yutianpeng.ietf@gmail.com]
Sent: Friday, February 22, 2019 1:03 AM
To: Lavanya Sundarraj <lavanya.sundarraj@ericsson.com>
Cc: bess@ietf.org; Debojyoti Guha <debojyoti.guha@ericsson.com>; C Gangadhara Reddy <c.gangadhara.reddy@ericsson.com>; Chundu Kotesh Babu <chundu.kotesh.babu@ericsson.com>; P Muthu Arul Mozhi <p.muthu.arul.mozhi@ericsson.com>; SatishKumar N Rodd <satishkumar.n.rodd@ericsson.com>
Subject: Re: [bess] Request for version update of draft-ietf-bess-evpn-yang

Hi,
Haven't got time to read through but had a quick look on what is newly added, there are couple of issues:
1. 7432 clearly defines usage of control word usage, cw is not sth dedicated to vpws I have to point out.
2. Type of control word should be boolean instead of empty.

Another one is I don't understand the meaning of newly added concext. Appreciate to clarify.
Thanks
Tim

On Thu, 21 Feb 2019, 13:28 Lavanya Sundarraj, <lavanya.sundarraj@ericsson.com<mailto:lavanya.sundarraj@ericsson.com>> wrote:
Hi,

Please find updated  EVPN yang model with evpn-pw attributes in the attachment.
This draft is to introduce EVPN-VPWS attributes :

o   Control-word

o   MTU

o   EVPN Instance Context

The new changes added in the existing EVPN yang model are highlighted.

Could you please review this draft and send your valuable comments.

Regards,
Lavanya Sundarraj.
_______________________________________________
BESS mailing list
BESS@ietf.org<mailto:BESS@ietf.org>
https://www.ietf.org/mailman/listinfo/bess