Re: [bess] comment on draft-ietf-bess-evpn-yang

Lavanya Sundarraj <lavanya.sundarraj@ericsson.com> Fri, 22 February 2019 06:38 UTC

Return-Path: <lavanya.sundarraj@ericsson.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F196212F1A5 for <bess@ietfa.amsl.com>; Thu, 21 Feb 2019 22:38:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.301
X-Spam-Level:
X-Spam-Status: No, score=-4.301 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=NEATdXEr; dkim=pass (1024-bit key) header.d=ericsson.com header.b=i0F6jl2W
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id llM_8weVGq5Q for <bess@ietfa.amsl.com>; Thu, 21 Feb 2019 22:38:46 -0800 (PST)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F245312D4E6 for <bess@ietf.org>; Thu, 21 Feb 2019 22:38:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1550817523; x=1553409523; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3N+rDZFkYJCmTZDI0/NbqGLbYhgXvtMD0j6DrakoWqs=; b=NEATdXErqXpAhdO89rdjpdxmdsrmPjqDkc1DPcVzrVvpgmyz2RLE0/fidpGGnbMq CaRPKaw83rxBqoZKAP19DjyQ+plMBLN4qyf9Y38mtgFy7XUpjSGPkaClmNjC9T6l g06aBdPcPwQiADs+oDnpOPFBtum3ye6Mdy2vSGoSzqY=;
X-AuditID: c1b4fb2d-2198b9e00000062f-09-5c6f98f3b2bd
Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 35.D6.01583.3F89F6C5; Fri, 22 Feb 2019 07:38:43 +0100 (CET)
Received: from ESESBMB502.ericsson.se (153.88.183.169) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 22 Feb 2019 07:38:43 +0100
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB502.ericsson.se (153.88.183.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 22 Feb 2019 07:38:43 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3N+rDZFkYJCmTZDI0/NbqGLbYhgXvtMD0j6DrakoWqs=; b=i0F6jl2WecIKrYsuwYYRKi5fOQVVRA94izvYAsiFghkh44iBQ5wRrce9C3zXvkvLuVMXbSaVsS5DJk3nlrK4BVG+0J/PvoBm7yRCWoNdisNFTPEscRCXyx2tms3i+7+KRWN2R7+NqE4aVJLFEcMD4/sqQcDS5yYaoOvt/3HaNfs=
Received: from VI1PR0701MB2846.eurprd07.prod.outlook.com (10.173.71.141) by VI1PR0701MB2367.eurprd07.prod.outlook.com (10.168.137.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1643.10; Fri, 22 Feb 2019 06:38:42 +0000
Received: from VI1PR0701MB2846.eurprd07.prod.outlook.com ([fe80::98d3:d069:2a86:e650]) by VI1PR0701MB2846.eurprd07.prod.outlook.com ([fe80::98d3:d069:2a86:e650%9]) with mapi id 15.20.1665.006; Fri, 22 Feb 2019 06:38:42 +0000
From: Lavanya Sundarraj <lavanya.sundarraj@ericsson.com>
To: Yu Tianpeng <yutianpeng.ietf@gmail.com>
CC: "bess@ietf.org" <bess@ietf.org>, Debojyoti Guha <debojyoti.guha@ericsson.com>, C Gangadhara Reddy <c.gangadhara.reddy@ericsson.com>, Chundu Kotesh Babu <chundu.kotesh.babu@ericsson.com>, P Muthu Arul Mozhi <p.muthu.arul.mozhi@ericsson.com>, SatishKumar N Rodd <satishkumar.n.rodd@ericsson.com>
Thread-Topic: [bess] comment on draft-ietf-bess-evpn-yang
Thread-Index: AdTKa/xW89CsyZIYTDa9D+5OVlbWWg==
Date: Fri, 22 Feb 2019 06:38:42 +0000
Message-ID: <VI1PR0701MB2846D0203167FC0D1E00DD758D7F0@VI1PR0701MB2846.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [125.16.213.150]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f11885f1-6e29-4fe0-1d16-08d6989062f2
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605104)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:VI1PR0701MB2367;
x-ms-traffictypediagnostic: VI1PR0701MB2367:
x-ms-exchange-purlcount: 1
x-microsoft-exchange-diagnostics: =?utf-8?B?MTtWSTFQUjA3MDFNQjIzNjc7MjM6c2Z2MUlhZm1UanJ6ZXVnQ3hXTTZsVUk5?= =?utf-8?B?TU0wTlJTSzFibzdhWXNTdGVBUHl1Y0hyQTBhT2RPOExWdkEzanRDa3d6UGpo?= =?utf-8?B?WVZqUnd5N2szL3IvNW0zZEdUZGliTDZVUmd3QUVSeWMyYjhSTTFVUmdqWFZX?= =?utf-8?B?QTVkYVZOWkRZZkMycFppdDlhKzByK2ExL293RSt2U1RSNDhvTUhWcmFKRjdM?= =?utf-8?B?TU1WYU5NWGxnLzVnUm1NSGZlQ1lhSEFQc2FiUkRtc1lFZ2RyUFpVbWh0dGc5?= =?utf-8?B?aXdoVWlPS0puTWNwU3ZQeWdyY09tVEV3dks2Qm1XYWdoME1JMmRqZjN4TStE?= =?utf-8?B?aDY5SFdEbTQ3WTVNYkxZdlBVeThPdVJRMWp1VXFGbDA4TzA1NzFPUUltbFpB?= =?utf-8?B?S3JNV3Q5TG9XTUZuaDNGMEo3cTBxQXExeFIwaWxMODhTWG1VWTF6NUtuSHRR?= =?utf-8?B?YkMzbWY1TkFDcTZGTVhnWXBkQWtzV3oyMGFxRnJZb3FWbmhocCtqaVlveS9J?= =?utf-8?B?bEJkUkFxVWNCUkdJdy80NWluQ01hMThIQThxaEh5TXdWY0hJam50ZmZ1aGJE?= =?utf-8?B?VW9neFRUTC9Xc2NYU21VemJ5VEozbWZiUkZWZ3JodkJYZzBmZ21ma0tHZCtl?= =?utf-8?B?MkhyT3BGclE5KzExaEhEMzZkUWViMzZSdjNuVklDc2lzREkvblNuWUtYM0hC?= =?utf-8?B?Z1NzZit3RjQ3eUdXU0hTSmFoVmd1MG9USW13UHZCaGtvK1B0eTVPQmE1a05o?= =?utf-8?B?akdFWFdRbXFuTmJ1cG9NZTNZbDFZdUNjdnI2QzFRQ0cvNHJQQy9sSkNVT202?= =?utf-8?B?dks3ZjZyNHBCL2dGNGV1ZTB5ZXRTeXNCZHQyeDhrTy9WdXptQUJMQS95UnlM?= =?utf-8?B?Z3lCZWNMSXZWUVZxL0VYTnNwbktyNU1QdTJsdzRNWjQ3dW96VWc0KzVaL3RO?= =?utf-8?B?Qkx0OWE5N3FKTFdOazhqOFNlYithVEhNN1VHRHczbWNDOXNUN0dqQ1VnUmIr?= =?utf-8?B?RmtXOWc4Y1ZCbW9ZS2tBUDJiQXZYRGxWTzh4alg3ZnhKT0VKSmNFZCswb1I2?= =?utf-8?B?dFNFWEFkcGZqQW83Mk5PL1NMSDNVclZza1NJdHBCTXltMjNBcmFOc1JRUWJR?= =?utf-8?B?eENPcGVRaWh5TlBwS2ZiZEhzd096WnpYUWwxY1JoSHRWbC9QakU4VzZkK29l?= =?utf-8?B?Ylk4eHpGMUZ3Ny9QRTUybDVGSklxYXcvUitpZk80d0lkSWk0NGdWKzJyRm0w?= =?utf-8?B?UlRzellYazNudmkrcGJGOGVpMFdCcFd3bHZ4Nlp3cEFOa09aNFRLcUEwN0do?= =?utf-8?B?R21HVjhvdHRaUmRVMGprVUJER0owYjVWRnBQL0dYalVTbUR1czVwbW1STDc3?= =?utf-8?B?MWJIVnpzM1ZXdEU1Z3NrbnN5TFg1b1Z1SnNGaU5XeTBWNW5ZaE1EM1hCSXI5?= =?utf-8?B?b2szQ2s1VmY5dTBac2lTK0UyWGlRcVJHcGVYdHlpcW45ZGpLM3c1UmozL1lh?= =?utf-8?B?OVNNRnJQZmQ1UUxNYnNtL29FcmIrU3VZcnJ1bHVzK0ovdDQ0KzFVb0RkZWwz?= =?utf-8?B?bzhBZGJHWkViUXpFdzBiZThMZWhmTy9EMlpTNHM1dXRMNnpWdDZZWXlLSElq?= =?utf-8?B?Q0s2QVd1V2lralcwYWtQMmVTemtlYVAwdm5hOEVKaG5sT01SUnRlaU44ejlT?= =?utf-8?B?RnBPNkkrN2xVRWlpUHF3eXRrai80STBmZFV6K21xRnl6OC9pZjR0Ung5dzlF?= =?utf-8?B?RWUxK3ZHalZIY1B4ZWsrcnErVmI3LzFicFVXWWdGelBtY2NRd045dnZ6VXAw?= =?utf-8?B?QTRLQ1FUR2V1ZWRwZGFLY2NtMHMzclU4VUZKYmowT080ZllzRzUvSXVncUVL?= =?utf-8?Q?AZAuB6vDQVV5s=3D?=
x-microsoft-antispam-prvs: <VI1PR0701MB2367390FCB75372DD1856B6D8D7F0@VI1PR0701MB2367.eurprd07.prod.outlook.com>
x-forefront-prvs: 09565527D6
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39860400002)(376002)(136003)(366004)(189003)(199004)(102836004)(33656002)(486006)(6506007)(53546011)(229853002)(68736007)(44832011)(6436002)(476003)(9686003)(25786009)(6916009)(55016002)(236005)(54896002)(6306002)(4326008)(6346003)(99286004)(55236004)(54906003)(3846002)(2906002)(7696005)(66066001)(6116002)(790700001)(97736004)(26005)(105586002)(186003)(86362001)(7736002)(9326002)(74316002)(8676002)(316002)(81156014)(81166006)(106356001)(256004)(478600001)(14444005)(966005)(5024004)(6246003)(53936002)(107886003)(5660300002)(71190400001)(71200400001)(606006)(8936002)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0701MB2367; H:VI1PR0701MB2846.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=lavanya.sundarraj@ericsson.com;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: cQE32RUo5YeR8M2NOO7mPw1EV20pM90k6jmhpT9tA85j4XO7kKcNlQNDvpl2CbcrObGod6R259eATGkwwe/aUnoKFIKguNaXO7HZv75ybnmweQNtTaZUS8RCia/HXSlvpdyrWHbHzgDvb7gP2K9T/EzxRrtrDeP+JOx1XmxajApLruNykk1OSifk+SByLoMSVPy9sLJ3mCELVk4azng3DHdKOnwEcRZXx20KC9juIp/LwdjzU/VAaOk6ISanru0/uqgcGkiZ+v5QkL9I2mx+YPjm+OVPbC+/29c+cDlrxyLPBfioWoOiBC2Ia6Fdx0if3qTof6aJUnLe/qRYYoiXLphXVRsXeMLocpY9geMRLt69Mz34mdwBb5bVG0P34SeaQqlLinxliCwOmAOGix51mnEZUeTcCI6ZZnwrJ2EficY=
Content-Type: multipart/alternative; boundary="_000_VI1PR0701MB2846D0203167FC0D1E00DD758D7F0VI1PR0701MB2846_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f11885f1-6e29-4fe0-1d16-08d6989062f2
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2019 06:38:42.0219 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0701MB2367
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02SfyyUcRzH+z7Pc3eP4/L1dPKZfmxumvIz5Q+/q/VH/qjW0lZr17jyhPw4 u0ek1naryVBRjtwtwzpjYmdioUxIEZJiRVroNGH1h0RJdXdfbf57fd6f9+fzfX+2L0tz1SJX Nj45ldckqxIVYimjP/Ew3We+WK3c+bfVO7DquZ4O/Nr9DO2lIpoNHyQRRuNP6gh1UhoawyfG p/Eav/BoaVzJyLA45UkLdSFvTou0yFhP5SA7FnAAdC69RDlIynL4KYI6s05Cih8I3i+10VYX h40UVBYetzYYnE9DqylTRFzFFEwaS8Wk+IzAoBtlrCNiHAhlY2ZkZTn2gpm/BbYJGj+gYHH8 ju31DTgIapvzaWIKhuqxfoawLyxWzImtzOBt0D7bY9NlOBrG+vQiKyO8ERZf1Nj20NgFRs2l qxdhMD4eoAk7w5dPf0SEFTBYc09CeAu8Ls21hGMtfAgWyg8T2Yyg3IQJe8PARCND2BW6B7ts +QG/4aBiUrvaUMPo7IiY8GYoutIrJiadGAyrQTnMQ2VtJiKhVfD99gQiA1uh+sYEk4+8DGtu MFgy0Za92l9yg+1kJ+jRmxki7wBTix9xu4Eud0JCeDtk3i2RrNXLkKQaOQu8ICTF7trty2vi zwiCOtk3mU+tR5Yf1N6w7NOE7s/u60CYRQoHGaVTKzmRKk3ISOpAwNIKuSw0zSLJYlQZF3mN OkpzPpEXOtAmllG4yH5zTkoOx6pS+QSeT+E1/7sUa+eqRZxPWFjBYlnRzVd1MQ72bzs9u2Kq wqOHslZO2zv3R/WmZee1pUYkTA11q6bdlxwLQtTj1P4693fyqgBq3S2sPPVx/mqQie5MWlZU NR7NPnC9wTV/vcOK/qw80je4bzr+8ow0KHLPlMewW4+/h+O3Y2WPrl1KPxiSZWw6t+AfJy1U KBghTuXvSWsE1T/BxUqQPQMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/EfCwMAtqvmntcG8FQRPvivAXGac>
X-Mailman-Approved-At: Fri, 22 Feb 2019 00:52:36 -0800
Subject: Re: [bess] comment on draft-ietf-bess-evpn-yang
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Feb 2019 06:38:50 -0000

Hi,

Thanks for pointing out the correction.
I have changed it accordingly.


1.       I moved the control-word from evpn-pw yang model to evpn yang model.
And changed the type as Boolean.


2.       EVPN Instance Context is actually referring to evpn-instance; which is already part of EVPN yang model, so I am reverting the comments regarding that.

Below are my changes according to your comments:

    augment /pw:pseudowires/pw:pseudowire/pw:pw-type:
       +-:(evpn-pw)
          +-rw evpn-pw
             +-rw remote-id?   uint32
             +-rw local-id?    uint32
          +-rw mtu?                     uint32



   module: ietf-evpn
       +--rw evpn
          +--rw common
          |  +--rw (replication-type)?
          |     +--:(ingress-replication)
          |     |  +--rw ingress-replication?   boolean
          |     +--:(p2mp-replication)
          |        +--rw p2mp-replication?      boolean
          +--rw control-word?            Boolean
          +--rw evpn-instances
             +--rw evpn-instance* [name]
                +--rw name                                string
               +--rw evi?                                uint32
                +--rw pbb-parameters {evpn-pbb-params}?
                |  +--rw source-bmac?   yang:hex-string
                +--rw bgp-parameters

Yang changes:
     /* augments */

     augment "/pw:pseudowires/pw:pseudowire/pw:pw-type" {
       description "Augment for an L2VPN instance to add EVPN VPWS " +
                   "pseudowire";
       case evpn-pw {
         container evpn-pw {
           description "EVPN pseudowire";
           leaf remote-id {
             type uint32;
             description "Remote pseudowire ID";
           }
           leaf local-id {
             type uint32;
             description "Local pseudowire ID";
           }
         }
       }
    /*
    mtu (vpws-mtu)
    */
    leaf mtu {
      type uint32 {
        range "0..4294967295";
      }
      description
        "Configure MTU";
    }
  }



    /*
    control-word
    */
    leaf control-word {
      type boolean;
      default "true";
      description
        "Enable/Disable control-word";
    }
  }

Regards,
Lavanya Sundarraj.

From: Yu Tianpeng [mailto:yutianpeng.ietf@gmail.com]
Sent: Friday, February 22, 2019 1:03 AM
To: Lavanya Sundarraj <lavanya.sundarraj@ericsson.com>
Cc: bess@ietf.org; Debojyoti Guha <debojyoti.guha@ericsson.com>om>; C Gangadhara Reddy <c.gangadhara.reddy@ericsson.com>om>; Chundu Kotesh Babu <chundu.kotesh.babu@ericsson.com>om>; P Muthu Arul Mozhi <p.muthu.arul.mozhi@ericsson.com>om>; SatishKumar N Rodd <satishkumar.n.rodd@ericsson.com>
Subject: Re: [bess] Request for version update of draft-ietf-bess-evpn-yang

Hi,
Haven't got time to read through but had a quick look on what is newly added, there are couple of issues:
1. 7432 clearly defines usage of control word usage, cw is not sth dedicated to vpws I have to point out.
2. Type of control word should be boolean instead of empty.

Another one is I don't understand the meaning of newly added concext. Appreciate to clarify.
Thanks
Tim

On Thu, 21 Feb 2019, 13:28 Lavanya Sundarraj, <lavanya.sundarraj@ericsson.com<mailto:lavanya.sundarraj@ericsson.com>> wrote:
Hi,

Please find updated  EVPN yang model with evpn-pw attributes in the attachment.
This draft is to introduce EVPN-VPWS attributes :

o   Control-word

o   MTU

o   EVPN Instance Context

The new changes added in the existing EVPN yang model are highlighted.

Could you please review this draft and send your valuable comments.

Regards,
Lavanya Sundarraj.
_______________________________________________
BESS mailing list
BESS@ietf.org<mailto:BESS@ietf.org>
https://www.ietf.org/mailman/listinfo/bess