Re: [bess] Opsdir last call review of draft-ietf-bess-evpn-optimized-ir-09
"Rabadan, Jorge (Nokia - US/Mountain View)" <jorge.rabadan@nokia.com> Wed, 17 November 2021 09:11 UTC
Return-Path: <jorge.rabadan@nokia.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 77DEF3A0B80; Wed, 17 Nov 2021 01:11:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.601
X-Spam-Level:
X-Spam-Status: No, score=-2.601 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.701, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YAG-an5G0jKP; Wed, 17 Nov 2021 01:11:07 -0800 (PST)
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2126.outbound.protection.outlook.com [40.107.220.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 337353A0B35; Wed, 17 Nov 2021 01:11:07 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oL7VZaEOkjvO0xmUhQWkSb+k9kvQjyRUp5paWMMPrs7DdksO3EqBBbE75gCFg3d6q3+4kKtDLcR/6d1qg+5O7rPeMHIS19gnM2jCjapB+FjouUj00ZfiOYf6gy/NPBahwd4UjJlh+/vVtKDhmy2Zdqoa2zrGW+/vkTxDLrQDrWIaaFaJ+DdHpukqsIUjnWYD7nNOMZLqnVk80qMvN2c9trGPEh1iLuaP33iCqilY3hckQuuRkgqVKctMEkCVdc5tBckAsCDhiFu7qS4esMZKc1oe+rJQ6p5EEh1XO+3u0vqZuLxxYaSPfVxPDL6e4pRPUgpHCvdjEsOL5a1d/gX05w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L57Batmp0eV0TUGjJ0naXIUL7s08d7yukWvLjf1zSaI=; b=eP4ZISZa7ArvpRRH6GPPxhoWdiO9pHME+QMB6UxVIGWjsFiWYVZ9AghsOnkPEfR19Rg1x6lF/i8n0652DB6zD3Z8rg6NCVfvzB4mbI0l5rJWQXaJV6bxBJ9ZOQqPBj08IAnl8rjqaOq3R7ULYuLvYoWCg53WflERaUJqz0fTHqHs66YsHXv/uu8bMJ48vyoKpQvD/4bkMkGiyxitB4U4oHKRJPMtUV6S5+OXdzIXDpuWEGWnEeFmKGJUD2N8Y4jLDadcLAboizIq0SXz4XizHR969Cw0UROy3f9hjgj4+HFu7SVBN8vsh3Qba8yDiv/jAzTfdva5bLEsfe2gu2H+kA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L57Batmp0eV0TUGjJ0naXIUL7s08d7yukWvLjf1zSaI=; b=gzL+WHEjfK843s3fEpYb+pn34l12jGGdyA/dNeSfo4yUMUXSBQWse0S/gJs8Xs+U/Rvbi0m9qJ+MoxYyS0A0SWh39Ieova1OnkTWUZ3dcZqySIkzljThh4J0Hz5jaieGhSPGXsHORcoHUTBpfMae51dm8Wj0Td5NZXPARwr8qyU=
Received: from BY3PR08MB7060.namprd08.prod.outlook.com (2603:10b6:a03:36d::19) by BYAPR08MB5254.namprd08.prod.outlook.com (2603:10b6:a03:6b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.19; Wed, 17 Nov 2021 09:11:05 +0000
Received: from BY3PR08MB7060.namprd08.prod.outlook.com ([fe80::c481:f856:9121:e]) by BY3PR08MB7060.namprd08.prod.outlook.com ([fe80::c481:f856:9121:e%7]) with mapi id 15.20.4669.022; Wed, 17 Nov 2021 09:11:05 +0000
From: "Rabadan, Jorge (Nokia - US/Mountain View)" <jorge.rabadan@nokia.com>
To: Tim Chown <tim.chown@jisc.ac.uk>, "ops-dir@ietf.org" <ops-dir@ietf.org>
CC: "bess@ietf.org" <bess@ietf.org>, "draft-ietf-bess-evpn-optimized-ir.all@ietf.org" <draft-ietf-bess-evpn-optimized-ir.all@ietf.org>, "last-call@ietf.org" <last-call@ietf.org>
Thread-Topic: Opsdir last call review of draft-ietf-bess-evpn-optimized-ir-09
Thread-Index: AQHXzk0kb9mHvgOTa0uTQMqoAMstoKwHgc7d
Date: Wed, 17 Nov 2021 09:11:04 +0000
Message-ID: <BY3PR08MB7060A2C162ABB86BBACBCEFBF79A9@BY3PR08MB7060.namprd08.prod.outlook.com>
References: <163568086646.26180.9041625828423545590@ietfa.amsl.com>
In-Reply-To: <163568086646.26180.9041625828423545590@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nokia.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: df1eed98-2fc1-4aa8-c7ce-08d9a9aa2f26
x-ms-traffictypediagnostic: BYAPR08MB5254:
x-microsoft-antispam-prvs: <BYAPR08MB52547C7DD6B3A0463E84D176F79A9@BYAPR08MB5254.namprd08.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: ZemIH1Tom5akh97yFTqIV5pQ8rt4IQn32VvMPWC9AGsWEnBJnkG/RmnWA1vkaTmJZjQ5Ak9EUy9Sftfzw5AYv4WslZoicnoD/s10fPBAsq+IRBzGnpkG7ULbb0pWpxk4Hgr5NAC9PJLJa1pqR9fRW968WM20A5CnGD65u6Qfuw9FvF+HMfd7jijCkYZrFUYPnbUtPSw1VK/VEI6WkT3awmpDhXsS7iqFayWDH26QxD0vqitZg2GxmkHso4x0lr215TNTbzeVelby6SBn0OTB97gCLUYmx9x6bTjL2YUWSi5ib7TXC7pUAW0W2Hs5LTyR9IqhY7jk+XWeQRn6PPcRCLRulXm4gO8J5Gv0tkYzL8YIef2077Ep3KytbNQA44UQDPDRkiIc6VOakXb+qWiH5Ma6kTUu0pPnYajcJ7EBKoAXVt35Hs/ZKoHmUS9g/j/+Ou/Dwqhxnc9ZV8kUvlqcN3e4QrzgkqwbQ2xBWGWyl9q9YLky0SeRRb9c/deEYBMgfThQSjfchfQ9nZAJY3cxZVWBffrpYzHPfdTXgpEVNfWtCLeajsJ+QUq2mf5XN2Ld6PimjLwhRE1Ew3gFpgi+NuTht7JnKPwD1AdmFD5J0EwqAvRyaJxLT/3HJMYxnE4O7Nx9xAZnIroTzNnojiLNMC5YlT7W2jgWDcJyYjYujq/wcthr639wqs7mKu4OPPB0s9vuBk7TzZPmI7DbJkHrcQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY3PR08MB7060.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(9686003)(33656002)(122000001)(508600001)(38100700002)(76116006)(38070700005)(91956017)(4326008)(2906002)(26005)(5660300002)(55016002)(52536014)(83380400001)(186003)(86362001)(66476007)(66946007)(316002)(110136005)(54906003)(8936002)(8676002)(66446008)(53546011)(6506007)(9326002)(7696005)(71200400001)(66556008)(64756008)(82960400001); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: J1M+1GC3eQq/dco4zpg//kvuIUpXEGWIBTmCzzDIinXPUL+SEG3T9KBEYnKxtkWUqclBK+jUx4+H7zlTHOG8oNzQVjEQPxqCSTtwrwf8HVAO/mEAR6VgvAlijb84IuCA5gytQv4FdY3QLpj+uLrbuDZVxnRhpSHXOnhjxaHmPgpEetxgoy4cpzjiMWDfMcMi5OQQnJ0UzKEeMhw1L9NH0FNhl7fTfIKWUhpzefqMHgVB8A8z10RyUqAsDhQAQVSiVgHjBaCIA79eYF5QETyAkG2vuuDIsjv+IibNAqUU8EPyWaExJw0MYugAUIRbMyXkfyLEBjmxpDU6yLPClv7SwXDfFuKv88gE/66gwOC1btEz4hn/rVkEr7NegI/xW0ajpqy0JvIebXJCBiUERk/Qq0Y++dTCaQc8npqV+lo2OQbGtxToLXW/MO5yfHjpxqz3VQwAq+BK6vhYsVMIzjBb/o0qrVRfI53dh745EOTw6cM8RFdcsixm6G92uv0kmr6Ou6fWFCbZQemuGV/ZzWEGIsw2/shAga3xaL+bl6t+C1s9FFqkmwRc5Fi/mzATa95AJGcM8SF76eEf/z/QUcj3wqDLGV1fPxpuPlAP2s4tlu3JrjItpRkesP67ncvuHEKWO44LPz20NmnOB4cWZO7hpVAuNnYeVl5Xbm+6pppQ6eY2fGzVZulRf55PYPB2DiUj1cpsByxmswVbw0Bwh/jS/A4QlsgKUQZ1JfxmXIdJc/aSWVSCucAF0d86i+646NrAbsSoLvzBvbkzTq8gu8D0bX90J6rT+vLkRtNZH5kT68M3b8+a7SXhAE/LZlUIDTtBj2I5F/BtSetCWEqFN11jp3hOwspqltk9SSCPHe2ltBqAXCEa3oPTVU9eFc+CXHhZ5O93XXOpitJscIfay6u5bvivu9EBL9rSop2V9YChBqikPBDLcri8Oje3fiCNhSql2vDbJ20U9mTEGi4VPRG5UeF8gsXMmn0aXkYHG/IWAAXxEO+owIGBh20it5/y+opCiLyG8nbTcB0S9LNNz8l6fzorZosubjNknwQsbDWITr4wzmKQJqKbihG3KSxOtsNijzvZ/xgCAmDOhH6HVxzKxoQDtu46hAVW79Y4VmXX+JkRqpnQOYjTekHtqe3H/3Z0xhfv4A+PkiGDRPdvL95dCZaeDWt7XO9nlnRlX5Tm+RmgrbDpmkUiVpVFCNxo7H4ZNDoBmQQggjivMuhzf8b4by+EHQeDUm58gEuRzer8BxBrMvSLqPft5sVaET8ZjCyqzJH651caGg1WoqHVk735akdprKAv0rbn9+jV61F+KSwzeX5Ip4KMARfwU/T/uVGDvBbrXs/li/X02AHmG9mMVT0frPvt82i8Vcoh7zKqaLtfdpaoweI/40/k/10VUu80TDrZ5GVbcwCn7ZCdlwKAk5vx9/iuBQc/IyzUEBSN8qabuhVS9htu1gGBxiOR5xZVtjZzz8z/nT9dZwipW2FJuJhGLweuN6wWf/MlIzS2jwD29MY2OuLt8Vj1OXkqtWV3CqPsuMcg6Hz5Hk8nBLJ5QlOtLljDqUVN9DHpQCxLRqMtBY7Y51g8laGIFOO1CoQyws9bBgQEh7//+fbFDXJc37sPXaBzSHUAl/S2nVxpFbN1+IUqMCcg56PXce/r4i3A
Content-Type: multipart/alternative; boundary="_000_BY3PR08MB7060A2C162ABB86BBACBCEFBF79A9BY3PR08MB7060namp_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR08MB7060.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df1eed98-2fc1-4aa8-c7ce-08d9a9aa2f26
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2021 09:11:04.9275 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2UXf5PXUqtUePRXgawDt/50sT204kPX9oVzTfg0F4WUCvE8pTFuHzGou8v7wHcyF7sUXaS8evtNoJf5QBC0hnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR08MB5254
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/R9BXR2JqFYJ3pOnsGfjD77K0iJs>
Subject: Re: [bess] Opsdir last call review of draft-ietf-bess-evpn-optimized-ir-09
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Nov 2021 09:11:17 -0000
Hi Tim, Thank you very much for your review. Version 11 should address all your comments. Please see in-line with [jorge]. Thanks. Jorge From: Tim Chown via Datatracker <noreply@ietf.org> Date: Sunday, October 31, 2021 at 12:47 PM To: ops-dir@ietf.org <ops-dir@ietf.org> Cc: bess@ietf.org <bess@ietf.org>, draft-ietf-bess-evpn-optimized-ir.all@ietf.org <draft-ietf-bess-evpn-optimized-ir.all@ietf.org>, last-call@ietf.org <last-call@ietf.org> Subject: Opsdir last call review of draft-ietf-bess-evpn-optimized-ir-09 Reviewer: Tim Chown Review result: Has Issues Hi, I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review. Document editors and WG chairs should treat these comments just like any other last call comments. This draft describes a solution to optimise the efficient use of Ingress Replication in (IR) in Network Virtualisation Overlay (NVO) networks. The document is close to being Ready for publication. Its technical content and proposal seems sound, and useful, and the quality of writing good, but there is room for improvement and some extra clarity, particularly around terminology and use of RFC2119 language. General comments There are many, many, many acronyms in this document. This area is not one I have a detailed knowledge of, so I found myself rechecking the terminology several times as I read through the document. It would help if the terminology section was presented in alphabetic order, or at least an order where something (like BD) is explained in advance if its first use elsewhere (for BD, in IR forwarding mode). [jorge] addressed in the latest versions, thx I understand the rationale for use of IR, where PIM is not implemented. A number of research and education networks are removing classic PIM from their backbones - there is surprisingly little multicast traffic in NREN networks, and the only significant application on the UK NREN network is EUMETSAT. While I am familiar with PIM (and am co-author of RFC8815) I am less familiar with IR so a little more introduction or pointers on it would be useful. I note also neither PIM nor IR feature in the references section. [jorge] added explanation in section 1, please check version 11 It’s not clear to me why BM traffic is split out from U traffic. Perhaps the rationale could be more explicit. [jorge] added this in the introduction: “The Assisted-Replication procedures do not impact unknown unicast traffic, which follows the same forwarding procedures as known unicast traffic so that packet re-ordering does not occur.” The document, as a potential PS, makes use of RFC2119 language. However, its use seems inconsistent to me. In many places, the document says so-and-so will do something, and it’s not clear if that’s as a result of something previously defined via a MUST or SHOULD, or whether it should be a MUST or a SHOULD. A more specific example is page 8, where it says “Originating Router’s IP address MUST be set to an IP address of the PE that should be common…” - is that “should” really a “MUST”, a “SHOULD”, or do you mean “should”? It reads strangely. Another example follows on page 9, where the text says “its fields are set as follows” and then of the four points below vary in style, one says “is set to”, one says “MUST include” - do you mean “is set to” or “MUST” be set to”, or? And then just further down the page “its use SHOULD be an administrative choice”, which also reads oddly to me (and in section 7 the same choice is a plain “is an”). Page 10, “SHALL follow” - do you mean MUST be configured to follow, or will follow anyway because of the routing in place? Or 9.1(d), “will process” or “MUST process”. As I read through the document, there are many examples like this; a review of consistency might be a useful exercise. [jorge] the use of the normative language has been reviewed in version 10 and 11. Hope this addresses your comment. Nits: The quality of writing is good; I saw very few grammatical nits. In the terminology, delete “switch”, or say ToR switch. [jorge] done, thx p.19 “will forward the BM”, missing “it”. [jorge] done, thx The document often says “BM (Broadcast and Multicast)”, but sometimes “BM”. Just “BM” is fine as it is defined after its first use. [jorge] done, thx -- Tim
- [bess] Opsdir last call review of draft-ietf-bess… Tim Chown via Datatracker
- Re: [bess] Opsdir last call review of draft-ietf-… Rabadan, Jorge (Nokia - US/Mountain View)