[bess] Re: Éric Vyncke's No Objection on draft-ietf-bess-evpn-fast-df-recovery-09: (with COMMENT)

Luc André Burdet <laburdet.ietf@gmail.com> Mon, 19 August 2024 21:34 UTC

Return-Path: <laburdet.ietf@gmail.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EEF28C19ECB8; Mon, 19 Aug 2024 14:34:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.104
X-Spam-Level:
X-Spam-Status: No, score=-2.104 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rj3d7kMdHXYi; Mon, 19 Aug 2024 14:34:35 -0700 (PDT)
Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 218BEC18DBB6; Mon, 19 Aug 2024 14:34:35 -0700 (PDT)
Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-6bf99fee82aso9385756d6.2; Mon, 19 Aug 2024 14:34:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724103274; x=1724708074; darn=ietf.org; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=dUldZ2Lr2+XnIRybj2LLeXHZOWDkM6ffho+lrMSlWRo=; b=SBfEMppiaroDfmqpr2u4BGz5By4Fr8GFa51gaQCvHw1VEOjca8Ftcbo83o8tzK0vBL ako3gh3cQjrwRJD1Wj/qAEBeWo/tcXRhoUSXpGNJhaCBKR+0RENAGg3ScBoc8tk74GXz NaR4h0v5E5Wz6QtpxsBYQKbvDlYOLvEfrdmIc07hPj3lxA0xKFpcvQHW6T5i327GrR/U Eg7s9sqQ3cu4pwzPRctr9SaXNzPHzXnZwVZJd/MCsbVomlkOhfq2Prm2KT6vNnIlVYcQ zIX3Iilp9vhfD4xC7eKIuxdNBYBm1vZ+9gJ8K5GRLHIvybplOvzi5/pNtMi6ADGy1ZOT iB1w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724103274; x=1724708074; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dUldZ2Lr2+XnIRybj2LLeXHZOWDkM6ffho+lrMSlWRo=; b=G1hhJl2D7nLlFE3qCYnuTmJo2I+lqmcOxYWAl8eCPs63Wp7O1IXbqlh6lMWubSa7Cp iQGH6owt96aQBZt/yVploc/icWq7CSFeLsIaDaJzq6eS3A9v/GpLiK95E0KCUhaoGzmi KsqhkRdZjkOD8c6k6D/a7IC3BqdsaT4zeWGBjeE7kUwRN7GugIRrCt5BgTePp9Bg9JdU DogPhsKB9qKyz5q1TmoOknM2uXqSXh7+t19JTJI/R5N7ngmUqH7OaziUQewl90dWLdAw fgxWcQrWXBPYWhyHNPh16hSNahFI/1EjF81SXU8g6902dxHHsf7rVivRHSEENJ/Ey5Jf xqCg==
X-Forwarded-Encrypted: i=1; AJvYcCV+zdzomAYyYBLdJRM20m1DJXh/381/HeeqL8AR5pn76XjrEsyMSMM6GXeHqHZEHhZLs+5trg==@ietf.org, AJvYcCVI7pi70uJv7critTwdXXRqL7+wyAN77yblHlTxS1iRqHL6JoJsCi0+LBIlenwgYM7K3Z7+eg==@ietf.org, AJvYcCVNdD2ibqGHGwpoDxz30C0WctwhnNNr/OggPT+mWVmCf39m412WHMoQmDDzioscyhx6Tu3637alYdaLaA==@ietf.org
X-Gm-Message-State: AOJu0YwhmjoVvPezavdF/dAMWDGC6CYvCpjGenoOS7j4zmtoMWKVI6N4 s1krDWDjXIINa/6QPHsQ2HxBqFlMQPUmKNdzj7K3hknXeQvCfAH2
X-Google-Smtp-Source: AGHT+IGWDrFZO6VBJYe02Hg39gCTRw4or9PkYhOzpbH6uOgTvkelP0j9idK6FZHLsteUBBQvwZj5Cw==
X-Received: by 2002:a05:6214:3388:b0:6bd:83c3:ba1 with SMTP id 6a1803df08f44-6bf7ce915camr112244856d6.52.1724103273809; Mon, 19 Aug 2024 14:34:33 -0700 (PDT)
Received: from CH0PR14MB4962.namprd14.prod.outlook.com ([2603:1036:304:80d::5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bf6fec8186sm46267276d6.83.2024.08.19.14.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 14:34:33 -0700 (PDT)
From: Luc André Burdet <laburdet.ietf@gmail.com>
To: Éric Vyncke <evyncke@cisco.com>, The IESG <iesg@ietf.org>
Thread-Topic: [bess] Éric Vyncke's No Objection on draft-ietf-bess-evpn-fast-df-recovery-09: (with COMMENT)
Thread-Index: ATUyOTUyAywqeAn1BHTtcH3Ubja3gcuAilp+
X-MS-Exchange-MessageSentRepresentingType: 1
Date: Mon, 19 Aug 2024 21:34:32 +0000
Message-ID: <CH0PR14MB4962E13460051371A8492BDAAF8C2@CH0PR14MB4962.namprd14.prod.outlook.com>
References: <172405652791.1905156.11291737598298593905@dt-datatracker-6df4c9dcf5-t2x2k>
In-Reply-To: <172405652791.1905156.11291737598298593905@dt-datatracker-6df4c9dcf5-t2x2k>
Accept-Language: en-US
Content-Language: en-CA
X-MS-Has-Attach:
X-MS-Exchange-Organization-SCL: -1
X-MS-TNEF-Correlator:
X-MS-Exchange-Organization-RecordReviewCfmType: 0
Content-Type: multipart/alternative; boundary="_000_CH0PR14MB4962E13460051371A8492BDAAF8C2CH0PR14MB4962namp_"
MIME-Version: 1.0
Message-ID-Hash: 7OHCELMZM4KABS74M57MUIHBOLX3OHI4
X-Message-ID-Hash: 7OHCELMZM4KABS74M57MUIHBOLX3OHI4
X-MailFrom: laburdet.ietf@gmail.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-bess.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: "draft-ietf-bess-evpn-fast-df-recovery@ietf.org" <draft-ietf-bess-evpn-fast-df-recovery@ietf.org>, "bess-chairs@ietf.org" <bess-chairs@ietf.org>, "bess@ietf.org" <bess@ietf.org>, "matthew.bocci@nokia.com" <matthew.bocci@nokia.com>, "dthaler1968@gmail.com" <dthaler1968@gmail.com>, "tte@cs.fau.de" <tte@cs.fau.de>
X-Mailman-Version: 3.3.9rc4
Precedence: list
Subject: [bess] Re: Éric Vyncke's No Objection on draft-ietf-bess-evpn-fast-df-recovery-09: (with COMMENT)
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/SpfR0_6fp_PAM78iKz-tuMJbBTA>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Owner: <mailto:bess-owner@ietf.org>
List-Post: <mailto:bess@ietf.org>
List-Subscribe: <mailto:bess-join@ietf.org>
List-Unsubscribe: <mailto:bess-leave@ietf.org>

Hi Éric,

Thank you for the review.
I have updated the skew from “adding negative value” in -10, this has been pointed out by Toerless also as being clunky


Regards,
Luc André

Luc André Burdet |  Cisco  |  laburdet.ietf@gmail.com  |  Tel: +1 613 254 4814


From: Éric Vyncke via Datatracker <noreply@ietf.org>
Date: Monday, August 19, 2024 at 04:36
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-bess-evpn-fast-df-recovery@ietf.org <draft-ietf-bess-evpn-fast-df-recovery@ietf.org>, bess-chairs@ietf.org <bess-chairs@ietf.org>, bess@ietf.org <bess@ietf.org>, matthew.bocci@nokia.com <matthew.bocci@nokia.com>, dthaler1968@gmail.com <dthaler1968@gmail.com>, tte@cs.fau.de <tte@cs.fau.de>
Subject: [bess] Éric Vyncke's No Objection on draft-ietf-bess-evpn-fast-df-recovery-09: (with COMMENT)
Éric Vyncke has entered the following ballot position for
draft-ietf-bess-evpn-fast-df-recovery-09: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/
for more information about how to handle DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-bess-evpn-fast-df-recovery/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------


# Éric Vyncke, INT AD, comments for draft-ietf-bess-evpn-fast-df-recovery-09

Thank you for the work put into this document.

Please find below some non-blocking COMMENT points (but replies would be
appreciated even if only for my own education), and some nits.

Special thanks to Matthew Bocci for the shepherd's detailed write-up including
the WG consensus and the justification of the intended status.

Other thanks to Dave Thaler, the Internet directorate reviewer, and to Toerless
Eckert, the IoT directorate reviewer, please consider their reviews as if they
were mine:
https://datatracker.ietf.org/doc/review-ietf-bess-evpn-fast-df-recovery-09-intdir-telechat-thaler-2024-08-13/
(I haven't read any public reaction of the authors)
https://datatracker.ietf.org/doc/review-ietf-bess-evpn-fast-df-recovery-09-iotdir-telechat-eckert-2024-08-14/
(I haven't read any public reaction of the authors)

I hope that this review helps to improve the document,

Regards,

-éric

# COMMENTS (non-blocking)

## Section 1.3

PE, DF, HRW acronym are already expanded before ;-)

Suggest defining "redundancy group".

## Section 2

`add a skew (default = -10ms)` while this is valid, isn't it a little weird to
add a negative value ?

Should "service carving" be explained/defined ? Perhaps via a reference to
another RFC ?

## Section 2.1

`Era 0 is assumed as of the writing of this document` does not age well,
strongly suggesting to use "Era 0 is assumed in this specification".

# NITS (non-blocking / cosmetic)

s/Layer2/layer-2/
s/Layer 2/layer-2/ when used as an adjective.
"i.e." should always be followed by a comma.
s/insterted/inserted/ suggest using a spell checker ;-)



_______________________________________________
BESS mailing list -- bess@ietf.org
To unsubscribe send an email to bess-leave@ietf.org