[bess] Some YANG validator error info about draft-ietf-bess-l3vpn-yang

"Wanghaibo (Rainsword)" <rainsword.wang@huawei.com> Tue, 14 September 2021 12:32 UTC

Return-Path: <rainsword.wang@huawei.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B1DB23A1977; Tue, 14 Sep 2021 05:32:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hqxMoUnozn39; Tue, 14 Sep 2021 05:32:53 -0700 (PDT)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C52D83A1979; Tue, 14 Sep 2021 05:32:52 -0700 (PDT)
Received: from fraeml741-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4H82kS5yqhz67stb; Tue, 14 Sep 2021 20:30:40 +0800 (CST)
Received: from kwepeml500002.china.huawei.com (7.221.188.128) by fraeml741-chm.china.huawei.com (10.206.15.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Tue, 14 Sep 2021 14:32:48 +0200
Received: from kwepeml500001.china.huawei.com (7.221.188.162) by kwepeml500002.china.huawei.com (7.221.188.128) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Tue, 14 Sep 2021 20:32:46 +0800
Received: from kwepeml500001.china.huawei.com ([7.221.188.162]) by kwepeml500001.china.huawei.com ([7.221.188.162]) with mapi id 15.01.2308.008; Tue, 14 Sep 2021 20:32:46 +0800
From: "Wanghaibo (Rainsword)" <rainsword.wang@huawei.com>
To: "draft-ietf-bess-l3vpn-yang@ietf.org" <draft-ietf-bess-l3vpn-yang@ietf.org>
CC: "bess@ietf.org" <bess@ietf.org>
Thread-Topic: Some YANG validator error info about draft-ietf-bess-l3vpn-yang
Thread-Index: AdepYs5/htlY7gd0TTuL6goZvgVHhw==
Date: Tue, 14 Sep 2021 12:32:46 +0000
Message-ID: <a98ce18f832a46feb8d32994af493d32@huawei.com>
Accept-Language: zh-CN, en-US
Content-Language: zh-CN
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.108.153.118]
Content-Type: multipart/alternative; boundary="_000_a98ce18f832a46feb8d32994af493d32huaweicom_"
MIME-Version: 1.0
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/VAA4MRMDK9t_X4kZMZv05sC9Oco>
Subject: [bess] Some YANG validator error info about draft-ietf-bess-l3vpn-yang
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Sep 2021 12:32:58 -0000

Hi Authors,

Recently, we are preparing to use the L3VPN yang model, we check it with the yang-validator at https://yangcatalog.org/yangvalidator,
and found the following errors:

Pyang Validation
/var/yang/tmp/yangvalidator/yangvalidator-v2-workdir-TwlCIaOZ/ietf-bgp-l3vpn@2018-04-17.yang:508: error: node ietf-bgp::bgp is not found
/var/yang/tmp/yangvalidator/yangvalidator-v2-workdir-TwlCIaOZ/ietf-bgp-l3vpn@2018-04-17.yang:515: error: node ietf-bgp::bgp is not found
/var/yang/tmp/yangvalidator/yangvalidator-v2-workdir-TwlCIaOZ/ietf-bgp-l3vpn@2018-04-17.yang:523: error: node ietf-bgp::bgp is not found
/var/yang/tmp/yangvalidator/yangvalidator-v2-workdir-TwlCIaOZ/ietf-bgp-l3vpn@2018-04-17.yang:532: error: node ietf-bgp::bgp is not found
These errors appears to be model reference error.  The yang info are defined like this:
  augment "/bgp:bgp/bgp:global/bgp:afi-safis/" +
          "bgp:afi-safi/bgp:l3vpn-ipv4-unicast" {
    description "Retain route targets for ASBR scenario";
    uses retain-route-targets;
    uses vpn-pfx-limit;
  }


 Reference to the correct model, eg. ietf-bgp-sr , it looks like should be defined like this:
  augment "/rt:routing/rt:control-plane-protocols/rt:control-plane-protocol/" +
          "bgp:bgp/bgp:global/bgp:afi-safis/bgp:afi-safi/bgp:ipv4-unicast" {
    description
      "Augment BGP SAFI route";
    uses common-bgp-route-grouping;
  }

Please confirm this issue and hope to update the document to fix it.

Regards,
Haibo