Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bess-mvpn-mib-06
Glenn Mansfield Keeni <glenn@cysols.com> Sun, 13 May 2018 09:56 UTC
Return-Path: <glenn@cysols.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7246A12D889; Sun, 13 May 2018 02:56:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cQAEwrRMjjgv; Sun, 13 May 2018 02:56:42 -0700 (PDT)
Received: from niseko.cysol.co.jp (niseko.cysol.co.jp [210.233.3.236]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9475A12D875; Sun, 13 May 2018 02:56:42 -0700 (PDT)
Received: from [192.168.0.93] (cysvpn06.priv.cysol.co.jp [192.168.0.93]) (authenticated bits=0) by aso.priv.cysol.co.jp (8.14.9/8.14.9) with ESMTP id w4D9uZ3S048298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 13 May 2018 18:56:35 +0900 (JST) (envelope-from glenn@cysols.com)
From: Glenn Mansfield Keeni <glenn@cysols.com>
To: Hiroshi Tsunoda <tsuno@m.ieice.org>
Cc: mib-doctors@ietf.org, Mach Chen <mach.chen@huawei.com>, bess@ietf.org
References: <CAPbjwkzJi3xRr5cu5_6S_qHoqYcBTDYiUM_KcRA1opwedx4btQ@mail.gmail.com> <227a1df3-a65b-2f61-cf78-d57068953458@cysols.com>
Message-ID: <70f776cd-f9c5-7031-eeaf-64c92e580cad@cysols.com>
Date: Sun, 13 May 2018 18:56:20 +0900
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <227a1df3-a65b-2f61-cf78-d57068953458@cysols.com>
Content-Type: text/plain; charset="UTF-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/XkbEGU-lEprq18o_pm8SL8ycrxc>
Subject: Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bess-mvpn-mib-06
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 13 May 2018 09:56:45 -0000
Hi Tsunoda, I have done a review of the MIB. The comments follow. Glenn draft: draft-ietf-bess-mvpn-mib-06.txt Only the MIB has been reviewed. COMMENTS: 1. Naming: Please review. MO: mvpnBgpGenVrfRouteImport: if it is a condition for import name accordingly 2. Usage: Please make the usages of the following uniform in the document MVPN/mvpn/MVRF tunnel type/Tunnel type Source AS/source-as 3. Units: The units for the following MOs are unspecified. Please check. MO: mvpnBgpGenCmcastRouteWithdrawalTimer MO: mvpnBgpGenSrcSharedTreeJoinTimer MO: mvpnBgpGenMsgRateLimit MO: mvpnBgpGenMaxSpmsiAdRoutes MO: mvpnBgpGenMaxSpmsiAdRouteFreq MO: mvpnBgpGenMaxSrcActiveAdRoutes MO: mvpnBgpGenMaxSrcActiveAdRouteFreq 4. Semantics: InetAddress and INetAddressType objects for several MOs, usage of InetAddressType unknown(0) is described. In all such cases the corresponding InetAddress MO value MUST be a string of length 0. Plese explain that case in the respective DESCRIPTIONs E.g. mvpnMrouteUpstreamNeighborAddr mvpnMrouteNextHopSourceAddr mvpnMrouteCmcastSourceAddr mvpnMrouteSourceAddr 5. mvpnSpmsiAdvtCmcastSourceAddr OBJECT-TYPE SYNTAX InetAddress ==> corresponding InetAddressType object mvpnSpmsiAdvtCmcastSourceAddrType is missing 6. Nits: MO: mvpnMrouteCmcastSourceAddrType OBJECT-TYPE DESCRIPTION "A value indicating the address family of the address contained in mvpnMrouteSourceAddr. s/mvpnMrouteSourceAddr/mvpnMrouteCmcastSourceAddr/ 7. Table descriptions: mvpnIpmsiAdvtTable mvpnSpmsiAdvtTable The DESCRIPTIONs are unclear. Do the tables 'contain' all advertisements or, Statistics related to the advertisements? 8. Additional suggestions: o For INDEX clauses of variable size where the size may potentially exceed 128 octets, a statement like the following will be good. Implementors need to be aware that if the total number of octets in MO1, MO2 and MO3 exceeds NNN, then OIDs of column instances in this row will have more than 128 sub-identifiers and cannot be accessed using SNMPv1, SNMPv2c, or SNMPv3. o In REFERENCES be more specific if possible. Eg. Current: mvpnPmsiTunnelIfIndex OBJECT-TYPE REFERENCE "RFC2863 Suggested: mvpnPmsiTunnelIfIndex OBJECT-TYPE REFERENCE "RFC2863 Sec. 3.1.5 On 2018/05/02 6:59, Glenn Mansfield Keeni wrote: > Hi Tsunoda, > Thanks for the good work. > I will start reviewing this right away. > > Glenn > > On 2018/05/01 12:14, Hiroshi Tsunoda wrote: >> Dear Glenn, >> >> Thank you for waiting the update. >> I have submitted the updated version of >> draft-ietf-bess-mvpn-mib. >> >> Links to the draft and diff are as follows. >> >> URL: >> https://www.ietf.org/internet-drafts/draft-ietf-bess-mvpn-mib-06.txt >> Htmlized: https://tools.ietf.org/html/draft-ietf-bess-mvpn-mib-06 >> Htmlized: >> https://datatracker.ietf.org/doc/html/draft-ietf-bess-mvpn-mib >> Diff: >> https://www.ietf.org/rfcdiff?url2=draft-ietf-bess-mvpn-mib-0 >> >> This version contains some major changes as follows. >> I hope this update make the role and usage of the MIB clear for you. >> >> +----------------------------------------------------------+ >> Changes: >> >> 1. Support for row creation in all tables is removed >> >> Reason: The utility of row creation is dubious. >> It increases complexity of the MIB implementation. >> Unless an immediate need for row creation, we will go ahead >> with the current draft and review the need for row creation >> at a later date if and when it arises. >> >> 2. Added objects to make the role and usage of this MIB clear. >> >> Reason: This MIB will provide the following management functions. >> >> - Configuration of MVRF related timers >> >> - Generation of Notifications to indicate creation, deletion, >> and/or modification of MVRFs >> >> - Generation of Notification when a member joins or leaves a >> multicast group >> >> - Monitoring of the following >> - attributes of MVRFs of MVPNs >> - PMSIs >> - statistics of advertisements exchanged by a PE >> - routing entries in a MVRF >> - next-hops for a multicast destination in a MVRF >> +----------------------------------------------------------+ >> >> -- tsuno >> > > _______________________________________________ > MIB-DOCTORS mailing list > MIB-DOCTORS@ietf.org > https://www.ietf.org/mailman/listinfo/mib-doctors
- [bess] Update to draft-ietf-bess-mvpn-mib-06 Hiroshi Tsunoda
- Re: [bess] Update to draft-ietf-bess-mvpn-mib-06 Glenn Mansfield Keeni
- Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bes… Glenn Mansfield Keeni
- Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bes… Hiroshi Tsunoda
- Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bes… Glenn Mansfield Keeni
- Re: [bess] [MIB-DOCTORS] Update to draft-ietf-bes… Hiroshi Tsunoda