[bess] Opsdir last call review of draft-ietf-bess-evpn-etree-12
Carlos Pignataro <cpignata@cisco.com> Mon, 07 August 2017 21:46 UTC
Return-Path: <cpignata@cisco.com>
X-Original-To: bess@ietf.org
Delivered-To: bess@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 7193B128C9C; Mon, 7 Aug 2017 14:46:16 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Carlos Pignataro <cpignata@cisco.com>
To: ops-dir@ietf.org
Cc: draft-ietf-bess-evpn-etree.all@ietf.org, bess@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.58.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <150214237640.19001.10607149762446910281@ietfa.amsl.com>
Date: Mon, 07 Aug 2017 14:46:16 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/dFLgc0khBSpW20j9axouV01yVoM>
Subject: [bess] Opsdir last call review of draft-ietf-bess-evpn-etree-12
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Aug 2017 21:46:16 -0000
Reviewer: Carlos Pignataro Review result: Has Issues Reviewer: Carlos Pignataro Review result: Has Nits (and one potential Issue) I am the OPS-DIR reviewer and in general I do not have operational concerns with this document. The main issue I have is in regards to the redefinition of the MSB of the Tunnel Type, and associated backwards/forward compatibility considerations. I note that RFC 7385 is Normatively referenced by a number of I-Ds: https://datatracker.ietf.org/doc/rfc7385/referencedby/ BUT draft-ietf-bess-evpn-etree is not: https://datatracker.ietf.org/doc/draft-ietf-bess-evpn-etree/referencedby/ So would those former be pointing to old info? And what other Backwards Compat considerations are there? Further, some nits and editorials for your consideration: The Metro Ethernet Forum (MEF) has defined a rooted-multipoint Ethernet service known as Ethernet Tree (E-Tree). A solution framework for supporting this service in MPLS networks is proposed in RFC7387 ("A Framework for Ethernet Tree (E-Tree) Service over a Multiprotocol Label Switching (MPLS) Network"). Proposed? Or Described / Defined? Same comment for the first sentence of the second paragraph of the Intro. This document makes use of the most significant bit of the scope governed by the IANA registry created by RFC7385, and hence updates RFC7385 accordingly. RFC 7385 does not mention a "scope". This really talks about the Tunnel Type. Please reword for unambiguous clarity. 3.1 Known Unicast Traffic To support the above ingress filtering functionality, a new E-TREE Extended Community with a Leaf indication flag is introduced [section 5.2]. This new Extended Community MUST be advertised with MAC/IP Section 5.2 is not a referenced citation. Similar issue with [5.1] at: In PBB-EVPN, the PE advertises a Root/Leaf indication along with each B-MAC Advertisement route, to indicate whether the associated B-MAC address corresponds to a Root or a Leaf site. Just like the EVPN case, the new E-TREE Extended Community defined in section [5.1] is advertised with each MAC Advertisement route. 3.2 BUM Traffic Please expand to Broadcast, Unkonwn, Multicast. When receiver ingress-replication label is needed, the high-order bit of the tunnel type field (Composite Tunnel bit) is set while the remaining low-order seven bits indicate the tunnel type as before. I believe it would be useful to depict the Composite Tunnel bit in Figure 5 as well... It's not only a 1-octet Type. Also, please note: ** Obsolete normative reference: RFC 5226 ** Downref: Normative reference to an Informational RFC: RFC 7387 Thank you! Carlos.
- [bess] Opsdir last call review of draft-ietf-bess… Carlos Pignataro
- Re: [bess] Opsdir last call review of draft-ietf-… Ali Sajassi (sajassi)
- Re: [bess] Opsdir last call review of draft-ietf-… Carlos Pignataro (cpignata)
- Re: [bess] Opsdir last call review of draft-ietf-… Ali Sajassi (sajassi)
- Re: [bess] Opsdir last call review of draft-ietf-… Alvaro Retana (aretana)
- Re: [bess] Opsdir last call review of draft-ietf-… Ali Sajassi (sajassi)
- Re: [bess] Opsdir last call review of draft-ietf-… Ali Sajassi (sajassi)
- Re: [bess] Opsdir last call review of draft-ietf-… Alvaro Retana (aretana)
- Re: [bess] Opsdir last call review of draft-ietf-… Ali Sajassi (sajassi)
- Re: [bess] Opsdir last call review of draft-ietf-… Alvaro Retana (aretana)
- Re: [bess] Opsdir last call review of draft-ietf-… Ali Sajassi (sajassi)