[bess] Shepherd's review of draft-ietf-bess-evpn-ac-df

<stephane.litkowski@orange.com> Tue, 30 January 2018 09:35 UTC

Return-Path: <stephane.litkowski@orange.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CB38813172D; Tue, 30 Jan 2018 01:35:11 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.63
X-Spam-Level:
X-Spam-Status: No, score=-2.63 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8fn7jxZ9ecbp; Tue, 30 Jan 2018 01:35:10 -0800 (PST)
Received: from orange.com (mta136.mail.business.static.orange.com [80.12.70.36]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E316312D82C; Tue, 30 Jan 2018 01:35:05 -0800 (PST)
Received: from opfednr04.francetelecom.fr (unknown [xx.xx.xx.68]) by opfednr27.francetelecom.fr (ESMTP service) with ESMTP id 976FCA1444; Tue, 30 Jan 2018 10:35:04 +0100 (CET)
Received: from Exchangemail-eme2.itn.ftgroup (unknown [xx.xx.31.33]) by opfednr04.francetelecom.fr (ESMTP service) with ESMTP id 774EF4007D; Tue, 30 Jan 2018 10:35:04 +0100 (CET)
Received: from OPEXCLILMA4.corporate.adroot.infra.ftgroup ([fe80::65de:2f08:41e6:ebbe]) by OPEXCLILM42.corporate.adroot.infra.ftgroup ([fe80::d5fd:9c7d:2ee3:39d9%19]) with mapi id 14.03.0382.000; Tue, 30 Jan 2018 10:35:04 +0100
From: <stephane.litkowski@orange.com>
To: "draft-ietf-bess-evpn-ac-df.authors@ietf.org" <draft-ietf-bess-evpn-ac-df.authors@ietf.org>
CC: "bess@ietf.org" <bess@ietf.org>
Thread-Topic: Shepherd's review of draft-ietf-bess-evpn-ac-df
Thread-Index: AdOY5rl5ODBZOc6MS9KMoyFYxmqD6g==
Date: Tue, 30 Jan 2018 09:35:03 +0000
Message-ID: <14228_1517304904_5A703C48_14228_134_1_9E32478DFA9976438E7A22F69B08FF921EB3535C@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
Accept-Language: fr-FR, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.168.234.6]
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/fUIz-_kvpvf3wMlPNlPhxMO2G1I>
Subject: [bess] Shepherd's review of draft-ietf-bess-evpn-ac-df
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jan 2018 09:35:12 -0000

Hi,

As shepherd of this document, please find below my comments.

IMO, this is a very useful proposal. The document is quite easy to understand with a good illustrated example.

Overall comments:
- I would encourage to have an acronym section containing all abbreviations and the associated expansion. That could be a good best practice.
- I'm wondering why this document intended status is Informational. It looks to fill a major (IMO) miss from the basic specification and I would be happy to see it as a standard track document. Even if there is no protocol extension involved, I think that standard track could make sense. Was this already discussed ?
- I'm not sure that we can say that this procedure is backward compatible. I agree that there is no protocol extension involved but as it is mentioned, we cannot mix PEs running the new procedure and PE running the old procedure. This must be ensured by the operator. Wouldn't it be better to add a flag/attribute to announce that a PE is capable to run this procedure ? Thus, when PEs run the svc carving algo, if they know that all the PEs are capable of this procedure, and they can all run it automatically. If there is one or more PE in the set that is not capable, they fallback to the regular procedure.
- I would be in favor of having of deployment considerations section that deals with the backward compatibility and how to deploy the solution.
- There are too much authors in the Author list. Would it be possible to reduce it ?

Problem statement: 
"an ES route withdrawn will make...".
[SLI] I have a doubt here, would it be "and ES route withdrawal will make" or "a withdrawn ES route" ?


Section 2.1
" After running the service-carving DF election algorithm"
[SLI] Could you mention that you refer to the existing algorithm from RFC7432 ?

Section 2.2/2.3:
- Would it be possible to collapse the two cases in a single procedure update ?
- I do not like to mix examples with a procedure update description. I would rather be in favor of focusing on what is changing compared to RFC7432. For instance, "The step 3 is changed as follows:". Keeping the example is really good, so after describing the procedure, it makes sense to run it through the example.



Brgds,

 
Stephane Litkowski 


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.