Re: [bess] AD Review of draft-ietf-bess-evpn-vpws-07

"Alvaro Retana (aretana)" <aretana@cisco.com> Fri, 24 February 2017 15:15 UTC

Return-Path: <aretana@cisco.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B8D84129868; Fri, 24 Feb 2017 07:15:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.523
X-Spam-Level:
X-Spam-Status: No, score=-14.523 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MUV7CeO0riEx; Fri, 24 Feb 2017 07:15:32 -0800 (PST)
Received: from rcdn-iport-3.cisco.com (rcdn-iport-3.cisco.com [173.37.86.74]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93FCD129DEA; Fri, 24 Feb 2017 07:15:32 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=3762; q=dns/txt; s=iport; t=1487949332; x=1489158932; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=aXrZJKOI1tkPLqzQSNzu2SrjKB4/0cBBdexxSTTg5CY=; b=lAQ32w8c73e1MAzCUlTMdRVI2nFs2W3/CJbyLwVoBkpyGYstrdrPXccG bIUuxo9aivHI7LJnTFMHWeSMuYwd5D0y9yT2v/L8sDTMAliywEcCK+vnS SElZYZxcU7SGx6cg78LSJ6GF0pm3/SkpulOm1fkSnlvPZAVrrGD+9Qtlw Y=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CVAQCYTbBY/4sNJK1dGQEBAQEBAQEBAQEBBwEBAQEBg1BhgQkHg1SKCJFflTWCDS6FdAIagXQ/GAECAQEBAQEBAWIohHEBAwEBIxFFBQsCAQYCDgwCJgICAjAVEAIEAQ0FFIlYCA6PZp1YgiaLQQEBAQEBAQEBAQEBAQEBAQEBAQEBARgFgQuFQYIFgmqDF4E9gwYugjEBBJVrhi8BhnOLMYF7hSCJe4g6inIBHziBAVQVPhEBhD0dgWF1AQEDiReBDQEBAQ
X-IronPort-AV: E=Sophos;i="5.35,201,1484006400"; d="scan'208";a="202255594"
Received: from alln-core-6.cisco.com ([173.36.13.139]) by rcdn-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Feb 2017 15:15:31 +0000
Received: from XCH-RCD-002.cisco.com (xch-rcd-002.cisco.com [173.37.102.12]) by alln-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id v1OFFVe8006546 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 24 Feb 2017 15:15:31 GMT
Received: from xch-aln-002.cisco.com (173.36.7.12) by XCH-RCD-002.cisco.com (173.37.102.12) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Fri, 24 Feb 2017 09:15:30 -0600
Received: from xch-aln-002.cisco.com ([173.36.7.12]) by XCH-ALN-002.cisco.com ([173.36.7.12]) with mapi id 15.00.1210.000; Fri, 24 Feb 2017 09:15:30 -0600
From: "Alvaro Retana (aretana)" <aretana@cisco.com>
To: Sami Boutros <sboutros@vmware.com>, "draft-ietf-bess-evpn-vpws@ietf.org" <draft-ietf-bess-evpn-vpws@ietf.org>
Thread-Topic: AD Review of draft-ietf-bess-evpn-vpws-07
Thread-Index: AQHSd44kA2pNPLQMm0qn/KFCiMDXR6FXV1sAgBT47oCAAAMogIAHCikAgAUluAA=
Date: Fri, 24 Feb 2017 15:15:30 +0000
Message-ID: <D238781A-E382-46C8-A476-190BFAFDEE3D@cisco.com>
References: <71E62DB5-32E4-441D-9D22-290CFFC5BAD1@cisco.com> <88C160DC-F644-43D4-B538-B4568E6A0C16@vmware.com> <1B8342FC-4D33-42E5-9DF5-7CBE5BCCF86D@cisco.com> <5C8344A2-4CA8-433F-ACD4-4F71C5C32A73@cisco.com> <93624552-F50D-48BB-A666-186D550F0BEC@vmware.com>
In-Reply-To: <93624552-F50D-48BB-A666-186D550F0BEC@vmware.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.1f.0.170216
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.117.15.6]
Content-Type: text/plain; charset="utf-8"
Content-ID: <92AEE02582323B46AD86BDC4AACB4A82@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/h40D4ms9Uhy5MvxKQtoQsgtBTx4>
Cc: Jeffrey Zhang <zzhang@juniper.net>, "bess-chairs@ietf.org" <bess-chairs@ietf.org>, "bess@ietf.org" <bess@ietf.org>
Subject: Re: [bess] AD Review of draft-ietf-bess-evpn-vpws-07
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Feb 2017 15:15:38 -0000

On 2/21/17, 12:39 PM, "Sami Boutros" <sboutros@vmware.com> wrote:

Sami:

Hi!

> Please see comments inline. I have submitted 09.

I just have a couple of small things below, the biggest being the 24-bit alignment – which seems to be resolved on the list.

I’m going to start the IETF Last Call, but please update the draft when you get a chance.

Thanks,

Alvaro.

…
> > > > M5.1. Section 3: “Ethernet Tag ID 32-bit field is set to the 24-bit VPWS service instance 
> > > > identifier” 
> > > > How should this be aligned into the larger field?
> > >  
> > > Sami: Changed the text to "This document specifies the use of the per EVI Ethernet A-D route 
> > > to signal VPWS services. The Ethernet Segment Identifier field is set to the customer ES and 
> > > the Ethernet Tag ID 32-bit field MUST be set to the 24-bit VPWS service instance identifier 
> > > value."
> >
> > Ok, but you still didn’t mention how the 24-bit value is to be aligned in the 32-bit field.  I’m 
> > guessing there will be some 0-padding, but will that the at the beginning or the end?
> >
>
> I made the VPWS service instance identifier a 32-bit value in the new draft.

I also like Patrice’s suggestion [1]

[1] https://mailarchive.ietf.org/arch/msg/bess/hYuoAvF4eeYVSRRrlVi8MQMOf3Y/?qid=50f2dee8ec109478be61f1e0aefd03a5 


…
> > > > P2. The [MEF] reference didn’t work for me; on all tries the connection timed out.  Is it 
> > > > possible to find a more stable reference?
> > > 
> > > Sami: No clue here!
> > How about this:  https://urldefense.proofpoint.com/v2/url?u=https-
3A__www.mef.net_Assets_Technical-5FSpecifications_PDF_MEF-5F6.1.pdf&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=IVzcTRLQdpta08L0b_y2zDkqvwJhRKMCAbX-2K-LV98&m=GH5FIfqtBUACPwx-LVV2v5zPrGcNzhCEjfj8-0-R2OI&s=5b19ceQDqdsz0TepqsV7daJoYm9uDMyco7BZ4NeICWU&e=   ??
> > 
> 
> Thanks,

Sorry, I don’t know why we ended up with that long thing, this is the short one: https://www.mef.net/Assets/Technical_Specifications/PDF/MEF_6.1.pdf


> > …
> > > > P9. There is no Reference to any of the Extended Communities RFCs: 4360, 7153, etc…
> > >
> > > Sami: Done.
> >
> > We still need a reference to rfc4360 – at least in Section 3.1 where the new community is 
> > defined.
> >
> > You did add a reference to rfc7153, but it is not used in the text. ☹  There’s no point in having it 
> > if it isn’t used!
> 
> I changed the text as follow in 3.1 and added/removed the above references.
>
> "This draft proposes a new extended community, defined below as per [RFC7432] in addition to 
> the values specified in [RFC4360]"

This is enough: “This draft proposes a new extended community [RFC4360]…”.