[bess] Benjamin Kaduk's No Objection on draft-ietf-bess-evpn-vpls-seamless-integ-05: (with COMMENT)

Benjamin Kaduk <kaduk@mit.edu> Mon, 07 January 2019 17:17 UTC

Return-Path: <kaduk@mit.edu>
X-Original-To: bess@ietf.org
Delivered-To: bess@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B140E130F7C; Mon, 7 Jan 2019 09:17:43 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Benjamin Kaduk <kaduk@mit.edu>
To: The IESG <iesg@ietf.org>
Cc: draft-ietf-bess-evpn-vpls-seamless-integ@ietf.org, Matthew Bocci <matthew.bocci@nokia.com>, bess-chairs@ietf.org, matthew.bocci@nokia.com, bess@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.89.2
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <154688146371.23228.11253231358362119768.idtracker@ietfa.amsl.com>
Date: Mon, 07 Jan 2019 09:17:43 -0800
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/iRg-y6QZd4q7IZzOQZguIYUBIzo>
Subject: [bess] Benjamin Kaduk's No Objection on draft-ietf-bess-evpn-vpls-seamless-integ-05: (with COMMENT)
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jan 2019 17:17:44 -0000

Benjamin Kaduk has entered the following ballot position for
draft-ietf-bess-evpn-vpls-seamless-integ-05: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-bess-evpn-vpls-seamless-integ/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Please be consistent about (non-)hyphenation of "VPLS A-D".

Is "MP2P" really an intended acronym (vs., e.g., P2MP)?  It does not appear
in https://www.rfc-editor.org/materials/abbrev.expansion.txt and is not
defined, even though P2MP is, and MP2P is used some 8 times in the
document.

We probably need a definition and/or reference for "split-horizon".

Section 2

   6. The support of All-Active redundancy mode across both (PBB-)EVPN
   PEs and (PBB-)VPLS PEs is outside the scope of this document.

The claim (not quoted) of "seamless" integration seems to only hold if
All-Active redundancy mode is not in common use.  Is it?

Section 3.1

                                                          In this case,
   when a VPLS PE receives the EVPN IMET route, it MUST ignore it on the
   basis that it belongs to an unknown SAFI. [...]

Is this "MUST" a new requirement imposed by this document, or a restatement
of an existing requirement from elsewhere?

Section 3.2

Please expand FEC on first usage (or define it in the terminology section).

When we talk about "learned" C-MAC addresses from traffic on VPLS PWs and
injecting those MAC addresses into bridge tables, RIB/FIB tables, and
MAC-VRFs, are these learned C-MAC addresses coming from provider-owned
equipment or customer equipment?  Giving the customer the ability to inject
MAC addresses without verification would probably merit a closer look
(though I do note that the penultimate paragraph discusses the
non-propagation of the learned addresses over the control plane).

Section 3.4.2, 4.4.2

My understanding was that P2MP (PBB-)EVPN tunnels are a well-understood thing, in
which case I would expect to see something more like "this document does
not modify the operation of multicast P2MP EVPN tunnels" than "outside the
scope of this document".

Section 5

Does the extra state that (PBB-)EVPN PEs need to maintain (i.e., both the
normal EVPN state and PWs to the VPLS PEs) pose any risk of DoS due to
resource exhaustion?