Re: [bess] Last Call: <draft-ietf-bess-evpn-df-election-framework-06.txt> (Framework for EVPN Designated Forwarder Election Extensibility) to Proposed Standard

Anoop Ghanwani <anoop@alumni.duke.edu> Thu, 20 December 2018 01:51 UTC

Return-Path: <ghanwani@gmail.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 86CB5130DDE for <bess@ietfa.amsl.com>; Wed, 19 Dec 2018 17:51:56 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.898
X-Spam-Level:
X-Spam-Status: No, score=-1.898 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JerXtv84r2Gw for <bess@ietfa.amsl.com>; Wed, 19 Dec 2018 17:51:53 -0800 (PST)
Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8F85412F1AC for <bess@ietf.org>; Wed, 19 Dec 2018 17:51:53 -0800 (PST)
Received: by mail-ua1-f48.google.com with SMTP id z11so38140uaa.10 for <bess@ietf.org>; Wed, 19 Dec 2018 17:51:53 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P2zNz/CMFkgEo8F6VF9jTPJHwzNHBqMCy2qZCPyxhFg=; b=kAyJ8q7C/YdNQxpLNMA6WlJ/mg3cge8ipMTYwXRTwDpueRG9nu114JZTN/f6pjeXZD JJY4VbkTjln40L2Yirr2MsZUz17WFH3zQZtJnSYzbdTAon6QmLutXgMsbyEwKoXLtg0e cx+Ja+6AsR9WF06vGJAuVjXPA1t47E1HvSdTiiLtVNPB87s/OcLU19TSiFMt8kKJrCe6 2zofCDKUxFDt6H3r5/k0y8cp05XEQX42v0/npv+EuMKQx4o9raZsZSD8PZQ4V4Qd/NeF Qdz7K+R91IWtDfrS+iSlsOpBD5b6Eu+2AvLRKdgnApmIrdTlJBdyHD7hKc+Wgyp2NpoD OzeQ==
X-Gm-Message-State: AA+aEWY1JTeMuxt+UV9bVz1xoWqTM2fyt0BYDWeuVY/QtI2DCZByG6ZX KGsYzQoxz1OrrUXiE3PAIMyhLacoOGYQVhy9g2o=
X-Google-Smtp-Source: AFSGD/X1PMxqRLp29Kkh+PR0vSSLZI5dBwCD7sBXHEwByxoZ0y3XrgJizIZE2r70+TruO2M3sS6AHytr4O18bpCzuy0=
X-Received: by 2002:ab0:3045:: with SMTP id x5mr10510974ual.70.1545270712447; Wed, 19 Dec 2018 17:51:52 -0800 (PST)
MIME-Version: 1.0
References: <154397142840.4620.1360654856007304944.idtracker@ietfa.amsl.com> <CA+-tSzwdxwGTB99kozVhN-fb8EuxvD7d_i5t_c9b+y4Ee1dmyw@mail.gmail.com> <CAA5BD0C-1CBD-49F1-B61F-B05B430754E7@cisco.com> <56D3C9F8-136A-48A9-AFB4-A774C0FBC0C8@nokia.com>
In-Reply-To: <56D3C9F8-136A-48A9-AFB4-A774C0FBC0C8@nokia.com>
From: Anoop Ghanwani <anoop@alumni.duke.edu>
Date: Wed, 19 Dec 2018 17:51:40 -0800
Message-ID: <CA+-tSzzq2ESXOgTfA+nTfwogEuG6hxLBLw6K7NwzgCgBtyNhpw@mail.gmail.com>
To: "Rabadan, Jorge (Nokia - US/Mountain View)" <jorge.rabadan@nokia.com>
Cc: "Satya Mohanty (satyamoh)" <satyamoh@cisco.com>, "bess@ietf.org" <bess@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/kmAOCkchJpisYaPqx_3hMHxGx78>
Subject: Re: [bess] Last Call: <draft-ietf-bess-evpn-df-election-framework-06.txt> (Framework for EVPN Designated Forwarder Election Extensibility) to Proposed Standard
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2018 01:51:57 -0000

Thanks Jorge!

On Wed, Dec 19, 2018 at 1:18 AM Rabadan, Jorge (Nokia - US/Mountain
View) <jorge.rabadan@nokia.com> wrote:
>
> Hi Anoop,
>
> Thank you for your review. We took all your comments.
> Please see in-line how we are resolving them in rev 07.
>
> Thanks.
> Jorge
>
> -----Original Message-----
> From: BESS <bess-bounces@ietf.org> on behalf of "Satya Mohanty (satyamoh)" <satyamoh@cisco.com>
> Date: Friday, December 7, 2018 at 6:09 PM
> To: Anoop Ghanwani <anoop@alumni.duke.edu>du>, "bess@ietf.org" <bess@ietf.org>
> Subject: Re: [bess] Last Call: <draft-ietf-bess-evpn-df-election-framework-06.txt> (Framework for EVPN Designated Forwarder Election Extensibility) to Proposed Standard
>
>     Hi Anoop,
>
>     Thank you very much for your editorial comments and review.
>     We will take care of it.
>
>     Best,
>     --Satya
>
>
>     On 12/7/18, 1:01 AM, "BESS on behalf of Anoop Ghanwani" <bess-bounces@ietf.org on behalf of anoop@alumni.duke.edu> wrote:
>
>         I have reviewed the doc and I have mostly editorial comments.
>
>         Thanks,
>         Anoop
>
>         ==
>
>         Throughout
>
>         VLAN Bundle, VLAN bundle, VLAN-Bundle, VLAN-bundle -- make consistent
>         VLAN Aware Bundle, VLAN-aware bundle, VLAN-Aware Bundle -- make consistent
>         bridge table, Bridge Table -- make consistent (also add definition to
>         terminology section)
>         DF election, DF Election -- make consistent
>         Default DF Election, default DF Election -- make consistent
>         non-DF -> NDF
> [JORGE] done, thx
>
>         Section 1
>
>         double Q-in-Q tags -> Q-in-Q tags
>
>         double is redundant
> [JORGE] done, thx
>
>         Section 2.1
>
>         Fig 1 is a bit confusing.  If the idea of the rectangle is to show a
>         core, then why have connections between PE1 and PE2, PE3, but not
>         between PE1 and PE4?
> [JORGE] good point, fixed it, thx
>
>         Change
>         >>>
>         Layer-2 devices are particularly susceptible to forwarding loops
>         because of the broadcast nature of the Ethernet traffic.
>         >>>
>         to
>         The effect of forwarding loops in a Layer-2 network is particularly
>         severe because of the broadcast nature of Ethernet traffic and the
>         lack of a TTL.
> [JORGE] done, thanks.
>
>         Section 2.2.1
>
>         a v4 or v6 peering -> an IPv4 or IPv6 peering
> [JORGE] done, thanks.
>
>         >>>
>         >From a forwarding perspective, this is
>         a churn, as it results in re-programming the PE ports as either
>         blocking or non-blocking at potentially all PEs when the DF changes.
>         >>>
>
>         Why would the reprogramming change at all PEs?  It should change for
>         at most 2 PEs for each (ES,EVI) being reprogrammed.  Maybe authors
>         were trying to convey something else?
> [JORGE] changed to:
> ***From a forwarding perspective, this is
>    a churn, as it results in re-programming the PE ports as either
>    blocking or non-blocking at the PEs where the DF state changes.***
>
>
>         Section 2.3
>
>         >>>
>         DF Election procedure Generally
>         >>>
>         Missing a period.
> [JORGE] done, thanks.
>
>
>         Section 3
>
>         specification in EVPN -> EVPN specification
> [JORGE] done, thanks.
>
>
>         Section 3.1
>
>         DF WAIT, DF_WAIT -- make consistent
> [JORGE] done, thanks.
>
>         DF Wait timer -- where is this defined?
> [JORGE] This is defined in [RFC7432]. I added a reference.
>
>         Ethernet Segment Route -> Ethernet Segment route
>         stop DF timer ->  stop DF wait timer (?)
>         start DF timer -> start DF wait timer (?)
> [JORGE] done, thanks.
>
>         Section 4
>
>         rather than the state of the server states -> rather than the state of
>         the server (?)
> [JORGE] done, thanks.
>
>         Section 4.2
>
>         Si is the IP address of server i -> Si is the IP address of PE i
> [JORGE] done, thanks.
>
>         operator chooses so -> operator so chooses
> [JORGE] done, thanks.
>
>         Note 0 <= i,j <= Number of PEs -- should this be "< Number of PEs"?
>         Weight(V, Es, Sk) -> Weight(v, Es, Sk)
>         Pseudo-random -> pseudo-random
>         efficient deterministic -> efficient and deterministic
>         V4 -> IPv4
>         V6 -> IPv6
> [JORGE] all of them changed. Thanks.
>
>         _______________________________________________
>         BESS mailing list
>         BESS@ietf.org
>         https://www.ietf.org/mailman/listinfo/bess
>
>
>     _______________________________________________
>     BESS mailing list
>     BESS@ietf.org
>     https://www.ietf.org/mailman/listinfo/bess
>
>
>