IETF Logo Mail Archive

Re: [bess] AD Review of draft-ietf-bess-fat-pw-bgp-03

Sami Boutros <sboutros@vmware.com> Sat, 27 January 2018 00:27 UTC

Return-Path: <sboutros@vmware.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9098612D777; Fri, 26 Jan 2018 16:27:07 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=onevmw.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z3_qBmurFfDX; Fri, 26 Jan 2018 16:27:04 -0800 (PST)
Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0074.outbound.protection.outlook.com [104.47.34.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5F0D112D7E8; Fri, 26 Jan 2018 16:27:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onevmw.onmicrosoft.com; s=selector1-vmware-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=sq7sqAO1jFmdIO5/xCHsqiB89g66gf2Xjo03mapfo4A=; b=BMsJ1oksdpwaFsEO0Lavf/6ANFj0aMbyQDRufmq7oOUGweHavBQ7+hKhbquuBpaN6f9CDUsuLg44CZk+EXV2OGvfQKTvFkoq8gs6YIfsWZSe+b9Kvk1Q7XxjyOQ69KgJjtq4sNPROuZtv6mbTS5pafJyv3vUKlkEpA/hX46s9DI=
Received: from MWHPR05MB3389.namprd05.prod.outlook.com (10.174.175.150) by MWHPR05MB3055.namprd05.prod.outlook.com (10.173.228.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.6; Sat, 27 Jan 2018 00:27:02 +0000
Received: from MWHPR05MB3389.namprd05.prod.outlook.com ([10.174.175.150]) by MWHPR05MB3389.namprd05.prod.outlook.com ([10.174.175.150]) with mapi id 15.20.0444.011; Sat, 27 Jan 2018 00:27:02 +0000
From: Sami Boutros <sboutros@vmware.com>
To: Alvaro Retana <aretana.ietf@gmail.com>, "draft-ietf-bess-fat-pw-bgp@ietf.org" <draft-ietf-bess-fat-pw-bgp@ietf.org>
CC: "bess@ietf.org" <bess@ietf.org>, "bess-chairs@ietf.org" <bess-chairs@ietf.org>, Martin Vigoureux <martin.vigoureux@nokia.com>
Thread-Topic: AD Review of draft-ietf-bess-fat-pw-bgp-03
Thread-Index: AQHTlvA/LNkwW137kk2nBEuvHZHJCaOGVx0A
Date: Sat, 27 Jan 2018 00:27:02 +0000
Message-ID: <9D3EAE0F-5291-4443-BCF2-6549A4F91C8F@vmware.com>
References: <CAMMESsxi8nYzsBsomGvkrChiV-hjWwoNdwE4sk_hpFh4se6cEg@mail.gmail.com>
In-Reply-To: <CAMMESsxi8nYzsBsomGvkrChiV-hjWwoNdwE4sk_hpFh4se6cEg@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [208.91.2.2]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; MWHPR05MB3055; 7:stMQirYw0vPUAWo7g7sS0OS2dDUCqeNRB+c3lWARmG1d0IMDpPbCe0JiarAdzI3RTicjZuzZZAGpQt4rMGPq4UxuoyGTG/in8EExhmb2VfveejMf09TgqewSV8rrd4Yl1afS/njyJxobjnNRJaALcxASOQmga+2P5PF4To4slHEHNssB/3sMkjw621StSIMKyrGkYvuhqLj+mkbQs7VziEePdC4zNf2qMZxA+J5o47JiarVvk0Dwqv3PHvzIBgpX; 20:Vrq18+ehMnntFTPz8JDPdK+gdb7Tx9ZJpQfuKcN3t1u8MwMbub7gD2jTE9KKHcCYqdNdINe3NXMkIgIbPNS6N+xMWlxFWNmdZq+MZb+UpEFfFof5dM9m2416z+PrvQ9B5t16E+/XIVQFop4ptl2ZJyra0tL+1Lib6UN0aj07U5k=
x-ms-exchange-antispam-srfa-diagnostics: SSOS;
x-ms-office365-filtering-correlation-id: 65f616bd-bcd5-4ebb-a71b-08d5651caff6
x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:MWHPR05MB3055;
x-ms-traffictypediagnostic: MWHPR05MB3055:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=sboutros@vmware.com;
x-microsoft-antispam-prvs: <MWHPR05MB3055C030BE03A828B4F7E21ABEE70@MWHPR05MB3055.namprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(61668805478150)(192374486261705)(99586504457433)(82608151540597)(85827821059158)(62221491112393)(95692535739014);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231079)(2400081)(944501161)(6041288)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:MWHPR05MB3055; BCL:0; PCL:0; RULEID:; SRVR:MWHPR05MB3055;
x-forefront-prvs: 056544FBEE
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(39860400002)(39380400002)(396003)(366004)(57704003)(199004)(189003)(81156014)(77096007)(110136005)(2501003)(102836004)(6246003)(59450400001)(6486002)(81166006)(105586002)(6436002)(54896002)(36756003)(26005)(53546011)(6506007)(6512007)(33656002)(8936002)(53936002)(316002)(54906003)(236005)(8676002)(229853002)(39060400002)(68736007)(82746002)(99286004)(2950100002)(478600001)(7736002)(8656006)(5660300001)(3660700001)(66066001)(14454004)(76176011)(86362001)(2900100001)(106356001)(186003)(2906002)(4326008)(25786009)(97736004)(3280700002)(3846002)(6116002)(83716003)(345774005); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR05MB3055; H:MWHPR05MB3389.namprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: iwwyKJllXPS20ysN38TjRBjQC1orG2RiU3pZn5XYWfA2P7zW7pVKJop46E6gRz9SftWkDlUtiCpthDE6hNc4kA==
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_9D3EAE0F52914443BCF26549A4F91C8Fvmwarecom_"
MIME-Version: 1.0
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65f616bd-bcd5-4ebb-a71b-08d5651caff6
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jan 2018 00:27:02.6585 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR05MB3055
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/n5fWJmkPWevFDS15ybN_aq4NeaU>
Subject: Re: [bess] AD Review of draft-ietf-bess-fat-pw-bgp-03
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jan 2018 00:27:08 -0000

Hi Albaro,

Agreed with all comments, and we can change the “is requesting the ability” to “announce the ability”.

Do we need to submit a new draft with the changes?

Thanks,

Sami
From: Alvaro Retana <aretana.ietf@gmail.com<mailto:aretana.ietf@gmail.com>>
Date: Friday, January 26, 2018 at 1:54 PM
To: "draft-ietf-bess-fat-pw-bgp@ietf.org<mailto:draft-ietf-bess-fat-pw-bgp@ietf.org>" <draft-ietf-bess-fat-pw-bgp@ietf.org<mailto:draft-ietf-bess-fat-pw-bgp@ietf.org>>
Cc: "bess@ietf.org<mailto:bess@ietf.org>" <bess@ietf.org<mailto:bess@ietf.org>>, "bess-chairs@ietf.org<mailto:bess-chairs@ietf.org>" <bess-chairs@ietf.org<mailto:bess-chairs@ietf.org>>, Martin Vigoureux <martin.vigoureux@nokia.com<mailto:martin.vigoureux@nokia.com>>
Subject: AD Review of draft-ietf-bess-fat-pw-bgp-03
Resent-From: <alias-bounces@ietf.org<mailto:alias-bounces@ietf.org>>
Resent-To: <keyur@arrcus.com<mailto:keyur@arrcus.com>>, Sami Boutros <sboutros@vmware.com<mailto:sboutros@vmware.com>>, <jliste@cisco.com<mailto:jliste@cisco.com>>, <bin_wen@cable.comcast.com<mailto:bin_wen@cable.comcast.com>>, <jorge.rabadan@nokia.com<mailto:jorge.rabadan@nokia.com>>
Resent-Date: Friday, January 26, 2018 at 1:54 PM

Dear authors:

I just finished reading this document.  Thank you for a well written and straight forward document!!

I have some comments (see below) that I think are easy to address.  I am then starting the IETF Last Call.

Thanks!

Alvaro.


Major:

M1. All the rfc2119 keywords in this text should not be capitalized because they are part of an example:

   For example, a PE part of a VPLS and with a local T = 1,
   MUST only transmit traffic with a flow label to those peers that
   signaled R = 1.  And if the same PE has local R = 1, it MUST only
   expect to receive traffic with a flow label from peers with T = 1.
   Any other traffic MUST NOT have a flow label.


M2. Security Considerations: I agree that there are no new issues.  However, please also point to rfc4761 and any other document that defines the base functionality being modified here.


Minor:

P1. "This draft introduces an OPTIONAL mode of operation..."  There's no need for "OPTIONAL" to be Normative in this sentence since it is just describing what it is, not specifying behavior.  s/OPTIONAL/optional


P2. The new registry has a policy of "IETF Review", which basically means that any RFC (not just Standards Track RFCs) can use the bits in the registry.  I ask because there are only 4 bits left.  Note that I'm not asking you to necessarily change the policy...just pointing it out.


P3. "T   When the bit value is 1, the PE is requesting the ability..."  Did you mean "announce the ability" instead?


P4. s/NUST NOT/MUST NOT


P5. References:  I think these can be Informative: rfc4385, rfc8077, rfc4928

v2.23.0 | Report a Bug | By Email