Re: [bess] I-D Action: draft-ietf-bess-evpn-inter-subnet-forwarding-10.txt

Anoop Ghanwani <anoop@alumni.duke.edu> Sat, 05 September 2020 18:19 UTC

Return-Path: <ghanwani@gmail.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D405E3A0C15; Sat, 5 Sep 2020 11:19:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.4
X-Spam-Level:
X-Spam-Status: No, score=-1.4 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QgfKfwPtjrnn; Sat, 5 Sep 2020 11:19:04 -0700 (PDT)
Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ADBF33A0C13; Sat, 5 Sep 2020 11:19:04 -0700 (PDT)
Received: by mail-vs1-f49.google.com with SMTP id s62so5366841vsc.7; Sat, 05 Sep 2020 11:19:04 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cd7zW2FMxq34YLBT7mHWzjPvMvUbxrat/8wiGZKZFU4=; b=ro2VpZz+cAx8E8lahADc95jUBLGMMpWD7mCl+la2oQZn0/QZysbwPnRlv3u8o8/2PP B0NL5VgUrCw445Ur+zYrzYSnAOnFbKUWoK74XhidgxynhQnd8f+ru+P+pDglbKSLvzhY JEvng+BwlInPJLz3RtxFlDp2gpkE9XSy+mA/XemGUxnTdZuWPNqdM2bNunwlAeZ0ykcq QI2H0AC9AKOfHwEO69EWw3ncaCptCLOfXcQAdJSi0F5C6FSaVZWjSFb5Cyxo+im/FcNS 9E53DNUcaoYvLadjAbGUsEcRNsrPz5by06zC7ots9vTf32G+x5axbxYAJLw5BQAW65tP y2CA==
X-Gm-Message-State: AOAM530gYedL0uF0GMWZQSLRF1GPOSGCpfU0g1A0kg/mr1bhOlMlKgZe sLBNrG0Dp924Ab5OWjCaftuFH/9xho5MCShlOIzwRvRXsB0=
X-Google-Smtp-Source: ABdhPJxGAa/Y+tIFDp5zVsdUzaNNYIs5JHk1/JdetyDuKyp+Muk1naDXg0UwwsDMU2TWzu1SWCejaH35u+Oon4vQUuU=
X-Received: by 2002:a67:ed59:: with SMTP id m25mr8977521vsp.38.1599329943412; Sat, 05 Sep 2020 11:19:03 -0700 (PDT)
MIME-Version: 1.0
References: <159915138535.5318.17059293511733582473@ietfa.amsl.com>
In-Reply-To: <159915138535.5318.17059293511733582473@ietfa.amsl.com>
From: Anoop Ghanwani <anoop@alumni.duke.edu>
Date: Sat, 05 Sep 2020 11:18:52 -0700
Message-ID: <CA+-tSzzxye1ihSam12NEnW_rSyMKc-KpdHXSGcbJR-gtSrVQ2g@mail.gmail.com>
To: BESS <bess@ietf.org>
Cc: i-d-announce@ietf.org
Content-Type: multipart/alternative; boundary="00000000000027e60d05ae95053d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/sTwjZJgpLCdLEZ3AqmavxnVi6cY>
Subject: Re: [bess] I-D Action: draft-ietf-bess-evpn-inter-subnet-forwarding-10.txt
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Sep 2020 18:19:07 -0000

Reading the doc, I found several editorial nits.  I'm half way through and
these are the comments.  If there is interest in addressing them, I will
send comments on the remainder.

throughout


- document uses route type, Route Type, route type-, RT-.

  Would be good if it consistently used RT- notation throughout.


pg 4


- VA: Virtual Appliance

  Never used in the document, suggest remove.


- NVGRE never used anywhere except figures.

  Suggest removing the definition and changing figures

  to show GENEVE.


pg 5


- back-haul, back haul

  Suggest change to backhaul.


- vise versa -> vice versa


- "FW or DPI"

  Spell these out.


pg 6


- "VLAN- Based" -> VLAN-Based


pg 7


- "a IP-VRF via a L3 inteface called IRB interface" ->

  an IR-VRF via an L3 interace called an IRB interface.


- "IP-VRF is identified..." ->

  An IP-VRF is identified...


- "MAY" -> may

  Previous bullet does not capitalize "may" and it doesn't


- It would be better if, when discussing lookups, IP _DA_ and

  MAC _DA_ are mentioned rather than just IP and MAC.  (We

  are looking up addresses, not protocols.)


- "The ingress

   PE performs a MAC lookup followed by an IP lookup and the egress PE

   performs a IP lookup followed by a MAC lookup as depicted in the

   following figure."

   This sequence applies only if there is an L3 tunnel between the

   PEs, right?  If so, that should be clarified.


pg 9


- "data planes procedures" -> data _plane_ procedures


- "used in description of" -> "used to describe"


pg 10


- "Neighbor Advertisement (NA)for"

  missing a space between (NA) and for.


pg 11


- "(VRID, range 1-255))"

  extra parenthesis


- several instances where MAC should be "MAC address".


- "These IP addresses need to be distributed as VPN

   routes"

  Does this mean EVPN route type 5?


- "to the PE that is attached to" ->

  to the PE that _it_ is attached to


pg 12


- NDP cahce -> NDP cache


- "Router's MAC EC"

  Spell out EC.


pg 13


- "If the MAC- VRF (and BT) exists"

  remove extra space in MAC- VRF.


pg 14


- (MAC,IP)

  missing a space


- "connected route redistribution to BGP" ->

  connected route redistribution in BGP


- "associated MPLS/VNI values" ->

  associated MPLS label/VNI values.


pg 15


- "MAC- VRF"

  remove extra space



On Thu, Sep 3, 2020 at 9:43 AM <internet-drafts@ietf.org> wrote:

>
> A New Internet-Draft is available from the on-line Internet-Drafts
> directories.
> This draft is a work item of the BGP Enabled ServiceS WG of the IETF.
>
>         Title           : Integrated Routing and Bridging in EVPN
>         Authors         : Ali Sajassi
>                           Samer Salam
>                           Samir Thoria
>                           John E Drake
>                           Jorge Rabadan
>         Filename        :
> draft-ietf-bess-evpn-inter-subnet-forwarding-10.txt
>         Pages           : 34
>         Date            : 2020-09-03
>
> Abstract:
>    Ethernet VPN (EVPN) provides an extensible and flexible multi-homing
>    VPN solution over an MPLS/IP network for intra-subnet connectivity
>    among Tenant Systems and End Devices that can be physical or virtual.
>    However, there are scenarios for which there is a need for a dynamic
>    and efficient inter-subnet connectivity among these Tenant Systems
>    and End Devices while maintaining the multi-homing capabilities of
>    EVPN.  This document describes an Integrated Routing and Bridging
>    (IRB) solution based on EVPN to address such requirements.
>
>
>
> The IETF datatracker status page for this draft is:
>
> https://datatracker.ietf.org/doc/draft-ietf-bess-evpn-inter-subnet-forwarding/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-bess-evpn-inter-subnet-forwarding-10
>
> https://datatracker.ietf.org/doc/html/draft-ietf-bess-evpn-inter-subnet-forwarding-10
>
> A diff from the previous version is available at:
>
> https://www.ietf.org/rfcdiff?url2=draft-ietf-bess-evpn-inter-subnet-forwarding-10
>
>
> Please note that it may take a couple of minutes from the time of
> submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
>
> _______________________________________________
> BESS mailing list
> BESS@ietf.org
> https://www.ietf.org/mailman/listinfo/bess
>