Re: [bess] AD Review of draft-ietf-bess-evpn-overlay-08

"Ali Sajassi (sajassi)" <sajassi@cisco.com> Mon, 11 December 2017 06:59 UTC

Return-Path: <sajassi@cisco.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3B53C1270A7; Sun, 10 Dec 2017 22:59:00 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.521
X-Spam-Level:
X-Spam-Status: No, score=-14.521 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IwVF1EEncyGr; Sun, 10 Dec 2017 22:58:58 -0800 (PST)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B6A89120726; Sun, 10 Dec 2017 22:58:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2102; q=dns/txt; s=iport; t=1512975538; x=1514185138; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jHq18NLei6qeFBQrnDvjkDxllK9oLKG4O4VVC8G5MK8=; b=QvKH8p71BDqofTIzfuwuyNF3YWCjWepsS69er3RyLCQe1/Rd9hCNIaIf ECiYCiNL/qt+i82V5DXB2FP6ukXPM0MbY21PxJA0jkfkRELaV2oxrKEQY 6Frvp9z8BmS1bBjOqFisHnyxmXZrkdxWOL2Lc1SgO0uroUZnYmCeT2Np4 Y=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BjAQBtLC5a/4UNJK1bGQEBAQEBAQEBA?= =?us-ascii?q?QEBAQcBAQEBAYM+gVonB4N7iiGOfIFXJpcMghUKhTsCGoRFPxgBAQEBAQEBAQF?= =?us-ascii?q?rKIUjAQQBIxFFEAIBCBoCJgICAjAVEAIEAQ0FiiAIpyiCJ4pjAQEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBAQEBAQEBHYEPglmCC4M/KQuCd4UfgxUxgjIFoxEClR+TY5YxAhEZAYE?= =?us-ascii?q?6AR85gU9vFWQBgX6EVXiIUoEVAQEB?=
X-IronPort-AV: E=Sophos;i="5.45,391,1508803200"; d="scan'208";a="42926034"
Received: from alln-core-11.cisco.com ([173.36.13.133]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Dec 2017 06:58:58 +0000
Received: from XCH-RTP-001.cisco.com (xch-rtp-001.cisco.com [64.101.220.141]) by alln-core-11.cisco.com (8.14.5/8.14.5) with ESMTP id vBB6wv2Y010697 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 11 Dec 2017 06:58:57 GMT
Received: from xch-rtp-005.cisco.com (64.101.220.145) by XCH-RTP-001.cisco.com (64.101.220.141) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Mon, 11 Dec 2017 01:58:56 -0500
Received: from xch-rtp-005.cisco.com ([64.101.220.145]) by XCH-RTP-005.cisco.com ([64.101.220.145]) with mapi id 15.00.1320.000; Mon, 11 Dec 2017 01:58:56 -0500
From: "Ali Sajassi (sajassi)" <sajassi@cisco.com>
To: Thomas Morin <thomas.morin@orange.com>, Martin Vigoureux <martin.vigoureux@nokia.com>, Alvaro Retana <aretana.ietf@gmail.com>, "bess-chairs@ietf.org" <bess-chairs@ietf.org>
CC: "bess@ietf.org" <bess@ietf.org>
Thread-Topic: [bess] AD Review of draft-ietf-bess-evpn-overlay-08
Thread-Index: AQHTbUnIE1F0wt2PNkWhZhKoHul01KM04mOAgABAs4CAAOF7AIADh0UAgAQB14A=
Date: Mon, 11 Dec 2017 06:58:56 +0000
Message-ID: <56506AD6-326D-4401-ADC7-024BB865CCFD@cisco.com>
References: <CAMMESsw2x53Av-_zi5nL5czKCXYmi_mk0i6qyYYZDYHE8oo_tA@mail.gmail.com> <3ca43a6b-2716-ff87-76da-ab520f23c6b4@nokia.com> <23037_1512483940_5A26AC64_23037_392_5_1512483939.26596.80.camel@orange.com> <109CAA9D-AA82-423E-8CEE-E721A1879D33@cisco.com> <1512726336.28574.6.camel@orange.com>
In-Reply-To: <1512726336.28574.6.camel@orange.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.28.0.171108
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.19.76.52]
Content-Type: text/plain; charset="utf-8"
Content-ID: <A992FF6C2B6EE34FA8DB431410686FBF@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/ueIKSbvLROBvsmbNHduG0lNx5R0>
Subject: Re: [bess] AD Review of draft-ietf-bess-evpn-overlay-08
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Dec 2017 06:59:00 -0000

Hi Thomas,

I have incorporated your comments into rev11 of the document. 

Cheers,
Ali

On 12/8/17, 1:45 AM, "Thomas Morin" <thomas.morin@orange.com> wrote:

    Ali,
    
    A few nits, sorry for not answering earlier:
    >   
    > I added the following paragraph to section 6 for clarification:
    > “When a PE advertises multiple supported encapsulations, it MUST
    > advertise encapsulations that use the same EVPN procedures including
    > procedures associated with split-horizon filtering described in
    > section 8.3.1. For example, VxLAN and NvGRE (or MPLS and MPLS over
    > GRE) encapsulations use the same EVPN procedures and thus a PE can
    > advertise both of them and can support either of them or both of them
    > simultaneously. However, a PE MUST NOT advertise VxLAN and MPLS 
    
    You should say "VxLAN/NVGRE" here to be consistent with the rest of the
    document that treats VXLAN and NVGRE equally.
    
    > encapsulations together because a) MPLS field of EVPN routes is set 
    
    - s/MPLS field/the MPLS field/
    - "(a)" instead of "a)" would be a bit more readable
    
    > to either a MPLS label for a VNI but not both and b) some of EVPN 
    
    - s/a MPLS label/an MPLS label/
    - s/for a VNI/or a VNI/
    - s/some of EVPN/some EVPN/  (?)
    
    > procedures (such as split-horizon filtering) are different for
    > VxLAN/NvGRE and MPLS encapsulations.”
    
    Thanks,
    
    -Thomas