Re: [bess] Comments on L3VPN yang

Alexander Vainshtein <Alexander.Vainshtein@ecitele.com> Mon, 22 October 2018 13:59 UTC

Return-Path: <Alexander.Vainshtein@ecitele.com>
X-Original-To: bess@ietfa.amsl.com
Delivered-To: bess@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 93B7412896A; Mon, 22 Oct 2018 06:59:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.199
X-Spam-Level:
X-Spam-Status: No, score=0.199 tagged_above=-999 required=5 tests=[DKIM_INVALID=0.1, DKIM_SIGNED=0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=eci365.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DLgXg32BDKsP; Mon, 22 Oct 2018 06:59:49 -0700 (PDT)
Received: from mail1.bemta25.messagelabs.com (mail1.bemta25.messagelabs.com [195.245.230.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1A53B1288BD; Mon, 22 Oct 2018 06:50:51 -0700 (PDT)
Received: from [46.226.52.103] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-4.bemta.az-a.eu-west-1.aws.symcld.net id 00/13-09000-AB5DDCB5; Mon, 22 Oct 2018 13:50:50 +0000
X-Brightmail-Tracker: H4sIAAAAAAAAA1WTa1BMYRjHe/ec3T2ZNqdNeloxbEyTnLVbhpg xYhh90eCDGe2EUx27a3ZPa8+mGB8yaGqN2yBbE0tCtwnLjEJmMkyKZJAwii7rVrYGqXzAnn03 ly/P/N7//7m9Z95DEUqvTEVxeXbOxrNmtWwSuWBWcjrT0NGm13Zfj0+qbC4hkg5/qZIkjTT2S JOJlIqKcUnKvnctsrWSNKmJz8jO2yI1dtWfJ62X96K8747UfDRgc6BgiqTLCXCVLHegSZSSPi 6BRz0eOT70IWgZKZWKWTJ6KbhrumQiT6GvIii4rRE5nI6BQ2/LENZnw/jYDwJzAnjaK6V4whz ouNvsz1HQLBx/fpLEAwoRfGmv8x+C6SIEr884/RMQPRVGW2slIhN0JLzqd/kZaBoqbrUTmCPg Y99PKc7PgDeeswjrM+FSw81A/nR44jqAxAFAN8mh7eiwHBsMDJ84EWi0BupGPD6mfBwD1z6k4 /ynCLzFFwKN5sHovc8kZiv0FNcE9HTI7/8pwzwDqg/2kLi4g4Cm2huBgmjw7qknsFEug5qmMf 9kJZ0J98u+kkfQvNJ/boqZh5fXjshK/d8sDFpK+kmsa2HokYvAHA8Xzg4EeD5c+daG/tXPIHk 1WpRhMxmMdgtrMjM6rZbR6RIY3eJEZuFCDbuLYTVcDpPLCXZGp2FzBY2w05JpztLwnN2NfG8s y9q0oh7VVRruoChKoo5QsIkP9MrQjOysnUZWMG625Zg54Q6Kpig1KEaftemVYTbOwOVtNZl9D 3XCBipEPUXxWrQVgpW1CCYDtlrRKqrXWegkKK8/Fng6fbHQHwdPjTkJJcln85wqUuEVi2mx2J jD/2k98Rs8QdNV4QoUFBSkDLFyNovJ/r//CUVSSB2uSBa7hJh4+58NPvmWk/iW64x9KC5nZ/9 aqnz0Inl15ybGfeli6I6ouNRftwfD3DrJ+w/mUwlVG136mIczY22nVSnLqJWNZcT6kDfVR5en 6NcveK5cFzc8mXx5riq1oDEqtPfkNn635WMaVbRpqPhFwwNn3I/Bas3+/cI07UCsoWV3t7zVd Cu6OH5kyVC5tDA/55jj8XiJa7tj7Qa3mhSMrG4uYRPY366I61wBBAAA
X-Env-Sender: Alexander.Vainshtein@ecitele.com
X-Msg-Ref: server-12.tower-267.messagelabs.com!1540216245!995996!1
X-Originating-IP: [52.33.64.93]
X-SYMC-ESS-Client-Auth: mailfrom-relay-check=pass
X-StarScan-Received:
X-StarScan-Version: 9.14.24; banners=ecitele.com,-,-
X-VirusChecked: Checked
Received: (qmail 27811 invoked from network); 22 Oct 2018 13:50:48 -0000
Received: from us-west-2b.mta.dlp.protect.symantec.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (52.33.64.93) by server-12.tower-267.messagelabs.com with AES256-SHA256 encrypted SMTP; 22 Oct 2018 13:50:48 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ECI365.onmicrosoft.com; s=selector1-ecitele-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oYU/HqMx/OOA4xuVct6g6KU5R82gf7sm3XFJdvIeLE0=; b=TKNyCPiwet2tOapDb79DxpN8/CHtFPtam2fycnj1VTNYh1wJQo70gHG5l5oYCNb0Nhez8iylZvpkttLrW/PFDhpelK8S/gtP5hxwUfHJtic0Lcv4Y6oBXCdn9D0C9QZECKea6x1tdtk+6NHFDy810hqq5S0ie59SieYR+Qzh9T0=
Received: from DB5PR0301MB1909.eurprd03.prod.outlook.com (10.167.226.155) by DB5PR0301MB1911.eurprd03.prod.outlook.com (10.167.227.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Mon, 22 Oct 2018 13:50:43 +0000
Received: from DB5PR0301MB1909.eurprd03.prod.outlook.com ([fe80::d0bc:f20c:94cf:f479]) by DB5PR0301MB1909.eurprd03.prod.outlook.com ([fe80::d0bc:f20c:94cf:f479%2]) with mapi id 15.20.1250.028; Mon, 22 Oct 2018 13:50:43 +0000
From: Alexander Vainshtein <Alexander.Vainshtein@ecitele.com>
To: "draft-ietf-bess-l3vpn-yang@ietf.org" <draft-ietf-bess-l3vpn-yang@ietf.org>, "bess@ietf.org" <bess@ietf.org>, "stephane.litkowski@orange.com" <stephane.litkowski@orange.com>
Thread-Topic: Comments on L3VPN yang
Thread-Index: AdRqBnUNK3UHt6S0RS+mAKKFMAypbwAB8SAw
Date: Mon, 22 Oct 2018 13:50:43 +0000
Message-ID: <DB5PR0301MB19090F6B6369B45C217B35B39DF40@DB5PR0301MB1909.eurprd03.prod.outlook.com>
References: <11203_1540214688_5BCDCF94_11203_280_1_9E32478DFA9976438E7A22F69B08FF924B311A6A@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
In-Reply-To: <11203_1540214688_5BCDCF94_11203_280_1_9E32478DFA9976438E7A22F69B08FF924B311A6A@OPEXCLILMA4.corporate.adroot.infra.ftgroup>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [40.67.250.84]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; DB5PR0301MB1911; 6:y3D1XcLRD+AFkSvbMBA6blwXN23PJSEAJtcVJF+vEFPGLNOPHCZWFHUgJ+e1X2pMmkFv9qbIw1osHgVqum8mcsem1sts2Iw0vwKUnrbOl6nSsTyfmGwzZtBWiG70YvzOZhChfMkSuUil89UAQdGj4XUQtLnqJm3yoRFfohRkEYYNzm+cuuTjFTdbobNN69FhIujjW2wUx3t1qu3zwxTMS+yFKTw0Hs2BqfvkvPG1GTqccgeZuwK9tieJ5A/PaJaVsJrDdJEr/zdkGSJ8PnJS27dzj+ggnZb8IuaIqBkWpVqiQ8rRpjv58P6VQnTvXMNnmDDnukrdFc8Zsq1hVRxZsXe4siSfI/hPIylOaX9pUK2rKLTWsymi5DtpAxk6mViTA/yM8F/kXa5f8bcdoS7bEHj4Vg1KI3oncN2yvhdm74DL4scQwnZ65a5k4PrjtI9ckOrwc+Fru9ccopveshQSBw==; 5:+cSlPaMi1HivikB4wwHw13+BPlCGOTKfRVwQJv//t0Hz3tkvOFIh9jULx0+1eSo5RwrwDWpwyK9q3idH9aEEy2vv0g0aoa/6fhfG7Bq8REzsQhdMoQlUutq4vu5/LM9QtsaLa2T5Bj/V3l4nXB/xZk7krkOK2t9oR5L7v6f4O5Y=; 7:ISp9LRhh8c6hslrUsj24S7AREovyNrRqz2vtlnhO96mSVbsuiwERxK6KDqJxd7o1W/Wo9jMHcQbFk21dDhyGnirw37VTmRqAYiVAJTurwwFaeSoz3uyDmJlYhi+Y/mwCxOaaxKT9I14UCV9LjxLujZkFEKRTkpsIefzEq/JzufIlhLrXPJ4VRP4MrfZ5A9rOoXNcuuKvP5LmLY8/qUH/togthg/7mUinJRfj8vAKZF9KrjItN6INJGI/Qb/U4u2S
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: 61fc43f1-6a38-4d61-9fc8-08d638255c4b
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB5PR0301MB1911;
x-ms-traffictypediagnostic: DB5PR0301MB1911:
x-microsoft-antispam-prvs: <DB5PR0301MB19113486767B145EFFD63C559DF40@DB5PR0301MB1911.eurprd03.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(18271650672692)(161740460382875)(269456686620040);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:DB5PR0301MB1911; BCL:0; PCL:0; RULEID:; SRVR:DB5PR0301MB1911;
x-forefront-prvs: 08331F819E
x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(396003)(39860400002)(366004)(346002)(376002)(53754006)(199004)(57704003)(189003)(229853002)(7736002)(110136005)(8936002)(66066001)(6436002)(9686003)(71200400001)(71190400001)(54896002)(55016002)(53936002)(6246003)(486006)(476003)(446003)(11346002)(2501003)(5250100002)(2906002)(478600001)(53546011)(97736004)(2201001)(7696005)(33656002)(186003)(26005)(81166006)(316002)(8676002)(81156014)(25786009)(6506007)(86362001)(2900100001)(102836004)(76176011)(74316002)(106356001)(105586002)(14454004)(256004)(99286004)(5024004)(14444005)(5660300001)(72206003)(6116002)(3846002)(68736007)(32563001)(15785145003); DIR:OUT; SFP:1102; SCL:1; SRVR:DB5PR0301MB1911; H:DB5PR0301MB1909.eurprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ecitele.com does not designate permitted sender hosts)
x-microsoft-antispam-message-info: QHN9n4O1hEPSMhWXRE93GX1nzDq0/liAOA12WtOAF039XVj1k4bj24AO8U1kyPtz49sfYXVWF4cQ768DhiBkbup/n5n825VP2Gkwcs8k6GKW+BkE3gefxdv/bB9n8Xs7PKeLEH1YyflhNrQzUpoDl4Aap2xhpeIzloQODbRKwtUPbnQKombdLDl2dJTPM4dvYUrv3MxxbHCw0Nood0bFr6kQV8MVii69D6HS9U0Yx+r6dxILd0lYwn8ryCca8srueb63pugw9WHG7x2kDi7rQ7KiGm9bjhBEh/CC/XNmJCdnficL9odf41ZwhJ3lSWiaNNZMASLgz2AAfQZFCe75MpVRGgRtQWj0XmPm21CidbE=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_DB5PR0301MB19090F6B6369B45C217B35B39DF40DB5PR0301MB1909_"
MIME-Version: 1.0
X-OriginatorOrg: ecitele.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61fc43f1-6a38-4d61-9fc8-08d638255c4b
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2018 13:50:43.1888 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 2c514a61-08de-4519-b4c0-921fef62c42a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR0301MB1911
X-CFilter-Loop: Reflected
Archived-At: <https://mailarchive.ietf.org/arch/msg/bess/VmbBKIb04XoT7jDX_tQQSTKlF20>
Subject: Re: [bess] Comments on L3VPN yang
X-BeenThere: bess@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BGP-Enabled ServiceS working group discussion list <bess.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bess>, <mailto:bess-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bess/>
List-Post: <mailto:bess@ietf.org>
List-Help: <mailto:bess-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bess>, <mailto:bess-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Oct 2018 13:59:54 -0000

Hi all,
I fully agree with Stephane's point "the label mode should sit within the VRF and not at the BGP level. Each VRF may have a different flavor".  One relevant use case is the VRF that provides inet-subnet forwarding i EVPN with Symmetric IRB - it must use per-VRF label allocation policy with the label in question being advertised ad Label2 in MAC/IP Advertisement routes rgardless of how other VRFs allocate their labels.

My 2c.

Thumb typed by Sasha Vainshtein

________________________________
From: BESS <bess-bounces@ietf.org> on behalf of stephane.litkowski@orange.com <stephane.litkowski@orange.com>
Sent: Monday, October 22, 2018 4:24:35 PM
To: draft-ietf-bess-l3vpn-yang@ietf.org; bess@ietf.org
Subject: [bess] Comments on L3VPN yang

Hi Authors,

Please find some comments on the current model:

-          I don’t understand the “advertise-as-vpn” leaf under global-imports, what is the use case ?

-          Same question for “bgp-valid-route” leaf

-          Why do you have a long list of protocols within the global-imports ? Isn’t it the goal of the route-policy referenced earlier ? Moreover I do not think that it is a good idea to use the enum type here as protocol names ,when referring to, should not change across all routing configurations within a node.

-          Export to global may also require a policy to filter

-          Some description fields are just “.”

-          How do you plan the tunnel policy to be used ?

-          Would be great to have RTs configurable for both IPv4/IPv6 without redefining the config for each address family.

-          While I think the “forwarding-mode” under interface is a good thing, it looks really a Cisco like config statement that other implementations do not have. Wouldn’t it be better  to have a knob to enable mpls packet processing on an interface ; maybe in the MPLS yang model ?

-           What is the goal of the “route-policy” within “retain-route-targets” under the BGP peer AFI/SAFI ? I usually two use case (auto policy => import RTs are derived from VRF configuration, or keep all), what is the use case you want to address here ?

-          What is the “vpn-prefix-limit” within “retain-route-targets” under the BGP peer AFI/SAFI ? Is it a generic BGP prefix-limit ? If yes, we need to keep it generic within the BGP model.

-          IMO, the label mode should sit within the VRF and not at the BGP level. Each VRF may have a different flavor.

-          Why do you define bgp-label-mode and routing-table-limit for ipv4 unicast and ipv6 unicast ? Does not seem to be L3VPN related..

-          For iBGP PE-CE, notion of independent domain with attr-set usage seems to miss in the model

-          Unequal cost path loadbalancing option is missing from the VRF config

-          Do we need a config statement to enable local import/export between local VRFs ?

-          I suppose that IGP/BGP configuration in VRF is inherited from core routing model.

-          Do you have to enrich routing policy model with ability to set/delete/match RTs, SoOs ?

-          Do we have to create/enrich RIB-in/RIB-out/Loc-RIB entries for BGP L3VPN prefixes ?

-          What about PIC Edge/PE-CE link protection configuration ?

-          Need notification for the route table limit alert

-          Do we have operational states with number of IPv4 and IPv6 routes within the instance ?

-          Do we have everything to support Carrier’s of Carrier case ?


Brgds,

Stephane


_________________________________________________________________________________________________________________________

Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.

This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.


___________________________________________________________________________

This e-mail message is intended for the recipient only and contains information which is 
CONFIDENTIAL and which may be proprietary to ECI Telecom. If you have received this 
transmission in error, please inform us by e-mail, phone or fax, and then delete the original 
and all copies thereof.
___________________________________________________________________________