Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis

Alan Ford <alan.ford@gmail.com> Sun, 23 July 2017 08:01 UTC

Return-Path: <alan.ford@gmail.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3E218129AE7 for <bfcpbis@ietfa.amsl.com>; Sun, 23 Jul 2017 01:01:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pb7ga-xJIERq for <bfcpbis@ietfa.amsl.com>; Sun, 23 Jul 2017 01:01:24 -0700 (PDT)
Received: from mail-wr0-x231.google.com (mail-wr0-x231.google.com [IPv6:2a00:1450:400c:c0c::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5439B126DEE for <bfcpbis@ietf.org>; Sun, 23 Jul 2017 01:01:24 -0700 (PDT)
Received: by mail-wr0-x231.google.com with SMTP id y43so95369959wrd.3 for <bfcpbis@ietf.org>; Sun, 23 Jul 2017 01:01:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc:message-id:references :to; bh=euSQ9RQcDtHBMpnlNB02k+r8MhrW+/wr22axqFvY/+I=; b=X3PHzr/w/+FungvKNZAZcqYNzZfUkyzE6WHexaUXlZGgtzRlGx2UOSjOfxSmAQpab9 nwrE/WlsVjOt7p8OgPP9WSFbR9Uocytb0P7RfJFXP8GCXID3PhnKMWsIf2TiIkZPjHXa bcphdvheJsgowyWN/Yscdss89vTDRLznPawBFMOsDodrRRGlc5OjcsA6hqYUnjXcGDws 3zL6bvHrO3wlYSFMk5iFY0H2ukZUkenj4k37Y3XOi5DZeIodDOzOpNQhsrauFTEdkDg6 R380meIrObBXn31kqqk8s81WMonyA2cNR8bixARbwRiDWVJjmKJ1PGzZbF/46HiNBjWs wv/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; bh=euSQ9RQcDtHBMpnlNB02k+r8MhrW+/wr22axqFvY/+I=; b=sNrrV9JIU2m6+VONiEeKYtJ4+gyOc/FIIHgPeP3i2ft8U3Nxk1NMZKfH6JpFAQDOqt 2PELgBOZMTPZs7L3/tc6t2D/gkOKH3hIxfkPtR0qO2b4cfi0G7vQmdh0v9TMJkRzIuam lBIk2qjPRViSrrwAfNiZ0/yEN/d51Qq2KwSU9fqKcChCCdfNkyJGlTAkHe/Eb5SxJv2d x5wXIztETE6cMpE7bzfK1xm5Y5kHzQ7VRSc2MdYQV10Gs6SlWrEsNIGvXvFvQ/5afzAc m9pQgzW8wCT4mpIIxYp4aM5TebF5lOq8kUL4Ub1tW3Yav9xB8aqha0zo59b0ZyPE/bEC ZOHQ==
X-Gm-Message-State: AIVw111McTayWMDvthOHbKZCPxmXAC+XXzud49m+3oiXKinxV2li7kWF /XQdzPCxfi24jH4wZ87pUA==
X-Received: by 10.223.134.8 with SMTP id 8mr12885069wrv.62.1500796882772; Sun, 23 Jul 2017 01:01:22 -0700 (PDT)
Received: from [10.14.53.76] ([212.7.145.58]) by smtp.gmail.com with ESMTPSA id j28sm11406238wrb.9.2017.07.23.01.01.20 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 23 Jul 2017 01:01:21 -0700 (PDT)
Content-Type: multipart/alternative; boundary="Apple-Mail=_A6D3C387-F7EC-4AE0-8B57-0470FA95387A"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alan Ford <alan.ford@gmail.com>
In-Reply-To: <CA9D5614-1425-4F8E-8B05-AFCEFBA65507@cisco.com>
Date: Sun, 23 Jul 2017 09:01:19 +0100
Cc: "bfcpbis@ietf.org" <bfcpbis@ietf.org>, "Tom Kristensen (tomkrist)" <tomkrist@cisco.com>, Roman Shpount <rshpount@turbobridge.com>, Gonzalo Camarillo <Gonzalo.Camarillo@ericsson.com>, Christer Holmberg <christer.holmberg@ericsson.com>
Message-Id: <F5575EC0-2762-46E6-A875-300895B7A268@gmail.com>
References: <33AC90F8-1963-4F79-ACB2-0DB2873D5E34@cisco.com> <CA9D5614-1425-4F8E-8B05-AFCEFBA65507@cisco.com>
To: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/G9N0dlziViQq96oUOnsZNTqLfwQ>
Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Jul 2017 08:01:27 -0000

Hi Charles, all,

S3

- TCP transport indent is hard to parse. Suggest changing sentence to "Depending on the value of the 'setup' attribute (discussed in Section 8.1), the port field contains either the port to which the remote endpoint will direct BFCP messages, or in the case where the endpoint will initiate the connection towards the remote endpoint, should be set to a value of 9."


S4.1

- "The offerer includes this attribute to state all the roles it would be willing to perform”: add “once negotiation is complete”, for clarity.

- Here, plus S11.1 and S11.2, floorctrl is optional with inferred state of c-only for an offerer if it is not specified. I would advocate taking this opportunity to get rid of ambiguity and making the presence of floorctrl a MUST. Everyone does it already, but it’s one of the most problematic fields for interop as it is.

- Also, given in an answer only one role is present, but in an offer multiple can be present, can this be clearer in the ABNF? Is it possible to specify two ABNFs, one for the offer and one for the answer (the answer being without the *)? If that’s not possible, then could we at least emphasise this point near the start of the section (again coming at this from too many interop issues in this area).


S6

- “…identified by an SDP label attribute”. For consistency, please put ‘label’ in single quotes.

- Why is mstrm: optional in the ABNF, and optional in the paragraph beginning “The floorid attribute…”, yet is mandatory in the “Endpoints that use the offer/answer…” section? If there is a genuine reason for it to be optional please specify this, however I think it would be easier just to make it mandatory.


S11

Is is required to have a BUNDLE table like this now? (I presume given draft-ietf-mmusic-sdp-mux-attributes-16 is in MISSREF it’s too late to make the updates there). As Christer mentioned, It think this would be better in S7. OR, a separate subsection under S11 for “BUNDLE Considerations” that makes it clearer that this is an update to draft-ietf-mmusic-sdp-mux-attributes-16.

I assume we don’t want to go down the rabbit hole of defining BUNDLE for BFCP at this stage? :-)  Since if we did, it probably wouldn’t be too hard - you can demux on confid + userid.


S14.2

The “Allowed attribute values” here is inconsistent compared to others by being ABNF rather than just “A token” or “Tokens”. It’s also wrong - it implies only one value, not multiple as is the case. Suggest either fixing the ABNF or saying “one or more of…” or similar.


Best regards,
Alan

> On 19 Jul 2017, at 11:22, Charles Eckel (eckelcu) <eckelcu@cisco.com> wrote:
> 
> (As WG co-chair)
> 
> Thanks to those who provided reviews. We have decided to extend WGLC an additional week, through July 25, to provide folks tied up with other IETF matters time to complete their reviews.
> 
> Cheers,
> Charles 
> 
> -----Original Message-----
> From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Charles Eckel <eckelcu@cisco.com>
> Date: Monday, July 17, 2017 at 10:10 AM
> To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
> Cc: Tom Kristensen <tomkrist@cisco.com>, Roman Shpount <rshpount@turbobridge.com>, Alan Ford <alan.ford@gmail.com>, Gonzalo Camarillo <Gonzalo.Camarillo@ericsson.com>, Christer Holmberg <christer.holmberg@ericsson.com>
> Subject: Re: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
> 
>    (As WG co-chair)
> 
>    This is a reminder that WGLC ends tomorrow. I realize the time to review overlaps with IETF prep and meeting times. If you require more time to review the draft, please let me know. Otherwise, please share your review comments by the end of tomorrow.
> 
>    Thanks,
>    Charles
> 
>    -----Original Message-----
>    From: bfcpbis <bfcpbis-bounces@ietf.org> on behalf of Charles Eckel <eckelcu@cisco.com>
>    Date: Wednesday, July 5, 2017 at 5:59 PM
>    To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
>    Subject: [bfcpbis] WGLC for draft-ietf-bfcpbis-rfc4583bis
> 
>        (As WG co-chair)
> 
>        This is to announce an additional working group last call for draft-ietf-bfcpbis-rfc4583bis, "Session Description Protocol (SDP) Format for Binary Floor Control Protocol (BFCP) Streams".
>        http://datatracker.ietf.org/doc/draft-ietf-bfcpbis-rfc4583bis/
> 
>        This is intended as a Standards Track RFC, obsoleting RFC 4583.
>        Please respond to the list by July 18th (i.e. 2 weeks) with any comments.
> 
>        We had a working group last call previous, but a significant amount of time and some substantial changes and additions have occurred to justify another review of the draft in its entirely. It is helpful to attempt to categorize your comment (e.g. technical issue vs. editorial), and also to provide any replacement text you feel is necessary.
>        If you review the document and have no comments, please tell the chairs that you have reviewed it. This is always useful information in assessing the degree of WG review and consensus behind the document.
>        Note, we have not scheduled a working group session for IETF 99 in Prague. This WGLC will close during IETF 99. If helpful, we can arrange a side meeting to discuss any significant issues, or with any luck, gather at a bar to celebrate the draft being ready to advance to the next step toward RFC.
> 
>        Cheers,
>        Charles
> 
> 
>        _______________________________________________
>        bfcpbis mailing list
>        bfcpbis@ietf.org
>        https://www.ietf.org/mailman/listinfo/bfcpbis
> 
> 
>    _______________________________________________
>    bfcpbis mailing list
>    bfcpbis@ietf.org
>    https://www.ietf.org/mailman/listinfo/bfcpbis
> 
>