Re: [bfcpbis] Review of draft-ietf-bfcpbis-bfcp-websocket-04

"Gonzalo Salgueiro (gsalguei)" <gsalguei@cisco.com> Fri, 21 August 2015 05:33 UTC

Return-Path: <gsalguei@cisco.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 604A41A8758 for <bfcpbis@ietfa.amsl.com>; Thu, 20 Aug 2015 22:33:28 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.51
X-Spam-Level:
X-Spam-Status: No, score=-14.51 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zdPEvHZyZfAm for <bfcpbis@ietfa.amsl.com>; Thu, 20 Aug 2015 22:33:26 -0700 (PDT)
Received: from alln-iport-7.cisco.com (alln-iport-7.cisco.com [173.37.142.94]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D0BC31A8753 for <bfcpbis@ietf.org>; Thu, 20 Aug 2015 22:33:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=8113; q=dns/txt; s=iport; t=1440135206; x=1441344806; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=CRhPqVVBaTzAscNeaJMFmrW5ppBy6j0PkELD6zf7ik4=; b=bem+V6T2Hi9Orh0geVDalYfynsqjCdeadIoH/Dodx3K3fjvpSWn5FErf eeG99jDOUC1X7QCLPl5SiSjykuVUyfANnkvKwNxoGffSsZpvmiTv03eBe 5xnXw15BMt/beSdX8GxbV9o+Pg7YVSe+qwcK6MmSdKLiontTiLyNtFcQi o=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0B7AgA4t9ZV/4MNJK1dgxtUWg8GvVIBCYFtAQmFMUoCgTs4FAEBAQEBAQGBCoQjAQEBBAEBAWsLEAIBCBEDAQIoBycLFAkIAgQOBYguDc8jAQEBAQEBAQEBAQEBAQEBAQEBAQEBEwSLU4R5DQQHgxiBFAWVKQGFBIdqgUqQQIRIg2kmg31xgUiBBAEBAQ
X-IronPort-AV: E=Sophos;i="5.15,720,1432598400"; d="scan'208,217";a="180631969"
Received: from alln-core-1.cisco.com ([173.36.13.131]) by alln-iport-7.cisco.com with ESMTP; 21 Aug 2015 05:33:25 +0000
Received: from XCH-RCD-014.cisco.com (xch-rcd-014.cisco.com [173.37.102.24]) by alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id t7L5XOS5010814 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 21 Aug 2015 05:33:24 GMT
Received: from xch-rcd-014.cisco.com (173.37.102.24) by XCH-RCD-014.cisco.com (173.37.102.24) with Microsoft SMTP Server (TLS) id 15.0.1104.5; Fri, 21 Aug 2015 00:33:23 -0500
Received: from xhc-rcd-x07.cisco.com (173.37.183.81) by xch-rcd-014.cisco.com (173.37.102.24) with Microsoft SMTP Server (TLS) id 15.0.1104.5 via Frontend Transport; Fri, 21 Aug 2015 00:33:23 -0500
Received: from xmb-rcd-x04.cisco.com ([169.254.8.103]) by xhc-rcd-x07.cisco.com ([173.37.183.81]) with mapi id 14.03.0248.002; Fri, 21 Aug 2015 00:33:23 -0500
From: "Gonzalo Salgueiro (gsalguei)" <gsalguei@cisco.com>
To: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>
Thread-Topic: [bfcpbis] Review of draft-ietf-bfcpbis-bfcp-websocket-04
Thread-Index: AQHQ24v2tJFpZs3eTEKDBmLDmBoP2p4WQpSA
Date: Fri, 21 Aug 2015 05:33:22 +0000
Message-ID: <676DBA71-E49F-4D86-B82E-8263D70B6C35@cisco.com>
References: <D1FB8E67.55AD7%eckelcu@cisco.com>
In-Reply-To: <D1FB8E67.55AD7%eckelcu@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [173.36.7.16]
Content-Type: multipart/alternative; boundary="_000_676DBA71E49F4D86B82E8263D70B6C35ciscocom_"
MIME-Version: 1.0
Archived-At: <http://mailarchive.ietf.org/arch/msg/bfcpbis/OsM25yzNxHIxJQsRYfPoTq8TeZI>
Cc: "Ram Mohan R (rmohanr)" <rmohanr@cisco.com>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>, "alissa@cooperw.in" <alissa@cooperw.in>, Christer Holmberg <christer.holmberg@ericsson.com>
Subject: Re: [bfcpbis] Review of draft-ietf-bfcpbis-bfcp-websocket-04
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Aug 2015 05:33:28 -0000

@Charles - Ram and I are working on the updated version and hope to publish it very soon. One additional request below.

@Christer - It would be helpful to get your review of the complementary draft you requested (draft-ram-bfcpbis-sdp-ws-uri-00<https://tools.ietf.org/html/draft-ram-bfcpbis-sdp-ws-uri-00>). That way we can update both at the same time. Let us know if this is something forthcoming.

Thanks,

Gonzalo


On Aug 20, 2015, at 5:05 PM, Charles Eckel (eckelcu) <eckelcu@cisco.com<mailto:eckelcu@cisco.com>> wrote:

Christer,

Thanks for the review and comments.

Draft authors, when can we expect responses to Christer’s comments, and/or a corresponding update to the draft?

Cheers,
Charles

From: bfcpbis <bfcpbis-bounces@ietf.org<mailto:bfcpbis-bounces@ietf.org>> on behalf of Christer Holmberg <christer.holmberg@ericsson.com>
Date: Thursday, July 2, 2015 at 11:12 AM
To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
Cc: "alissa@cooperw.in" <alissa@cooperw.in>
Subject: [bfcpbis] Review of draft-ietf-bfcpbis-bfcp-websocket-04

Hi,

Below is my review of draft-ietf-bfcpbis-bfcp-websocket-04.

In general, things look good, and my comments should be mostly editorial. Also, my previous comments on the draft have been addressed. Thanks forthat!

Q1: There are a few abbreviations (TLS, HTTP etc) that are not expanded on first occurrence. I didn’t check whether they are considered well knowndouble check.

Q2: I think the last paragraph of section 1, talking about not preventing other mechanisms, can be removed completely.

(I think I previously had the same comment on the draft – or maybe it was another WebSocket sub-protocol draft)

Q3: Section one says “since WebSocket is a reliable transport”. Perhaps “provides a reliable transport” would be better?

Q4: Section 5 says “WebSocket [RFC6455] is a reliable protocol”. I don’t know what “reliable protocol” means, but I assume this text should also talkabout providing reliable transport.

Q5: In section 6.1, there should be a reference for the ‘setup’ attribute. Also, when talking about SDP attributes, I’d suggest to explicitly say“SDP setup attribute”, or something similar.

Q6: The introduction says that the draft updates rfc4582bis and rfc4583bis. I think it would be good to have two explicit “Updates to RFCXXXX” sectionsto list exactly what those updates are.

Q7: Just to check: are the new SDP m- line proto values aligned with the naming approach that has taken place in MMUSIC?

Regards,

Christer





_______________________________________________
bfcpbis mailing list
bfcpbis@ietf.org
https://www.ietf.org/mailman/listinfo/bfcpbis