Re: [bfcpbis] IESG AD reviews of draft-ietf-bfcpbis-rfc4583bis-26: The Pull Request

-----Original Message-----
From: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Wednesday, December 5, 2018 at 7:49 PM
To: Charles Eckel <eckelcu@cisco.com>, Ben Campbell <ben@nostrum.com>, Benjamin Kaduk <kaduk@mit.edu>, Eric Rescorla <ekr@rtfm.com>, "resnick@episteme.net" <resnick@episteme.net>
Cc: "bfcpbis@ietf.org" <bfcpbis@ietf.org>, Mary Barnes <mary.ietf.barnes@gmail.com>, The IESG <iesg@ietf.org>, "draft-ietf-bfcpbis-rfc4583bis@ietf.org" <draft-ietf-bfcpbis-rfc4583bis@ietf.org>
Subject: Re: [bfcpbis] IESG AD reviews of draft-ietf-bfcpbis-rfc4583bis-26: The Pull Request

    Hi,

    >I have reviewed the pull requests. All the changes look good to me. Just a few things I suggest updating,
    >    
    > Line 184/5, I do not understand the point this sentence is making and think it can be removed, "As a result, each 
    > endpoint will take the same role for each BFCP-controlled media stream associated with the BFCP stream."

    In RFC 4583 is was allowed (eventhough the procedures were underspecified) for endpoint to have different roles for different media streams. We agreed to change that in 4583bis, and the statement above reflects that decision. Since it is a change from 4583, I think it is useful to have it.

I agree we need to say something about c-s. The complete text is as follow.

In <xref target="RFC4583"/>, there was a third attribute specified, "c-s", which meant that an endpoint was willing to act as both floor control client and floor control server at the same time for the BFCP stream, taking different roles for different BFCP-controlled media streams. The feature was underspecified and implemented in different ways, in particular many implementations interpreted "c-s” to mean that the endpoint is willing to act as either client or server (equivalent to “c-only s-only”). An implementation compliant to this specification MUST NOT include the "c-s" floorctl attribute value in an offer or in an answer, but MUST accept the attribute value in an offer and process it as equivalent to "c-only s-only" (or "s-only c-only"). As a result, each endpoint will take the same role for each BFCP-controlled media stream associated with the BFCP stream.

Overall, I like this paragraph and agree it is useful. The issue I have is with the last sentence only. Is it saying that as a result of interpreting "c-s" as "c-only, s-only" the end result will be the same as what was intended by the offerer when they stated "c-s"? That may be true, but the wording is subject to interpretation and I think the paragraph stands up fine without this sentence. I suggest reducing to the following:

In <xref target="RFC4583"/>, there was a third attribute specified, "c-s", which meant that an endpoint was willing to act as both floor control client and floor control server at the same time for the BFCP stream, taking different roles for different BFCP-controlled media streams. The feature was underspecified and implemented in different ways, in particular many implementations interpreted "c-s” to mean that the endpoint is willing to act as either client or server (equivalent to “c-only s-only”). An implementation compliant to this specification MUST NOT include the "c-s" floorctl attribute value in an offer or in an answer, but MUST accept the attribute value in an offer and process it as equivalent to "c-only s-only" (or "s-only c-only").

Cheers,
Charles

    > Line 551, s/corresponding offer.; and/corresponding offer; and

    Will fix.

    > Line 586, s/an answer, that contains/an answer that contains

    Will fix.

    > Lines 710/11, I disputed the accuracy of this statement in another thread, "nor do they reveal which media streams will be 
    > BFCP controlled." I think this last statement should be removed.

    I suggested new text in a separate reply.

    Regards,

    Christer

        -----Original Message-----
        From: Christer Holmberg <christer.holmberg@ericsson.com>
        Date: Tuesday, December 4, 2018 at 12:57 AM
        To: Ben Campbell <ben@nostrum.com>, Charles Eckel <eckelcu@cisco.com>, Benjamin Kaduk <kaduk@mit.edu>, Eric Rescorla <ekr@rtfm.com>, "resnick@episteme.net" <resnick@episteme.net>
        Cc: "bfcpbis@ietf.org" <bfcpbis@ietf.org>, Mary Barnes <mary.ietf.barnes@gmail.com>, The IESG <iesg@ietf.org>, "draft-ietf-bfcpbis-rfc4583bis@ietf.org" <draft-ietf-bfcpbis-rfc4583bis@ietf.org>, "bfcpbis-chairs@ietf.org" <bfcpbis-chairs@ietf.org>
        Subject: Re: [bfcpbis] IESG AD reviews of draft-ietf-bfcpbis-rfc4583bis-26: The Pull Request

            Correct e-mail address for Pete.

            On 03/12/2018, 17.51, "Christer Holmberg" <christer.holmberg@ericsson.com> wrote:

                Hi,

                The fourth commit includes additional changes based on Benjamin's and Ekr's reviews, and changes based on Pete's gen-art review.

                https://github.com/cdh4u/draft-bfcp-4583bis/pull/13

                At this point I do NOT intend to make further changes based on the IESG review, so please take a look and let me know whether I have forgotten something, or whether I did something wrong.

                Regards,

                Christer

                Ps. Ekr, I got rid of most of the "associated" terminology from the O/A section. There is still some, but the text now talks about "including attributes in m sections", similar to BUNDLE.

                On 03/12/2018, 9.53, "bfcpbis on behalf of Christer Holmberg" <bfcpbis-bounces@ietf.org on behalf of christer.holmberg@ericsson.com> wrote:

                    Hi,

                    The third commit includes changes based on Benjamin's and Ekr's reviews.

                    Regards,

                    Christer

                    On 02/12/2018, 13.34, "bfcpbis on behalf of Christer Holmberg" <bfcpbis-bounces@ietf.org on behalf of christer.holmberg@ericsson.com> wrote:

                        Hi,

                        The second commit includes changes (all but the one related to the MUX category) based on Ben's review.

                        Regards,

                        Christer

                        On 02/12/2018, 13.32, "Christer Holmberg" <christer.holmberg@ericsson.com> wrote:

                            Hi,

                            I have created a pull request that will include the changes based on the AD reviews.

                            The first commit includes changes based on Alexey's review.

                            https://github.com/cdh4u/draft-bfcp-4583bis/pull/13

                            Regards,

                            Christer

                        _______________________________________________
                        bfcpbis mailing list
                        bfcpbis@ietf.org
                        https://www.ietf.org/mailman/listinfo/bfcpbis

                    _______________________________________________
                    bfcpbis mailing list
                    bfcpbis@ietf.org
                    https://www.ietf.org/mailman/listinfo/bfcpbis