Re: [bfcpbis] Alexey Melnikov's No Objection on draft-ietf-bfcpbis-rfc4583bis-26: (with COMMENT)

["Charles Eckel (eckelcu)" <[e-mail]>]

Please see inline, marked with [cue]

-----Original Message-----
From: Christer Holmberg <[e-mail]>
Date: Sunday, December 2, 2018 at 3:32 AM
To: Alexey Melnikov <[e-mail]>, Charles Eckel <[e-mail]>
Cc: "[e-mail]" <[e-mail]>, Mary Barnes <[e-mail]>, The IESG <[e-mail]>, "[e-mail]" <[e-mail]>, "[e-mail]" <[e-mail]>
Subject: Re: [bfcpbis] Alexey Melnikov's No Objection on draft-ietf-bfcpbis-rfc4583bis-26: (with COMMENT)

    Hi,
    
    I suggest to add to add the following:
    
    "The maximum length of the attribute value is determined by the COMMON-HEADER format [reference-to-4582bis]."

[cue] I agree; however, I think it would be better to replace maximum length with maximum value.

Cheers,
Charles
    
    Regards,
    
    Christer
    
    
    
    On 24/10/2018, 13.02, "bfcpbis on behalf of Alexey Melnikov" <[e-mail] on behalf of [e-mail]> wrote:
    
        Hi Charles,
        
        > On 23 Oct 2018, at 18:56, Charles Eckel (eckelcu) <[e-mail]> wrote:
        > 
        > Hi Alexey,
        > 
        > Thank you for your review and comments.
        > The maximum value for each of these is determined by the COMMON-HEADER format in https://tools.ietf.org/html/draft-ietf-bfcpbis-rfc4582bis-16#section-5.1.
        
        I think adding a cross reference would help readers/implementors.
        
        Best Regards,
        Alexey
        
        > Cheers,
        > Charles
        > 
        > -----Original Message-----
        > From: Alexey Melnikov <[e-mail]>
        > Date: Tuesday, October 23, 2018 at 3:44 PM
        > To: The IESG <[e-mail]>
        > Cc: "[e-mail]" <[e-mail]>, "[e-mail]" <[e-mail]>, Mary Barnes <[e-mail]>, "[e-mail]" <[e-mail]>
        > Subject: Alexey Melnikov's No Objection on draft-ietf-bfcpbis-rfc4583bis-26: (with COMMENT)
        > Resent-From: <[e-mail]>
        > Resent-To: Charles Eckel <[e-mail]>, Keith Drage <[e-mail]>
        > Resent-Date: Tuesday, October 23, 2018 at 3:44 PM
        > 
        >    Alexey Melnikov has entered the following ballot position for
        >    draft-ietf-bfcpbis-rfc4583bis-26: No Objection
        > 
        >    When responding, please keep the subject line intact and reply to all
        >    email addresses included in the To and CC lines. (Feel free to cut this
        >    introductory paragraph, however.)
        > 
        > 
        >    Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
        >    for more information about IESG DISCUSS and COMMENT positions.
        > 
        > 
        >    The document, along with other ballot positions, can be found here:
        >    https://datatracker.ietf.org/doc/draft-ietf-bfcpbis-rfc4583bis/
        > 
        > 
        > 
        >    ----------------------------------------------------------------------
        >    COMMENT:
        >    ----------------------------------------------------------------------
        > 
        >    I have one small issue with this document which applies to several sections:
        > 
        >    5.2.  SDP 'confid' Attributes
        > 
        >           The Augmented BNF syntax [RFC5234] for the attribute is:
        > 
        >             conference-id = 1*DIGIT
        > 
        >    Is there any limit on the maximum allowed value of this attribute?
        > 
        > 
        >    The same issue in all the following sections where "1*DIGIT" construct is used:
        > 
        >    5.3.  SDP 'userid' Attribute
        > 
        >    5.4.  SDP 'floorid' Attribute
        > 
        >    5.5.  SDP 'bfcpver' Attribute
        > 
        > 
        > 
        > 
        
        _______________________________________________
        bfcpbis mailing list
        [e-mail]
        https://www.ietf.org/mailman/listinfo/bfcpbis