[bfcpbis] WGLC comments on draft-ietf-bfcpbis-rfc4583bis-17

"Charles Eckel (eckelcu)" <eckelcu@cisco.com> Mon, 17 July 2017 11:23 UTC

Return-Path: <eckelcu@cisco.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 29B89131461 for <bfcpbis@ietfa.amsl.com>; Mon, 17 Jul 2017 04:23:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -14.523
X-Spam-Level:
X-Spam-Status: No, score=-14.523 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2Z64o3J9XGes for <bfcpbis@ietfa.amsl.com>; Mon, 17 Jul 2017 04:23:11 -0700 (PDT)
Received: from alln-iport-4.cisco.com (alln-iport-4.cisco.com [173.37.142.91]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A438512EBF9 for <bfcpbis@ietf.org>; Mon, 17 Jul 2017 04:23:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2042; q=dns/txt; s=iport; t=1500290591; x=1501500191; h=from:to:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=aa/CJBTHV/8EG4G8HFTWjSlbxITRTJqe+/n3kveRkyg=; b=RLy6w4wvxjHRnFxrP8OOzD3rOSyAvqqyrLlu0AmJDpOS7JQljJlv65mA 1O5IWOV1zKWYjekZ/CbpGxDOCR6cUSGkBz+EiehQxuXpQBF4m+zQLnIad gKYP5RzkEO/pxW7cI+kmIwWfDt58J5EUbMClyO/imIAdkrsu6P+UOVPli Q=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0CPAQAlnWxZ/5ldJa1cHAEBBAEBCgEBg1qBf44Ep2OCEYVjg10/GAECAQEBAQEBAWsdC4VCETMkASICJgIEMBUSBIpCrx6CJosUAQEBAQEBBAEBAQEBAQEBAR+BC4IdhS4rh02DKTCCMQWfNAKUFAySI5VWAR84gQp1FVsBhwOIdYENAQEB
X-IronPort-AV: E=Sophos;i="5.40,374,1496102400"; d="scan'208";a="454559764"
Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by alln-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2017 11:23:10 +0000
Received: from XCH-ALN-020.cisco.com (xch-aln-020.cisco.com [173.36.7.30]) by rcdn-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id v6HBNAjC010318 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL) for <bfcpbis@ietf.org>; Mon, 17 Jul 2017 11:23:10 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-ALN-020.cisco.com (173.36.7.30) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 17 Jul 2017 06:23:10 -0500
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1210.000; Mon, 17 Jul 2017 06:23:09 -0500
From: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>
To: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
Thread-Topic: WGLC comments on draft-ietf-bfcpbis-rfc4583bis-17
Thread-Index: AQHS/u8RWy/WH/x8I0ykG34nrHqszw==
Date: Mon, 17 Jul 2017 11:23:09 +0000
Message-ID: <E536B846-B992-48C7-B1A6-4134C58C9B43@cisco.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/f.22.0.170515
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.61.101.212]
Content-Type: text/plain; charset="utf-8"
Content-ID: <D2E70831A35021458AF81E23DB9EC059@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/o95r9bdaAdmbCpAqiXH6XIbPPmo>
Subject: [bfcpbis] WGLC comments on draft-ietf-bfcpbis-rfc4583bis-17
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Jul 2017 11:23:13 -0000

(as an individual)

I have reviewed the draft. I do not have any technical or major issues with it.
I do have some editorial comments and suggestions.

Globally
Use reestablish or re-establish but not both.

Pg 1. 
s/ Changes from RFC 4583 are summarized in Section 14/ Changes from RFC 4583 are summarized in Section 15

Pg 4.
s/ both the offerer and the answerer act/ both endpoints act

Pg 6.
s/ When this attribute appears in an answer, it only carries one role/ When a “floorctrl” attribute appears in an answer, it MUST include one and only role

Pg 9.
s/ the answerer which may be the client or the floorcontrol server acts/ the answerer, which may be the client or the floorcontrol server, acts

Pg 10.
s/ same BFCP session and DTLS associations/ same BFCP session and DTLS association

Pg 11.
s/ the SDP 'fingerprint' attribute [7], if the endpoint supports, and is willing to use, a cipher suite with an associated certificate./ the SDP 'fingerprint' attribute [10].

Pg 14.
s/ If the BFCP connection is carried on top of TCP, and unless the offerer wants to re-establish an existing TCP connection, the offerer MUST associate an SDP connection attribute, with an 'existing' value, with the 'm' line/ If the BFCP connection is carried on top of TCP and the offerer does not want to re-establish an existing TCP connection, the offerer MUST associate an SDP connection attribute with an 'existing' value with the 'm' line

Cheers,
Charles