IETF Logo Mail Archive

Re: [bfcpbis] AD Review of draft-ietf-bfcpbis-rfc4583bis-24: role issue - The pull request

Christer Holmberg <christer.holmberg@ericsson.com> Thu, 20 September 2018 14:14 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 10FE9130F17 for <bfcpbis@ietfa.amsl.com>; Thu, 20 Sep 2018 07:14:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.31
X-Spam-Level:
X-Spam-Status: No, score=-4.31 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XcpJCGsBc8Od for <bfcpbis@ietfa.amsl.com>; Thu, 20 Sep 2018 07:14:26 -0700 (PDT)
Received: from sessmg23.ericsson.net (sessmg23.ericsson.net [193.180.251.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7DBA0130F1D for <bfcpbis@ietf.org>; Thu, 20 Sep 2018 07:14:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1537452863; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SDcmTabowoyepY+3bMnCSl8PQEXHOMpoJuQE5Ndig60=; b=LiP4EGMRa6XS3y+4tqXvdRLgiGhnaGQ9NYzD0yZlpTfTAuP7SmOUvaOqukOdnprG Lf3FL7OuqzmAUakWT0+NWHFB5NUY3+RDfBzrg+Weq16I9EMwazEOzqZ7EebyZBp2 Hk8ItPl+zTEm801UIa9HWc0g39Wq5mkVG8oGC6HRRFs=;
X-AuditID: c1b4fb2d-20bff700000055ff-69-5ba3ab3fba7e
Received: from ESESBMB505.ericsson.se (Unknown_Domain [153.88.183.118]) by sessmg23.ericsson.net (Symantec Mail Security) with SMTP id 56.68.22015.F3BA3AB5; Thu, 20 Sep 2018 16:14:23 +0200 (CEST)
Received: from ESESBMB503.ericsson.se (153.88.183.170) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 20 Sep 2018 16:14:23 +0200
Received: from ESESBMB503.ericsson.se ([153.88.183.186]) by ESESBMB503.ericsson.se ([153.88.183.186]) with mapi id 15.01.1466.003; Thu, 20 Sep 2018 16:14:23 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Alan Ford <alan.ford@gmail.com>
CC: "bfcpbis@ietf.org" <bfcpbis@ietf.org>
Thread-Topic: [bfcpbis] AD Review of draft-ietf-bfcpbis-rfc4583bis-24: role issue - The pull request
Thread-Index: AdRLeDAXQdw2ACGbThquOLmME3BJeQErzWQAAAaj0ID///fwAIABcAKA
Date: Thu, 20 Sep 2018 14:14:22 +0000
Message-ID: <1207D13A-18BE-4C18-BE7B-11A01041CFAA@ericsson.com>
References: <24eb743e07ff4af087ab36f1c4fe050e@ericsson.com> <96BA408A-8034-4558-BFEA-2FD2A2FE506C@gmail.com> <e54f48b925af41e28cb4f290af9b64ae@ericsson.com> <48CA7041-9F99-4308-AA03-F480E1A70744@gmail.com>
In-Reply-To: <48CA7041-9F99-4308-AA03-F480E1A70744@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.10.0.180812
x-originating-ip: [153.88.183.157]
Content-Type: multipart/alternative; boundary="_000_1207D13A18BE4C18BE7B11A01041CFAAericssoncom_"
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBIsWRmVeSWpSXmKPExsUyM2J7ma796sXRBvPfaFmsPLeC2eLfuqNM DkweO2fdZfdYsuQnUwBTFJdNSmpOZllqkb5dAlfGlYvz2At+z2OseHW2lb2B8dYsxi5GTg4J AROJzzfeM3UxcnEICRxllGj6cxbK+cYocXrvLFYIZxmjxPl/LSxdjBwcbAIWEt3/tEFMEQFl ieUgJZwczAKaElcP7wIbKiyQKnF96RI2EFtEIE3ix/o2KNtN4s735cwgNouAqsT87ZfB4rwC 9hLzL84Fs4UELjNKLJpfBWJzCthKnN5yjwXEZhQQk/h+ag0TxC5xiVtP5jNBPCAgsWTPeWYI W1Ti5eN/rCCniQroS0y7HAARVpLY0rsFqjVZ4tyBN1BrBSVOznzCMoFRbBaSqbOQlM1CUjYL aCrIl+t36UOUKEpM6X7IDmFrSLTOmQtlW0vc6v7AiqxmASPHKkbR4tTi4tx0I2O91KLM5OLi /Dy9vNSSTYzA+Dy45bfuDsbVrx0PMQpwMCrx8K5cuDhaiDWxrLgy9xCjBAezkghvUQ9QiDcl sbIqtSg/vqg0J7X4EKM0B4uSOK/eqj1RQgLpiSWp2ampBalFMFkmDk6pBkb94ucxFnzrk35f t3Vs5vrRUbB142u7wMvbWOc4zppwcFLz1AUnWLND9q679C1Rz2SpaMuPojLfAMNfVQfb2W9/ uC1/0nxGapjTnQNGk67q9zxsL5wiy7T1nso5E/YiveeTo4ITeEonqhsxz3o786IoS1e74L+C W7uWvS/QalPpn9Kzp/9K8UklluKMREMt5qLiRACzzaXEywIAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/o_AIMEAjjyZ3_Kbvf3gGbrI8IBo>
Subject: Re: [bfcpbis] AD Review of draft-ietf-bfcpbis-rfc4583bis-24: role issue - The pull request
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Sep 2018 14:14:36 -0000

Hi Alan,

> Sounds good to me! Minor wordsmithing...
>
> “was underspecified and implemented in different ways, in particular many implementations interpreted "c-s” to mean
> that the endpoint is willing to act as either client or server (equivalent to “c-only s-only”).”

Sounds good.

Regards,
Alan


On 19 Sep 2018, at 19:06, Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>> wrote:

Hi Alan,

A few points regarding your suggested text:

1)      There is no BFCPv2. We need to talk about “An implementation compliant to this specification”, or something like that.
2)      I think we shall say “MUST accept "c-s" as equivalent to "c-only s-only", because that is consistent and testable.
3)      Instead of saying “was not implemented as specified”, I would say “was underspecified, and implemented in different ways, e.g., some implementations interpreted ”c-s” meaning that endpoint is willing to act as either client or server (equivalent to “c-only s-only”).”.

Regards,

Christer

From: Alan Ford [mailto:alan.ford@gmail.com]
Sent: 19 September 2018 19:45
To: Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>>
Cc: bfcpbis@ietf.org<mailto:bfcpbis@ietf.org>
Subject: Re: [bfcpbis] AD Review of draft-ietf-bfcpbis-rfc4583bis-24: role issue - The pull request

Hi Christer, all,

I’ve just added some review comments to the PR. One sentence still needs to be removed, and I think we need to be stronger with the clarification of the deprecation, I propose a paragraph along the lines of:

In RFC4583, there was a third option specified, "c-s", which meant that an endpoint was willing to act as floor control client and floor control server. This feature was not implemented as specified, and the implementations which did signal "c-s" used it to mean that the endpoint is willing to act as floor control client or floor control server. An implementation of BFCPv2 MUST NOT send "c-s" as a floorctl attribute value, but I
Regards,
Alan



On 13 Sep 2018, at 16:43, Christer Holmberg <christer.holmberg@ericsson.com<mailto:christer.holmberg@ericsson.com>> wrote:

Hi,

I have created a pull request for the role issue.

https://github.com/cdh4u/draft-bfcp-4583bis/pull/10

The pull request also updates references but does not address Adam's other issues.

Regards,

Christer

Ps. Note that I do not intend to submit a pull request for 4582bis. If changes are needed, I assume one of the authors will handle that.

_______________________________________________
bfcpbis mailing list
bfcpbis@ietf.org<mailto:bfcpbis@ietf.org>
https://www.ietf.org/mailman/listinfo/bfcpbis

v2.23.0 | Report a Bug | By Email