Re: [bfcpbis] Gen-ART Telechat review of draft-ietf-bfcpbis-rfc4582bis-13.txt
Alissa Cooper <alissa@cooperw.in> Fri, 11 September 2015 16:53 UTC
Return-Path: <alissa@cooperw.in>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EDEE51AD0B2 for <bfcpbis@ietfa.amsl.com>; Fri, 11 Sep 2015 09:53:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7] autolearn=unavailable
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jwAT5bhxZd4a for <bfcpbis@ietfa.amsl.com>; Fri, 11 Sep 2015 09:53:58 -0700 (PDT)
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 82FA31B3391 for <bfcpbis@ietf.org>; Fri, 11 Sep 2015 09:53:56 -0700 (PDT)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BAF4B20475 for <bfcpbis@ietf.org>; Fri, 11 Sep 2015 12:53:55 -0400 (EDT)
Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 11 Sep 2015 12:53:55 -0400
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=KrhuTrIXFwhsF78X8eM4B8rcEok=; b=ApfJ4v tVdElfMqLQQEv6PcvU7RydZ6A6OTjnzUzjFCRu2xbieMJVC91PvmFC+AQKPeTONX ZX7suZpTewFKqhqGBGD6c3LKHF4fyPcOj8Duj1e7Te1EIQgmj1ZIEgSQL+L0frGV 7prPe7U/k0f2Py8Eke1IhmI4b5kP3G5C+M3N8=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=KrhuTrIXFwhsF78 X8eM4B8rcEok=; b=Sd+5UVWwJ/5bJ+slmYBvdztVCSgiwDLAtP1sGiNkrLxN4Yc 9tifpmradqYRPKYO+nAX58EcXbyo081qQi+lpuG7TuNIVHEOMPaz6irpcml87z3D CbvJYIZPP11nTi8yJ6YGArfKnC2XFkcTwyMPAzXWlFNrmuIbPXV4coMz8Hxg=
X-Sasl-enc: 1D1j6+ZxIqTSEnKaTnMg6gpTt0vvf8+DlpJLzy4ql6Nu 1441990435
Received: from dhcp-171-68-21-63.cisco.com (dhcp-171-68-21-63.cisco.com [171.68.21.63]) by mail.messagingengine.com (Postfix) with ESMTPA id CF7DDC0028E; Fri, 11 Sep 2015 12:53:54 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <E87B771635882B4BA20096B589152EF63A8DB9BC@eusaamb107.ericsson.se>
Date: Fri, 11 Sep 2015 09:53:53 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <2ABB80A0-4323-46CF-91D2-162EEDEBF66F@cooperw.in>
References: <E87B771635882B4BA20096B589152EF628AF7B6F@eusaamb107.ericsson.se> <CAFHv=r9CPPDj4tv5HEUc8H6z4sQULfD76rkZADW_AsAmuFDisw@mail.gmail.com> <E87B771635882B4BA20096B589152EF63A8DB9BC@eusaamb107.ericsson.se>
To: Suresh Krishnan <suresh.krishnan@ericsson.com>
X-Mailer: Apple Mail (2.2104)
Archived-At: <http://mailarchive.ietf.org/arch/msg/bfcpbis/smChjTOiiGX3vfSs-iy6zLaatbw>
Cc: "draft-ietf-bfcpbis-rfc4582bis.all@tools.ietf.org" <draft-ietf-bfcpbis-rfc4582bis.all@tools.ietf.org>, Tom Kristensen <2mkristensen@gmail.com>, Tom Kristensen <tomkrist@cisco.com>, General Area Review Team <gen-art@ietf.org>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>, "Paul E. Jones (paulej@packetizer.com)" <paulej@packetizer.com>
Subject: Re: [bfcpbis] Gen-ART Telechat review of draft-ietf-bfcpbis-rfc4582bis-13.txt
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Sep 2015 16:54:00 -0000
Adding Paul to this thread as he will be helping resolve comments on this draft. > On Aug 24, 2015, at 12:58 PM, Suresh Krishnan <suresh.krishnan@ericsson.com> wrote: > > Hi Tom, > > On 08/20/2015 08:29 AM, Tom Kristensen wrote: >> Thanks for the Gen-ART review. Response and hopefully a resolution >> inline below. >> >> >> On 2 March 2015 at 18:19, Suresh Krishnan <suresh.krishnan@ericsson.com >> <mailto:suresh.krishnan@ericsson.com>> wrote: >> >> I am the assigned Gen-ART reviewer for this draft. For background on >> Gen-ART, please see the FAQ at >> <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq> >> >> Please wait for direction from your document shepherd or AD before >> posting a new version of the draft. >> >> Document: draft-ietf-bfcpbis-rfc4582bis-13.txt >> Reviewer: Suresh Krishnan >> Review Date: 2015/03/02 >> IESG Telechat date: 2015/03/05 >> >> Summary: This draft has significant issues that needs to be fixed before >> it is ready for publication as a Proposed Standard. >> >> Major: >> >> * Section 5.1: >> >> This section mandates the receiver to ignore the F bit if it is set >> while running over reliable transport. In my opinion this is not >> sufficient as the length of the header is determined by the bit being >> set. I strongly believe that this is an error condition and the packet >> should not be processed further. At the bare minimum, the draft needs to >> specify if the receiver should process the COMMON-HEADER as having 12 >> octets or 16 octets in this case. >> >> >> A problem here as for other fields is coping with senders implementeing >> the RFC4582 subset only and not the extensions. I can see the problem, >> but suggest that we keep the text and solution more or less as is. >> However, I think it is a good idea to tell the receiver to process the >> received packet as having 12 octets to definitely ignore the F bit in >> this case. > > OK. I have an uneasy feeling about this, but that clarification is > certainly better than the current state where there is no guidance at > all. I leave it up to your discretion. > >> >> * Section 6.2.3: >> >> This section does not explicitly state that each of the fragments needs >> to have the COMMON-HEADER included, but it can be inferred since that is >> the most logical thing to do. I would prefer that it be explicitly >> stated though. >> >> If my interpretation is correct, then the formula for calculating the >> number of fragments is wrong. Instead of >> >> N=ceil(message size / MTU size) >> >> it needs to be >> >> N = ceil( (message size - X) / (MTU size - X) ) >> >> where X is the size of the COMMON-HEADER with fragment fields (i.e. 16) >> if the MTU size is the MTU for UDP. This is needed because the common >> header will be repeated on all the fragments. >> >> e.g. Assume MTU size=1280 and message size=2560 (COMMON-HEADER 16 + 2544 >> message) the current formula will yield N=2, while N should in fact be 3 >> as the message will not fit in 2 fragments. >> >> >> Good catch! Yes, we have to adjust the formula and take into the account >> the added COMMON-HEADER. I'll also add a clarifying text stating that >> all the fragments indeed need the COMMON-HEADER (of 16 octets length). > > Great. > > Cheers > Suresh >
- [bfcpbis] Gen-ART Telechat review of draft-ietf-b… Suresh Krishnan
- [bfcpbis] Fwd: [Gen-art] Gen-ART Telechat review … Suresh Krishnan
- Re: [bfcpbis] Gen-ART Telechat review of draft-ie… Tom Kristensen
- Re: [bfcpbis] Gen-ART Telechat review of draft-ie… Alissa Cooper