IETF Logo Mail Archive

Re: [bfcpbis] IESG AD reviews of draft-ietf-bfcpbis-rfc4583bis-26: The Pull Request

"Charles Eckel (eckelcu)" <eckelcu@cisco.com> Wed, 05 December 2018 06:32 UTC

Return-Path: <eckelcu@cisco.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 54D33129A87; Tue, 4 Dec 2018 22:32:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -15.96
X-Spam-Level:
X-Spam-Status: No, score=-15.96 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_MED=-1.459, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fO4q-k1kIEUr; Tue, 4 Dec 2018 22:32:19 -0800 (PST)
Received: from rcdn-iport-2.cisco.com (rcdn-iport-2.cisco.com [173.37.86.73]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE46A128CFD; Tue, 4 Dec 2018 22:32:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=5728; q=dns/txt; s=iport; t=1543991538; x=1545201138; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=V+7+8l1qqWjg7iZi0vvmUjp+hqRWJnOmoRvXmP20/o4=; b=kIo6dCPgrjzSPxr1LSxkIfw3vgpWemAYfij0NHaceKQhCFTjmt9MI6v5 G09snziwZdj2ha+TqPeye2GvMw0tCMKny6JsvPpoVoZ+eNRtoDTdV9sMy BoORIf7SOf1UTzY+PKw6prdMOHn/AnqverlULE+K7vJo7ZyGC/vBMzO4v o=;
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0ADAABscAdc/5tdJa1kDgsBAQEBAQEBAQEBAQEHAQEBAQEBgVEEAQEBAQELAYIDZoECJwqDb4gZjhuJEo46FIFmCwEBGAuEA0YCF4J0IjQJDQEDAQECAQECbRwMhTwBAQEEAQEhEToLDAQCAQgRAwECAwImAgICHwYLFQgIAgQBDQWDIQGBaQMVD6RpgS+EAgGEAA2CFwWBC4sTF4F/gREnH4JMgSgZAYEVRwEBgUkvgm0xgiYCoCEuCQKHAYcQgy4YgVuFFIo9P4hKhGiBDIlVAhEUgScfOIFVcBU7KgGCQYInDAsSgziFFIUEBAE2QTEBiw6BHwEB
X-IronPort-AV: E=Sophos;i="5.56,317,1539648000"; d="scan'208";a="494775274"
Received: from rcdn-core-4.cisco.com ([173.37.93.155]) by rcdn-iport-2.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2018 06:32:17 +0000
Received: from XCH-RCD-020.cisco.com (xch-rcd-020.cisco.com [173.37.102.30]) by rcdn-core-4.cisco.com (8.15.2/8.15.2) with ESMTPS id wB56WH6P011780 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Wed, 5 Dec 2018 06:32:17 GMT
Received: from xch-aln-018.cisco.com (173.36.7.28) by XCH-RCD-020.cisco.com (173.37.102.30) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 5 Dec 2018 00:32:16 -0600
Received: from xch-aln-018.cisco.com ([173.36.7.28]) by XCH-ALN-018.cisco.com ([173.36.7.28]) with mapi id 15.00.1395.000; Wed, 5 Dec 2018 00:32:16 -0600
From: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>, Ben Campbell <ben@nostrum.com>, Benjamin Kaduk <kaduk@mit.edu>, Eric Rescorla <ekr@rtfm.com>, "resnick@episteme.net" <resnick@episteme.net>
CC: "bfcpbis@ietf.org" <bfcpbis@ietf.org>, "mary.ietf.barnes@gmail.com" <mary.ietf.barnes@gmail.com>, The IESG <iesg@ietf.org>, "draft-ietf-bfcpbis-rfc4583bis@ietf.org" <draft-ietf-bfcpbis-rfc4583bis@ietf.org>
Thread-Topic: [bfcpbis] IESG AD reviews of draft-ietf-bfcpbis-rfc4583bis-26: The Pull Request
Thread-Index: AQHUijKoa75sqfI7W0qtTCkcPwcdz6VrcxaAgAFUmQCAAITHAIAAAlWAgANgyoA=
Date: Wed, 05 Dec 2018 06:32:16 +0000
Message-ID: <8C09C4E0-F189-426C-8C47-2C79C6604B4A@cisco.com>
References: <7C0EA96A-9D25-41A1-9D68-BB8CAFB7A8CA@ericsson.com> <6F44E945-3946-44E6-A206-5EB8FBA9AA7A@ericsson.com> <F644CE88-D463-403B-A66B-16A3BAC14538@ericsson.com> <794433D0-5D1C-419D-B1F9-E8AB6A7DED02@ericsson.com> <30CA9ACA-4B7C-407C-B249-81621C81BAF5@ericsson.com>
In-Reply-To: <30CA9ACA-4B7C-407C-B249-81621C81BAF5@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.13.0.181109
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-exchange-transport-fromentityheader: Hosted
x-originating-ip: [10.70.232.227]
Content-Type: text/plain; charset="utf-8"
Content-ID: <A001AFA8ED12734F843B9F95863D6578@emea.cisco.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-Outbound-SMTP-Client: 173.37.102.30, xch-rcd-020.cisco.com
X-Outbound-Node: rcdn-core-4.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/tAeOUHonfpB8Lv1rwXRMXKr3frc>
Subject: Re: [bfcpbis] IESG AD reviews of draft-ietf-bfcpbis-rfc4583bis-26: The Pull Request
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Dec 2018 06:32:21 -0000

I have reviewed the pull requests. All the changes look good to me. Just a few things I suggest updating,

Line 184/5, I do not understand the point this sentence is making and think it can be removed, "As a result, each endpoint will take the same role for each BFCP-controlled media stream associated with the BFCP stream."

Line 551, s/corresponding offer.; and/corresponding offer; and

Line 586, s/an answer, that contains/an answer that contains

Lines 710/11, I disputed the accuracy of this statement in another thread, "nor do they reveal which media streams will be BFCP controlled." I think this last statement should be removed.

Cheers,
Charles


-----Original Message-----
From: Christer Holmberg <christer.holmberg@ericsson.com>
Date: Tuesday, December 4, 2018 at 12:57 AM
To: Ben Campbell <ben@nostrum.com>, Charles Eckel <eckelcu@cisco.com>, Benjamin Kaduk <kaduk@mit.edu>, Eric Rescorla <ekr@rtfm.com>, "resnick@episteme.net" <resnick@episteme.net>
Cc: "bfcpbis@ietf.org" <bfcpbis@ietf.org>, Mary Barnes <mary.ietf.barnes@gmail.com>, The IESG <iesg@ietf.org>, "draft-ietf-bfcpbis-rfc4583bis@ietf.org" <draft-ietf-bfcpbis-rfc4583bis@ietf.org>, "bfcpbis-chairs@ietf.org" <bfcpbis-chairs@ietf.org>
Subject: Re: [bfcpbis] IESG AD reviews of draft-ietf-bfcpbis-rfc4583bis-26: The Pull Request

    Correct e-mail address for Pete.
    
    On 03/12/2018, 17.51, "Christer Holmberg" <christer.holmberg@ericsson.com> wrote:
    
        Hi,
        
        The fourth commit includes additional changes based on Benjamin's and Ekr's reviews, and changes based on Pete's gen-art review.
        
        https://github.com/cdh4u/draft-bfcp-4583bis/pull/13
        
        At this point I do NOT intend to make further changes based on the IESG review, so please take a look and let me know whether I have forgotten something, or whether I did something wrong.
        
        Regards,
        
        Christer
        
        Ps. Ekr, I got rid of most of the "associated" terminology from the O/A section. There is still some, but the text now talks about "including attributes in m sections", similar to BUNDLE.
        
        
        
        
        On 03/12/2018, 9.53, "bfcpbis on behalf of Christer Holmberg" <bfcpbis-bounces@ietf.org on behalf of christer.holmberg@ericsson.com> wrote:
        
            Hi,
            
            The third commit includes changes based on Benjamin's and Ekr's reviews.
            
            Regards,
            
            Christer
            
            On 02/12/2018, 13.34, "bfcpbis on behalf of Christer Holmberg" <bfcpbis-bounces@ietf.org on behalf of christer.holmberg@ericsson.com> wrote:
            
                Hi,
                
                The second commit includes changes (all but the one related to the MUX category) based on Ben's review.
                
                Regards,
                
                Christer
                
                
                
                On 02/12/2018, 13.32, "Christer Holmberg" <christer.holmberg@ericsson.com> wrote:
                
                    Hi,
                    
                    I have created a pull request that will include the changes based on the AD reviews.
                    
                    The first commit includes changes based on Alexey's review.
                    
                    https://github.com/cdh4u/draft-bfcp-4583bis/pull/13
                    
                    Regards,
                    
                    Christer
                    
                     
                    
                    
                
                _______________________________________________
                bfcpbis mailing list
                bfcpbis@ietf.org
                https://www.ietf.org/mailman/listinfo/bfcpbis
                
            
            _______________________________________________
            bfcpbis mailing list
            bfcpbis@ietf.org
            https://www.ietf.org/mailman/listinfo/bfcpbis

v2.23.0 | Report a Bug | By Email