Re: [bfcpbis] Draft new version: draft-ietf-bfcpbis-rfc4583bis-25 - The pull request

Alan Ford <alan.ford@gmail.com> Wed, 26 September 2018 11:51 UTC

Return-Path: <alan.ford@gmail.com>
X-Original-To: bfcpbis@ietfa.amsl.com
Delivered-To: bfcpbis@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AD72B130E90; Wed, 26 Sep 2018 04:51:22 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zuoHwhf0XXO9; Wed, 26 Sep 2018 04:51:20 -0700 (PDT)
Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EAC22130E18; Wed, 26 Sep 2018 04:51:19 -0700 (PDT)
Received: by mail-wr1-x42a.google.com with SMTP id v16-v6so26691813wro.11; Wed, 26 Sep 2018 04:51:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=BleVJ5FoVmJ9rXCRTOnULoYnRkC/nmXqMktVFz73TKY=; b=WXszuLAGNb5xm9gqYwn3JQWVNA2XxSr0GjLTI8jAwy4BJMxIt71LbwbclTommgN6cs 5nmU/4zzafV6E3ctE6sYDxZCqo31GKtTJYBFHVlxWgvaopsIk15G4+a85zrlh0F/5Fll dU5VpEVE2tyrLSBUYADgPqzNX+JxOSN3hXWTRjMHDyopcjZ8bo1i2mQokEqszFNxGr1f aC+5Z9FtkyM9pkMMNcanVO1QDKAGX0oXOIFNQ9mg47EW6A5KAgjyHNB2ucEEjV442PD6 ZR+MnCd8ymn4nv9ffPDMHamwRaQYppanhACXcdfi1lCTGeUtDVg6m6ddoz1H+DNU9cnJ +YZg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=BleVJ5FoVmJ9rXCRTOnULoYnRkC/nmXqMktVFz73TKY=; b=ufSevqoMpOrK3mip1DGNJUTuP/WNu2C9ws4pOVyA/OTs5dH0wugaSRn96jKcSc9AXB nDo1TSIjojLslpUBtHygnvSAiNfJSb84uf0nO0iBGcnpYGQAqH0tIyvGi1Pmm7S+cc/Y aPDn9iItfSvi/csqzWqwWvYFJSn/Xt/ybxyo2PgxzKnJjby/ZBN81dP6VW9tSGg7ZAyJ 2JTChz1yXI6Md/dPDJhI+rGD1qBvjQU9GRhDR0CBPv7V/NEdEpnJPrKpRKMTUnZhP6Iq LXCx7Br+dkn0ttPiuWlSA3gfhbrCAvD059SeoFQrIUtVGof413LJ1YSQ488YQobv0AL8 lEGA==
X-Gm-Message-State: ABuFfohTcjuVmWFyOlo8Kh0CT3j1AufLEl9YBKdC771NDv9nM8di+0ft rufDPvrf3UDFF09kREK/G+c=
X-Google-Smtp-Source: ACcGV60TBLfItYHybdIyhZAhKPMtTybf6AcWCwb/8fIjITEXqFkxlIMJu3advMTqZy+wWl9cweSyxw==
X-Received: by 2002:a05:6000:100f:: with SMTP id a15mr4269018wrx.271.1537962678249; Wed, 26 Sep 2018 04:51:18 -0700 (PDT)
Received: from [10.44.30.233] ([62.254.152.194]) by smtp.gmail.com with ESMTPSA id d6-v6sm4430732wmd.2.2018.09.26.04.51.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Sep 2018 04:51:17 -0700 (PDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alan Ford <alan.ford@gmail.com>
In-Reply-To: <9784FF97-A260-4091-901D-6892A6107EC4@ericsson.com>
Date: Wed, 26 Sep 2018 12:51:12 +0100
Cc: "Charles Eckel (eckelcu)" <eckelcu@cisco.com>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>, "draft-ietf-bfcpbis-rfc4583bis.all@ietf.org" <draft-ietf-bfcpbis-rfc4583bis.all@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <938AC19B-17EB-46E3-9946-BA19206CA9FE@gmail.com>
References: <9784FF97-A260-4091-901D-6892A6107EC4@ericsson.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/bfcpbis/u92Nd5JHTZCYHgI4r_Fnmg1OgZw>
Subject: Re: [bfcpbis] Draft new version: draft-ietf-bfcpbis-rfc4583bis-25 - The pull request
X-BeenThere: bfcpbis@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: BFCPBIS working group discussion list <bfcpbis.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bfcpbis/>
List-Post: <mailto:bfcpbis@ietf.org>
List-Help: <mailto:bfcpbis-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bfcpbis>, <mailto:bfcpbis-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Sep 2018 11:51:23 -0000

Section 3, “roles have been determines” -> “determined”.

Other than that typo, these changes in -24 all look good to me.

Regards,
Alan

> On 26 Sep 2018, at 12:46, Christer Holmberg <christer.holmberg@ericsson.com> wrote:
> 
> Hi,
> 
> Based on Charles' comments, I have created a new pull request.
> 
> https://github.com/cdh4u/draft-bfcp-4583bis/pull/11
> 
> Regards,
> 
> Christer
> 
> 
> 
> On 26/09/18 14:16, "Christer Holmberg" <christer.holmberg@ericsson.com> wrote:
> 
>    Hi,
> 
>>   Section 4, use of TCP/TLS/BFCP:
>>   s/backward interoperability/backward interoperable
> 
>    My intention was to use "backward compatible", similar to 'TCP/BFCP'. I will fix that.
> 
>>   Section 4, use of TCP/DTLS/BFCP:
>>   s/in [RFC4571]. with DTLS/in [RFC4571], with DTLS
> 
>    Will fix.
> 
>>   Section 5.1,
>>   OLD
>>   An implementation compliant to this specification	
>>   MUST NOT include the "c-s" floorctl attribute value in an offer or or	
>>   answer, but MUST accept the attribute value in offer and process it	
>>   as equivalent to "c-only s-only" (or "s-only c-only").  As as a	
>>   result, each endpoint will take the same role for each BFCP-	
>>   controlled media stream assocaited with the BFCP stream.
>>   NEW
>>   An implementation compliant to this specification	
>>   MUST NOT include the "c-s" floorctl attribute value in an offer or in	
>>   an answer, but MUST accept the attribute value in an offer and process it	
>>   as equivalent to "c-only s-only" (or "s-only c-only").  As a	
>>   result, each endpoint will take the same role for each BFCP-	
>>   controlled media stream associated with the BFCP stream.
> 
>    Looks good. Will modify as suggested.
> 
>>   Section 14
>>   s/ associated with support BFCP/ associated with support of BFCP
> 
>    Will fix.
> 
>    Regards,
> 
>    Christer
> 
> 
>        -----Original Message-----
>        From: Christer Holmberg <christer.holmberg@ericsson.com>
>        Date: Wednesday, September 26, 2018 at 12:19 PM
>        To: "draft-ietf-bfcpbis-rfc4583bis.all@ietf.org" <draft-ietf-bfcpbis-rfc4583bis.all@ietf.org>rg>, "bfcpbis@ietf.org" <bfcpbis@ietf.org>
>        Subject: Draft new version: draft-ietf-bfcpbis-rfc4583bis-25
>        Resent-From: <alias-bounces@ietf.org>
>        Resent-To: Gonzalo Camarillo <gonzalo.camarillo@ericsson.com>om>, <tom.kristensen@tandberg.net>et>, Christer Holmberg <christer.holmberg@ericsson.com>om>, Charles Eckel <eckelcu@cisco.com>om>, Keith Drage <drageke@ntlworld.com>om>, <ben@nostrum.com>om>, Adam Roach <adam@nostrum.com>om>, <aamelnikov@fastmail.fm>fm>, Mary Barnes <mary.ietf.barnes@gmail.com>
>        Resent-Date: Wednesday, September 26, 2018 at 12:19 PM
> 
>            Hi,
> 
>            I have submitted a new version (-25) of 4583bis.
> 
>            The new version contains the merged pull request that was created based on Adam's issues.
> 
>            Regards,
> 
>            Christer  
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> _______________________________________________
> bfcpbis mailing list
> bfcpbis@ietf.org
> https://www.ietf.org/mailman/listinfo/bfcpbis