Re: [Bier] WG LC on https://datatracker.ietf.org/doc/draft-ietf-bier-pim-signaling/
"Bidgoli, Hooman (Nokia - CA/Ottawa)" <hooman.bidgoli@nokia.com> Wed, 11 November 2020 04:20 UTC
Return-Path: <hooman.bidgoli@nokia.com>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B09D03A09D6; Tue, 10 Nov 2020 20:20:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nokia.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZGZ8J5pVOjoW; Tue, 10 Nov 2020 20:20:40 -0800 (PST)
Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2101.outbound.protection.outlook.com [40.107.100.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3A5FC3A07DF; Tue, 10 Nov 2020 20:20:40 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T78CUtCRnlULg0FWViIG6Wb7Wmsy9O+h9J+HkPOVGhdxkor/TnV5QY5fbEoJY8CEvGnncvOL/Prf0pqodfBPODxq4mEDTPyyQTZrfJeqpLA8vvBDR+zr8QakDFve/GPXxYCNg60RLNiyC5ReDMaFdWVRzrytqyVkIrok2AkwCnzS8te5PsPzTdET0JZ3m8wPlVKivRmJdBz13Q1uUG/dNpgC3UCaKq96brbok5kT8wmxe8sRILONPB2sAhFY1h22vaqJq5c3wI1/mVjoVAiB2TrLNIfvkT6fCBBpESaZ5r9G41as7uSY4cQIs8pDvTATON1u9SERNmUYqYa5vnLV5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e6cICIYzmmJGCz/h8ly5e3KRqzIgptQEr8p/pt0Hzq4=; b=KbpUzf4jFWvKyO52+FBouSB3MLP4b3o8g6cxPnd/bUWIsQB65OvfhmKXGkB0/9FifkuX7S+a7Cb8+BvncEZiPHZkbGiIUMIG9G9Q+EAMOPITsOpNGTAo+jlOOAc+fxa+N4O0wOrXT1nVldKWYD02M1JQEk0qOleQ4z/BeV64AiD/tThkmaLE9QiVU4mO5TTh6pCUlmGUfJraO6o4DgE+S8Uv++ObwqT/zgisb2LT8qmXDi98NBi3h/RxE62y4ak3heDqj62efWEu0V9QBBFHzx2yQnwP+xWNxP8wJyNyQzVf1FNEk6EffWRVWISNMX5KiMPbFHd0Zerl2eLwUnq3oA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nokia.com; dmarc=pass action=none header.from=nokia.com; dkim=pass header.d=nokia.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e6cICIYzmmJGCz/h8ly5e3KRqzIgptQEr8p/pt0Hzq4=; b=Lu1I2BFXUpaV07y7wCoqa1jF/nKQ735c4N6kCQAooJD8iYmiJpfuqoDndK+yQwR3blDsZRoH8kXHEVVGM3cGj7Xt+N57Jx/cjynUm3hhD/meGQgwdbTop+ijmZSUhf5thWFgOo61ImENJPadgs8VYkFnOQZ4RJ6bedggmtGQ3Yw=
Received: from DM6PR08MB3978.namprd08.prod.outlook.com (2603:10b6:5:82::29) by DM5PR08MB2875.namprd08.prod.outlook.com (2603:10b6:3:144::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.25; Wed, 11 Nov 2020 04:20:32 +0000
Received: from DM6PR08MB3978.namprd08.prod.outlook.com ([fe80::8c83:fdf9:e966:ee53]) by DM6PR08MB3978.namprd08.prod.outlook.com ([fe80::8c83:fdf9:e966:ee53%6]) with mapi id 15.20.3541.022; Wed, 11 Nov 2020 04:20:32 +0000
From: "Bidgoli, Hooman (Nokia - CA/Ottawa)" <hooman.bidgoli@nokia.com>
To: Nabeel Cocker <nabeel.cocker@gmail.com>, "Mankamana Mishra (mankamis)" <mankamis=40cisco.com@dmarc.ietf.org>, "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net>, Ijsbrand Wijnands <ice@cisco.com>, Stig Venaas <stig@venaas.com>
CC: Greg Shepherd <gjshep@gmail.com>, BIER WG <bier@ietf.org>, Antoni Przygienda <prz@juniper.net>, "bier-chairs@ietf.org" <bier-chairs@ietf.org>
Thread-Topic: [Bier] WG LC on https://datatracker.ietf.org/doc/draft-ietf-bier-pim-signaling/
Thread-Index: AQHUW2ERP5l+URmjxkmL7UcNp3Td9aUcXQCAgAEH0jCAAKtcgIAEn0fAgAAdzoCAABDxoIAAAqlAgDNw5ICAATFfAIAY7BQggK6OXACAAx4S8IAcaU6AgAUO4YCAAACVQIDzqH+AgAGLfgCABFxagIAAJcMAgeRBoYCAAAMisIBLZZYAgAFEQkCAAB5ZgIAAFdsAgFUXn4CAA4c3kA==
Date: Wed, 11 Nov 2020 04:20:32 +0000
Message-ID: <DM6PR08MB3978058CC2A01DFE63670B4691E80@DM6PR08MB3978.namprd08.prod.outlook.com>
References: <DM6PR08MB397892F4E4F9B4BF18B4258891200@DM6PR08MB3978.namprd08.prod.outlook.com> <AF16EFCC-7E91-4701-8651-13DD07FDE9A2@gmail.com> <06B0C052-CF23-42E2-B01A-ED6DBB67B568@cisco.com> <CAD8cbsw2LZe5TN-5sQgr8vAYQ3YUTeQVZ9Xi-6v3R9X=fg7eFA@mail.gmail.com>
In-Reply-To: <CAD8cbsw2LZe5TN-5sQgr8vAYQ3YUTeQVZ9Xi-6v3R9X=fg7eFA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nokia.com;
x-originating-ip: [174.112.72.100]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: f183916d-0806-4feb-e8c0-08d885f92123
x-ms-traffictypediagnostic: DM5PR08MB2875:
x-microsoft-antispam-prvs: <DM5PR08MB2875823949F1E3C62ECD13C491E80@DM5PR08MB2875.namprd08.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6430;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: b4/1LmsMI1nYVhk1cjJtVqM43H3rpb37rF3MiRrMnYXTH3YlnCKGo3E7yNqCu075p2SAL/JaIeKbnSMQtR1ukXdGcV8IOH6/dAQyqXtWFc6wD7pmjg4YgG7ksnNrXwprXXmN5v34kTHwb0O32OWFBU+3lDYCCsDlcFWmVUWZwbVvATrNoBI9M+VhZpnsuDUtIFiJLKck/XVWH81UR4WDgQWfQ30uam+HUNe10g66Q5xPCcyG5M10tHyHKUvAq9jFKld+G2M0LQuD+aHAnhhy8bu4VMEI805kLWknhFkQHDIgX3h4ZDc3mElfbq9DtyLOJCBIp897orJvr1m3Ec0PxnunYsVcsRYY/OkYHO/LKicTUDtFaEXTxHVQpvFKb36kViHNDVNk1OWxkhFMZ5GBLHOLM1b+9z3AEs9WUr5fH2FezIS3HeGHHzGZyq24Hgg/TecWNPIicG+wkRdKHzflNw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR08MB3978.namprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(8676002)(33656002)(9686003)(8936002)(2906002)(166002)(478600001)(52536014)(4326008)(110136005)(54906003)(316002)(86362001)(6506007)(26005)(66946007)(186003)(30864003)(7696005)(83380400001)(53546011)(55016002)(66476007)(66574015)(66556008)(76116006)(5660300002)(71200400001)(966005)(64756008)(66446008)(15940465004); DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: 97/e1AflWuAkGwwgPcALi+ptgpqemiFeBRBpTsTLio6LDHE0vHPckP0BZoguGzr4VQT5nNhwoxUOjqfZ+g0e36MOI85zuY+XmQr13DZrw6kuVdt0dq5BZU8Lm5KeYKaLA7k4DwPyVxSQ5+wPdPLnwEkb8Tn8a8AbZVAYZvff+5FPH9ck3eBW+obfWaQoLRmBsM1lVOMc3baF/kasmQitIinIwY42xIa01FtiVX888aBRGfYMXYWz3Q48CeR6/seHHL6NbDral+kBuoMB0aQPLlheMl3JktilRGrxTFfMcIXnXC8ahjiPkhXL35cetdqFaUKqWi50uJ3XJr6ozJmeNI21CTvL6dWJD+QuMuF24wuCp4vgLYQXfRtHTG2QeXAj42PftMEQ2EOhjE6dSDi2MEVY3QK6yAdg5JL6N0dyL4i65Usv3cpsy9txyi0E09Q8VSzk+UWgo33kv1IdcaB8o1gYi7EBamzN4Zcea6fAF2x6dt3x+QgiRMIZVX5XWcCuHjC9lod1pjVMTdIVTqRwpOTPZK1gaz+7YEUFyd/5mGhJfSboivJf77kd7nWhQmpCX4Cy6w9GySseQksLSdcgNtHZ2wC2Vm5IKQAopb9mJa7vYFaSAHxTsmD3LxOd31tT9IoolFLE8LE9jP8VF10FXg==
x-ms-exchange-transport-forked: True
Content-Type: multipart/alternative; boundary="_000_DM6PR08MB3978058CC2A01DFE63670B4691E80DM6PR08MB3978namp_"
MIME-Version: 1.0
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR08MB3978.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f183916d-0806-4feb-e8c0-08d885f92123
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2020 04:20:32.1657 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ppnRqJycZ+3AG6r/U+m2TSwk42xu1JN6yhgAzl6VnYfvLgd7wL+PWCnDurYzXhonz01bshVeJ+GJMdwkNlN81Nn/xr0nJHqV9rLuQeq8KVM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR08MB2875
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/FztxRCIMy1dn1Odb3ZjzC7elYWw>
Subject: Re: [Bier] WG LC on https://datatracker.ietf.org/doc/draft-ietf-bier-pim-signaling/
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Nov 2020 04:20:44 -0000
Hi Nabeel Much appreciate your comments, all your comments have been incorporated in the new version of the doc. One exception is the format of “Appendix A.” I am using xml2rfc editor and the format of Appendix is hardcoded in the tool. I will upload the new doc as soon as ietf submission tool opens Regards Hooman From: Nabeel Cocker <nabeel.cocker@gmail.com> Sent: Sunday, November 8, 2020 5:24 PM To: Mankamana Mishra (mankamis) <mankamis=40cisco.com@dmarc.ietf.org>; Bidgoli, Hooman (Nokia - CA/Ottawa) <hooman.bidgoli@nokia.com>; Jeffrey (Zhaohui) Zhang <zzhang@juniper.net>; Ijsbrand Wijnands <ice@cisco.com>; Stig Venaas <stig@venaas.com> Cc: Greg Shepherd <gjshep@gmail.com>; BIER WG <bier@ietf.org>; Antoni Przygienda <prz@juniper.net>; bier-chairs@ietf.org Subject: Re: [Bier] WG LC on https://datatracker.ietf.org/doc/draft-ietf-bier-pim-signaling/ Shepherds Review: Authors, I started on the review of the document and have made my comments in the attached google document: https://docs.google.com/document/d/1exSjh3ZFRl1LfWSmfv8BI_XzRewmsBPksOUKio4Rkvk/edit?usp=sharing My comments are within that doc. The document is in pretty good shape, it has addressed all the comments I have seen from the mailing list. The main feedback is really on a few editorial/grammar/spellings... If you prefer, I can download the google doc and send that as an attachment as well. thanks Nabeel On Tue, Sep 15, 2020 at 2:57 PM Mankamana Mishra (mankamis) <mankamis=40cisco.com@dmarc.ietf.org<mailto:40cisco.com@dmarc.ietf.org>> wrote: Yes, I think its good to move document to next step From: Greg Shepherd <gjshep@gmail.com<mailto:gjshep@gmail.com>> Date: Tuesday, September 15, 2020 at 10:39 AM To: "Bidgoli, Hooman (Nokia - CA/Ottawa)" <hooman.bidgoli@nokia.com<mailto:hooman.bidgoli@nokia.com>> Cc: Stig Venaas <stig@venaas.com<mailto:stig@venaas.com>>, "Mankamana Mishra (mankamis)" <mankamis@cisco.com<mailto:mankamis@cisco.com>>, BIER WG <bier@ietf.org<mailto:bier@ietf.org>>, Ijsbrand Wijnands <ice@cisco.com<mailto:ice@cisco.com>>, "bier-chairs@ietf.org<mailto:bier-chairs@ietf.org>" <bier-chairs@ietf.org<mailto:bier-chairs@ietf.org>>, "Jeffrey (Zhaohui) Zhang" <zzhang@juniper.net<mailto:zzhang@juniper.net>>, Antoni Przygienda <prz@juniper.net<mailto:prz@juniper.net>> Subject: Re: [Bier] WG LC on https://datatracker.ietf.org/doc/draft-ietf-bier-pim-signaling/ Thanks! If all the authors agree then let’s release the Doc Shepherd for the write-up. - Shep Sent from my iPhone On Sep 15, 2020, at 08:52, Bidgoli, Hooman (Nokia - CA/Ottawa) <hooman.bidgoli@nokia.com<mailto:hooman.bidgoli@nokia.com>> wrote: Hi Yes the agreed changes are there, again these were mostly cleanup rather then any significant procedural changes. I think they were included in the previous last call. Thanks Hooman From: Greg Shepherd <gjshep@gmail.com<mailto:gjshep@gmail.com>> Sent: Monday, September 14, 2020 4:30 PM To: Bidgoli, Hooman (Nokia - CA/Ottawa) <hooman.bidgoli@nokia.com<mailto:hooman.bidgoli@nokia.com>> Cc: Stig Venaas <stig@venaas.com<mailto:stig@venaas.com>>; Mankamana Mishra (mankamis) <mankamis@cisco.com<mailto:mankamis@cisco.com>>; BIER WG <bier@ietf.org<mailto:bier@ietf.org>>; Ijsbrand Wijnands <ice@cisco.com<mailto:ice@cisco.com>>; bier-chairs@ietf.org<mailto:bier-chairs@ietf.org>; Jeffrey (Zhaohui) Zhang <zzhang@juniper.net<mailto:zzhang@juniper.net>>; Antoni Przygienda <prz@juniper.net<mailto:prz@juniper.net>> Subject: Re: [Bier] WG LC on https://datatracker.ietf.org/doc/draft-ietf-bier-pim-signaling/ It appears that issues have been addressed as per the list discussion of July 28th. The latest rev was posted July 29th, I assume with the agreed changes, correct? Let's do a quick 1 week WGLC to confirm the latest rev. Please respond to this thread by Sept 27th. Thanks, Shep (chairs) On Tue, Jul 28, 2020 at 2:35 PM Bidgoli, Hooman (Nokia - CA/Ottawa) <hooman.bidgoli@nokia.com<mailto:hooman.bidgoli@nokia.com>> wrote: Thanks Stig! Inline HB> Regards Hooman -----Original Message----- From: Stig Venaas <stig@venaas.com<mailto:stig@venaas.com>> Sent: Tuesday, July 28, 2020 4:56 PM To: Mankamana Mishra (mankamis) <mankamis@cisco.com<mailto:mankamis@cisco.com>> Cc: gjshep@gmail.com<mailto:gjshep@gmail.com>; Bidgoli, Hooman (Nokia - CA/Ottawa) <hooman.bidgoli@nokia.com<mailto:hooman.bidgoli@nokia.com>>; BIER WG <bier@ietf.org<mailto:bier@ietf.org>>; Ijsbrand Wijnands <ice@cisco.com<mailto:ice@cisco.com>>; bier-chairs@ietf.org<mailto:bier-chairs@ietf.org>; Jeffrey (Zhaohui) Zhang <zzhang@juniper.net<mailto:zzhang@juniper.net>>; Antoni Przygienda <prz@juniper.net<mailto:prz@juniper.net>> Subject: Re: [Bier] WG LC on https://datatracker.ietf.org/doc/draft-ietf-bier-pim-signaling/ Hi It looks like most of the issues I found have been resolved now. But most importantly, the IANA Considerations still say that there are none. This needs to be fixed! HB> Done, Add it for the join attribute TLV that you got away from in the other draft ;) I see a couple of places where it says PIM signaling message or PIM signaling packet. I think it should say PIM join/prune message, or PIM join/prune packet., HB> Changed to PIM join/prune in section 3 because this was the PIM domain join/prune. "it will generate a PIM join/prune packet toward its attached PIM domain." Any where else that the pim signaling is left is actually the BIER signaling the join/prune through the bier network as such I wanted it to be clear that these are signalling packet and not extending the PIM over the BIER domain. : Regards, Stig On Tue, Sep 24, 2019 at 10:51 AM Stig Venaas <stig@venaas.com<mailto:stig@venaas.com>> wrote: > > Hi > > This is good work and I generally support the document. There are > however some issues that need to be addressed. I also think it would > be good to get this reviewed in the pim WG, perhaps you can ask for > reviews on the pim list. > > I mostly have editorial comments that are easy to address. But at a > high level I think some more text about pim is needed. > > PIM relies on hello messages to know what capabilities a router has, > e.g. whether it support Join attributes, whether it support BIDIR etc. > I think you need to point out what capabilities are assumed to be > present. Obviously it is assumed that Join attributes are supported. > It may also be good to point out that there is no J/P suppression as > the J/P is only sent to the target, and not to other routers. Also > point out that only J/P messages are used, and that there is no assert > processing. > > > Below are the editorial comments. Please also check the "nits" > tool. It complains about missing references, and it cannot find the > "Authors' Addresses" section. The heading is missing. > > Also Section 7 must be updated. There is an IANA action, but it says > there are none! > > The abstract is rather long. Suggest removing some of the text that > explains the general operation of BIER. > > Some of the references might need some work. In section 2 it says "RFC > 2119 [RFC2119]". Should it be just "[RFC2119]"? Also the reference is > missing. In 2.1 it says "[I-D. rfc8279]" which also needs to be > fixed. Most of the other references look fine. > In 3.1 there seems to be a reference to 8279 without brackets though. > > In 2.1, BFR definition. Missing space after ".". > > BFIR definition: It says "insert the BM into the packet", but I think > it might be better to say that it performs BIER encapsulation. The > term BM is not defined. It says "plain" instead of "plane". > > BFER defintion: Do we have to say that BFER is a BFR? In that case, we > should also say that BFIR is a BFR. It says "plain" instead of "plane". > > IBBR and EBBR, might it be good to include "signaling" in the name, > like Ingress Signaling BIER Router and Egress Signaling BIER Router? I > want it to be very clear that ingress and egress are not related to data. > > In "Figure 1" I think "bfir" and "bfer" should be upper case. > > In 3.1: > "weather" should be "whether". > "located on" should probably be "located in". > > In 3.1 there is this paragraph that I think need some changes. > > After discovering the EBBR and its BFR-ID (flooded via IGP BIER > extension), the IBBR will construct a PIM Join Attribute encoded as > > It says that BFR-ID is flooded via IGP BIER extension. That isn't > necessarily true, do we need to explain how the BFR-ID is discovered? > > TLVs into the Source Address field of the PIM Join Message as per > > Isn't it just one TLV? I think you can skip saying that it is a TLV in > the source address field. Just say that it includes a new PIM Join > Attribute in the Join/Prune message. Also note that we should really > say Join/Prune, not just Join. > > [RFC5384] and include it in PIM signaling message. Two new "BIER > > I think it is better to be clear and say PIM Join/Prune message. > > IBBR" attributes are define and explained in upcoming section. The > s/define/defined > > PIM Join Attribute is used on EBBR to obtain necessary bier > s/bier/BIER > information to build its multicast states. In addition the IBBR will > change the PIM signaling packet source IP address to its BIER prefix > address (standard PIM procedure). It will also keep the destination > address as the well known multicast IP address. It then will > construct the BIER header. The signaling packet, in this case the PIM > join/prune packet, is encapsulated in the BIER header and transported > through BIER domain to EBBR. > > The language at the end here makes it sound like the PIM J/P is being > forwarded and that the J/P is being modified. But J/P messages are > sent hop-by-hop. Each router originates a new J/P. For instance, a > router may receive a J/P for multiple sources. These sources may have > different RPF neighbors on the receiving router and hence be split > into separate join messages. This could happen on the IBBR as well. > > The lasts paragraph in section 3 says: > The IBBR will track all the PIM interfaces on the attached PIM domain > which are interested in a certain (S,G). It creates multicast states > for arriving (S,G)s from PIM domain, with incoming interface as BIER > "tunnel" interface and outgoing interface as the PIM domain > interface(s) on which PIM Join(s) were received on. > > The IBBR is a PIM router and what you are describing is standard PIM > behavior, so I think this is a bit redundant. It might be goot to > stress that OIFs are adding according to standard PIM behavior. The > only special here is the RPF interface. > > Section 3.1.4: > In heading Pim/PIM > bier/BIER > > It says "PIM Join Attribute [RFC5384] is used." I think it might be > good to say that "a new PIM Join Attribute is used". And then also > this sentence "The PIM Join Attribute format is as follow:" should > perhaps be The new PIM Join Attribute format is defined as follows:". > > s/Ipv4/IPv4 > s/Ipv6/IPv6 > > In the format I think it might be good to not just show "BIER info", > but show the formatting of prefix, SD and BFR-ID explicitly. Also, it > should state clearly that these are the prefix, SD and BFR-id of the IBBR. > > In 3.1.4.1 why not say PIM Join/Prune packet instead of PIM signaling? > > In 3.3.: > After receiving the BIER packet and determining this packet is a > signaling packet, EBBR will remove the BIER header from PIM packet. > The Received PIM join/prune Signaling packet is processed as if it > were received from neighbors on a virtual interface, (i.e. as if the > pim adjacency was presents, regardless of the fact there is no > adjacency) > Wouldn't the router remove the BIER header simply because the BFR-id > in the BIER header matches its own BFR-id? There are some grammar > issues and a missing period in this paragraph. > > In this paragraph: > With same token the EBBR creates a multicast state with incoming > interface as same interface that PIM join packet was forwarded and > outgoing interfaces of BIER tunnel to BFER identified with BFIR-id > and its corresponding Sub-Domain obtained from the BIER header or via > PIM Join Attributes added to the PIM signaling packet by the IBBR. > > I'm not sure what "With same token" means here. Also, it not should > say that PIM join packet was forwarded. I would say that state is > created according to the PIM specification, and just describe the BIER OIF state. > The specific OIF state may be implementation specific though. Perhaps > this is sufficiently described in the paragraph that comes right > after? It is also well described in 4.1. > > In section 5: s/LEAFs/leaves? Should it be EBBRs? > > In section 6: > s/vrf/VRF > "it is determine" should be "it is determined". > Replace "PIM signaling message" with "PIM Join/Prune message"? > > Section 8: > The 4601 reference should be to RFC 7761. > > Appendix A: > The header seems to not be formatted correctly. > "This section" should be "This appendix"? > > In A.1: "is consist" should be "consists". > > In Figure 2: s/bier/BIER > Also in the text in A.2.2. > > IN A.3.1 > s/Bier/BIER > s/bier/BIER > s/tlv/TLV > > Stig _______________________________________________ BIER mailing list BIER@ietf.org<mailto:BIER@ietf.org> https://www.ietf.org/mailman/listinfo/bier
- [Bier] WG LC on https://datatracker.ietf.org/doc/… Antoni Przygienda
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Jeff Tantsura
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Mankamana Mishra (mankamis)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Dolganow, Andrew (Nokia - SG/Singapore)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Rabadan, Jorge (Nokia - US/Mountain View)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Purkayastha, Debashish
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Nabeel Cocker
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Nagendra Kumar Nainar (naikumar)
- Re: [Bier] WG LC onhttps://datatracker.ietf.org/d… zhang.zheng
- [Bier] 答复: WG LC onhttps://datatracker.ietf.org/d… chen.ran
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Jeffrey (Zhaohui) Zhang
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Mankamana Mishra (mankamis)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Eric Rosen
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Jeffrey (Zhaohui) Zhang
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Eric Rosen
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Greg Shepherd
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Rabadan, Jorge (Nokia - US/Mountain View)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Mankamana Mishra (mankamis)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Nabeel Cocker
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Jeffrey (Zhaohui) Zhang
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Toerless Eckert
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Toerless Eckert
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Robert Raszuk
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Jeff Tantsura
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Toerless Eckert
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Mankamana Mishra (mankamis)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Toerless Eckert
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Mankamana Mishra (mankamis)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Toerless Eckert
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Stig Venaas
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Greg Shepherd
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Greg Shepherd
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Mankamana Mishra (mankamis)
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Nabeel Cocker
- Re: [Bier] WG LC on https://datatracker.ietf.org/… Bidgoli, Hooman (Nokia - CA/Ottawa)