[Bier] Intdir telechat review of draft-ietf-bier-idr-extensions-16

Brian Haberman via Datatracker <noreply@ietf.org> Thu, 12 December 2024 18:13 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: bier@ietf.org
Delivered-To: bier@ietfa.amsl.com
Received: from [10.244.8.130] (unknown [104.131.183.230]) by ietfa.amsl.com (Postfix) with ESMTP id 77447C1840E1; Thu, 12 Dec 2024 10:13:44 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Brian Haberman via Datatracker <noreply@ietf.org>
To: int-dir@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.29.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <173402722408.898283.14713556973855671084@dt-datatracker-6747d7fbdb-jqfx6>
Date: Thu, 12 Dec 2024 10:13:44 -0800
Message-ID-Hash: BVSFNWYVUX2E6BANKXWROXUKFOTDE6U2
X-Message-ID-Hash: BVSFNWYVUX2E6BANKXWROXUKFOTDE6U2
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-bier.ietf.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: bier@ietf.org, draft-ietf-bier-idr-extensions.all@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc6
Reply-To: Brian Haberman <brian@innovationslab.net>
Subject: [Bier] Intdir telechat review of draft-ietf-bier-idr-extensions-16
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/ckXmwNHuKggHwXzIRqZh4KAP2TM>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Owner: <mailto:bier-owner@ietf.org>
List-Post: <mailto:bier@ietf.org>
List-Subscribe: <mailto:bier-join@ietf.org>
List-Unsubscribe: <mailto:bier-leave@ietf.org>

Reviewer: Brian Haberman
Review result: Ready with Nits

I am an assigned INT directorate reviewer for
draft-ietf-bier-idr-extensions-16.txt. These comments were written primarily for
the benefit of the Internet Area Directors. Document editors and shepherd(s)
should treat these comments just like they would treat comments from any other
IETF contributors and resolve them along with any other Last Call comments that
have been received. For more details on the INT Directorate, see
https://datatracker.ietf.org/group/intdir/about/
<https://datatracker.ietf.org/group/intdir/about/>.

This is a well-written document and I only have a few minor issues to mention:

1. Section 3 - The guidance provided that unknown or unsupported TLVs are to be
ignored and propagated is appropriate, but implementations that do not
implement this spec will not know that unless that behavior is standard for
BGP. If it is standard, it would be useful to reference the RFC where that
guidance is first documented.

2. Section 3 - Should "a BFR needs to include one BIER TLV for every Sub-domain
that the prefix belongs to" be re-worded to use MUST?

3. Should there be mention of error checks to ensure that the TLVs do not cause
the Update message to exceed the maximum allowable size (4K or 64K depending
upon support for extended messages)?

4. Section 4 - I was expecting some mention of procedures in this section that
describes how the BIER information is prevented from leaking out of an AS.

5. What harm is caused if BIER information is propagated outside of an
administrative domain? Those should be listed in the Security Considerations
section.