Re: [Bier] Feedback on draft-eckert-bier-rbs-00

IJsbrand Wijnands <ice@braindump.be> Mon, 23 January 2023 17:26 UTC

Return-Path: <ice@braindump.be>
X-Original-To: bier@ietfa.amsl.com
Delivered-To: bier@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AED23C140697; Mon, 23 Jan 2023 09:26:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.587
X-Spam-Level:
X-Spam-Status: No, score=-2.587 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=mailprotect.be
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t0QPnEua5gwM; Mon, 23 Jan 2023 09:26:39 -0800 (PST)
Received: from com-out001.mailprotect.be (com-out001.mailprotect.be [83.217.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2DE50C14F5E0; Mon, 23 Jan 2023 09:26:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mailprotect.be; s=mail; h=To:In-Reply-To:Cc:References:Message-Id:Date: Subject:Mime-Version:From:Content-Transfer-Encoding:Content-Type:reply-to: sender:bcc; bh=oCTF7ZxftVDlF8IC30RaBPzbgJ6NU05KoaDd6GJ+BTY=; b=wKaUWuCvIS1rbf QIgv+YzqNMtAyZJDYk1iWaPuwyGAPIVvF67BbNLVbSctE+QiInsTj0F2Whn0F2kT3WLlz6DzyCLZB PVW2nIjLBLpc2tVjY60XydKLLW3+x5YLaDT49LbXQNRNCC4pe9GuVy6OW4bxGCIy+vk1s+oP/wo8X OKZWi3dhESlb8AkvALnzW535LsXumIyvbNtGERTgVJzJZFj4ZMHYVPIKglcmKSCGMZj1EkP9GzpXc SWElTHzbxog08AZ/qNNX61py0MDkEnrA4hwq54eWFNJ9I5KrwS3j3ZGZnJDaKkGhaCDsVxZmozZAq BJKAomPvYTB2vlYmPJ7g==;
Received: from smtp-auth.mailprotect.be ([178.208.39.159]) by com-mpt-out001.mailprotect.be with esmtp (Exim 4.92) (envelope-from <ice@braindump.be>) id 1pK0aX-0003mT-EI; Mon, 23 Jan 2023 18:26:34 +0100
Received: from smtpclient.apple (29.225-241-81.adsl-static.isp.belgacom.be [81.241.225.29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-auth.mailprotect.be (Postfix) with ESMTPSA id BC2B4C04FB; Mon, 23 Jan 2023 18:26:31 +0100 (CET)
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
From: IJsbrand Wijnands <ice@braindump.be>
Mime-Version: 1.0 (1.0)
Date: Mon, 23 Jan 2023 18:26:31 +0100
Message-Id: <0DD084D4-429B-4126-AC47-22471BCBA7A9@braindump.be>
References: <Y3NpPev+bIhWrtyS@faui48e.informatik.uni-erlangen.de>
Cc: draft-eckert-bier-rbs@ietf.org, BIER WG <bier@ietf.org>
In-Reply-To: <Y3NpPev+bIhWrtyS@faui48e.informatik.uni-erlangen.de>
To: Toerless Eckert <tte@cs.fau.de>
X-Mailer: iPhone Mail (19G82)
X-Originating-IP: 178.208.39.159
X-SpamExperts-Domain: mailprotect.be
X-SpamExperts-Username: 178.208.39.128/27
Authentication-Results: mailprotect.be; auth=pass smtp.auth=178.208.39.128/27@mailprotect.be
X-SpamExperts-Outgoing-Class: ham
X-SpamExperts-Outgoing-Evidence: Combined (0.28)
X-Recommended-Action: accept
X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT9TUqXN3wUFJjUgyqd55eZEPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5wqL5ce0izo3MEwlThXh+L+Eq1uToV35zEggExruXqwDns7 zmR8SrJBKoHsJAkCbDqD2rMopwoVQz84tBAdBLvFyQLfXoabdmF7Z8uHfA5hhyNqSk42fUKRVKif vAT/yc0EybI1sOftHmSKUCHCvcq0TzZjnkrrL1mACMw/UF0G0bQ7KakNnWEuMvWMJYJgW0Qp5cXT iznmMncc81s2qeYiJYN6Crh9DXUDEtWWsjsNUWDlGPaDR+Aes7asAZpVFyfMODodi5MLJiAvrVIi QFNhc8S+HKYI1vbaqYoREZsvVKq8YZ9/SG1CqFB/T9oOuGkszjGcI+mbLJLuOAP016dVWgH88tf6 uZ3Odz3W94IkDNey7wEf3rBXwmzCivpMYSIRN1GWdLWiieE4sApt6oWVGSRxJYEqfHH6e3h3i3L5 b/siHDX/ZpgnR2L6ZSxUhuCgUnzQUUh7zrY+gccQHlvFRbojusghAHJVSwcPHv0z3JA5Fxib54ho r19Rav1EA3X0VjYiWyhWVAgRTI92lX0U8pjOFfnWL8N84Gl+TAvkmIQpRkKgWi6P+HuUVk3o3aTB eNDGo37FEc/C+HZkCypl2eHIgfodXOAsKprebW4raQ4yiMdx93ZmHZ6F/fkurvR8AyRdgMPl42tp we/zht/l1C9SYHs1HVkNOVbBoq352rVtcQ+zTxxVZMQuWFZ1NemnYhV4s0WHRXGZZPQzDltIAHOu 27cKJle450MdBm594FVdc2K+waea2lUOnotr/fNQvy23SZXSfMZ7RzHGH1l2naPKc3yQvxQmzKsA iXiBbJqNIhVpzNT+XxwMKsGOrPQf4ngLmK0LObbZiXBeyQEpViU4oE+ncQYpfHQGnNPTwauNrRqm dKI/mhaL/v8+Pmh326zBXCRRkPNZOeZhl83ItgZkcRkCnoMzps1w8ZlyWp5OlwYUQ1ejeQ1GJqZG MW0WCHtA05KYHui9AUj7nFxAZyCgxZHINA6A5+7T9o6byzvDwAcft/nzfIptzPRrK2/ShgkK/IUj CNCeBQgjifLRQVNUvx4T911LgXOuhzWRBTEvuGslKTrRIXcXpFg5ivY=
X-Report-Abuse-To: spam@com-mpt-mgt001.mailprotect.be
Archived-At: <https://mailarchive.ietf.org/arch/msg/bier/i9N5ntMEF8QloSKgcH_1aGLTtDo>
Subject: Re: [Bier] Feedback on draft-eckert-bier-rbs-00
X-BeenThere: bier@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "\"Bit Indexed Explicit Replication discussion list\"" <bier.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bier>, <mailto:bier-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bier/>
List-Post: <mailto:bier@ietf.org>
List-Help: <mailto:bier-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bier>, <mailto:bier-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Jan 2023 17:26:43 -0000

Hey Toerless,

Did you address the issues I raised below?

Thx,

Ice.

Sent from my iPhone

> On 15 Nov 2022, at 11:26, Toerless Eckert <tte@cs.fau.de> wrote:
> 
> Thanks, Ice - also Tony/Greg feedback/mails..
> 
> want to incooporate feedback into draft updates, hence no quick reply here,
> as to other discus here.
> 
> Cheers
>    Toerless
> 
> 
>> On Thu, Nov 10, 2022 at 01:32:51AM +0000, IJsbrand Wijnands wrote:
>> Dear Authors,
>> 
>> Here is some feedback on the RBS encoding. This is based on my understanding of the draft and discussion with Toerless today.
>> 
>> 1. It seems that when a BIER router is parsing the RecursiveUnit, the length of the BitString is derived from the length of the BIFT Table on the router processing the packet. To me that seems very tricky as the length of the BIFT table might change when interfaces/adjacencies get added and removed. There might always be transient cases where the length of the BitString in the packet might be different from the router’s BIFT Table. If that happens, the complete parsing of the RBS packet goes to sh*t. It would be good to somehow add the length of the BitString inside the RBS header to prevent these cases from happening and be more defensive.
>> 
>> 2. The BIFT table has a Recursive flag to indicate if a BIER node has downstream receivers. This is also required to correctly parse the RBS header. In my mind this should not be a property of the BIFT table. A bier node might have nodes connected to it, but that doesn’t mean they are part of the tree. The recursive flag should be part of the encoded tree inside the RBS header.
>> 
>> Thx,
>> 
>> Ice.
>> 
> 
> -- 
> ---
> tte@cs.fau.de