Re: [Bier] I-D Action: draft-ietf-bier-te-isis-01.txt

I would still appreciate if someone takes a look at my questions as well.

Cheers
    Toerless

On Wed, Aug 03, 2022 at 01:58:14PM +0000, Les Ginsberg (ginsberg) wrote:
> Huaimo -
> 
> Thanx for addressing my comments so quickly.
> 
> Changes look fine - but I do have one question.
> 
> You eliminated the text:
> 
> > "Note that if each of BitPosition
> >    and DrEndBitPosition uses more than 2 octets, we use 4 or more octets
> >    for each of them."
> 
> Does this mean you have no need to ever support more than 16 bits in these fields??
> 
>    Les
> 
> > -----Original Message-----
> > From: BIER <bier-bounces@ietf.org> On Behalf Of Huaimo Chen
> > Sent: Tuesday, August 2, 2022 7:59 PM
> > To: Les Ginsberg (ginsberg) <ginsberg=40cisco.com@dmarc.ietf.org>;
> > bier@ietf.org
> > Subject: Re: [Bier] I-D Action: draft-ietf-bier-te-isis-01.txt
> > 
> > Hi Les,
> > 
> >     Thank you very much for your valuable comments.
> >     I have addressed them in the updated draft (uploaded).
> >     My responses are also inline below with [HC].
> > 
> > Best Regards,
> > Huaimo
> > -----Original Message-----
> > From: BIER <bier-bounces@ietf.org> On Behalf Of Les Ginsberg (ginsberg)
> > Sent: Friday, July 29, 2022 4:59 PM
> > To: bier@ietf.org
> > Subject: Re: [Bier] I-D Action: draft-ietf-bier-te-isis-01.txt
> > 
> > Some pedantic comments on this draft:
> > 
> > For the new BIER-TE sub-TLV:
> > 
> > 1)The relevant registry has been renamed to be "IS-IS Sub-TLVs for TLVs
> > Advertising Neighbor Information". Please use this new name.
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> > w.iana.org%2Fassignments%2Fisis-tlv-codepoints%2Fisis-tlv-
> > codepoints.xhtml%23isis-tlv-codepoints-advertising-neighbor-
> > information&amp;data=05%7C01%7Chuaimo.chen%40futurewei.com%7C5b
> > bd38c256024261ea5608da71a546c0%7C0fee8ff2a3b240189c753a1d5591fedc%
> > 7C1%7C0%7C637947251926210034%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> > MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300
> > 0%7C%7C%7C&amp;sdata=ybC6zOJkG1sRe%2FQosV23MElysXHkg7jnHS70N
> > %2Bf7bpE%3D&amp;reserved=0
> > [HC]: I have renamed it as you suggested.
> > 
> > 2)Please do NOT insert padding to keep content aligned on a 4 byte
> > boundary. This may be useful for OSPF, but it is not for IS-IS as TLVs are NOT
> > aligned inside an LSP. All you are doing is wasting space - which is precious in
> > IS-IS given the limited LSP space.
> > [HC]: Removed padding.
> > 
> > 3)You say in Section 2:
> > 
> > "Note that if each of BitPosition
> >    and DrEndBitPosition uses more than 2 octets, we use 4 or more octets
> >    for each of them."
> > 
> > I do not see how the receiver of the sub-TLV could tell whether the 2 octet or
> > 4 octet encoding was sent as you have nothing that specifies the length of
> > these fields.
> > You can't use the total length of the sub-TLV as it could include optional sub-
> > sub-TLVs.
> > 
> > ??
> > [HC]: Deleted the quoted text.
> > 
> > 4)In IANA section, I do not know why you specified "N" for TLVs 23 and 223.
> > While RFC 5311 (which defines these TLVs) is not popular, if there was an
> > implementation, I see no reason why it should be invalid to send the BIER-TE
> > info in these TLVs.
> > [HC]: Changed "n" to "y" for TLVs 23 and 223.
> > 
> > Thanx.
> > 
> >     Les
> > 
> > 
> > > -----Original Message-----
> > > From: BIER <bier-bounces@ietf.org> On Behalf Of internet-drafts@ietf.org
> > > Sent: Friday, July 29, 2022 12:13 PM
> > > To: i-d-announce@ietf.org
> > > Cc: bier@ietf.org
> > > Subject: [Bier] I-D Action: draft-ietf-bier-te-isis-01.txt
> > >
> > >
> > > A New Internet-Draft is available from the on-line Internet-Drafts
> > directories.
> > > This draft is a work item of the Bit Indexed Explicit Replication WG of the
> > IETF.
> > >
> > >         Title           : IS-IS Extensions for BIER-TE
> > >         Authors         : Huaimo Chen
> > >                           Mike McBride
> > >                           Aijun Wang
> > >                           Gyan S. Mishra
> > >                           Yanhe Fan
> > >                           Lei Liu
> > >                           Xufeng Liu
> > >   Filename        : draft-ietf-bier-te-isis-01.txt
> > >   Pages           : 7
> > >   Date            : 2022-07-29
> > >
> > > Abstract:
> > >    This document describes IS-IS extensions for distributing
> > >    BitPositions configured on the links in "Bit Index Explicit
> > >    Replication Traffic Engineering" (BIER-TE) domain.
> > >
> > >
> > >
> > > The IETF datatracker status page for this draft is:
> > >
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdata
> > tracker.ietf.org%2Fdoc%2Fdraft-ietf-bier-te-
> > isis%2F&amp;data=05%7C01%7Chuaimo.chen%40futurewei.com%7C5bbd38
> > c256024261ea5608da71a546c0%7C0fee8ff2a3b240189c753a1d5591fedc%7C1
> > %7C0%7C637947251926210034%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
> > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%
> > 7C%7C%7C&amp;sdata=99ojCa2m%2BTeMk0OfxeifsmVrhvNaK7jQJp0fu0syR
> > N8%3D&amp;reserved=0
> > >
> > > There is also an htmlized version available at:
> > >
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdata
> > tracker.ietf.org%2Fdoc%2Fhtml%2Fdraft-ietf-bier-te-isis-
> > 01&amp;data=05%7C01%7Chuaimo.chen%40futurewei.com%7C5bbd38c256
> > 024261ea5608da71a546c0%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0
> > %7C637947251926210034%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> > wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C
> > %7C&amp;sdata=%2F8qaH0ZvQBAfGM4WIre0jpcI6As7wjXjdqbxOfdGHxo%3
> > D&amp;reserved=0
> > >
> > > A diff from the previous version is available at:
> > >
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> > w.ietf.org%2Frfcdiff%3Furl2%3Ddraft-ietf-bier-te-isis-
> > 01&amp;data=05%7C01%7Chuaimo.chen%40futurewei.com%7C5bbd38c256
> > 024261ea5608da71a546c0%7C0fee8ff2a3b240189c753a1d5591fedc%7C1%7C0
> > %7C637947251926210034%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
> > wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C
> > %7C&amp;sdata=L77o0dGWGuSwL9vSm1Durc56Fl5zONoDq%2F8ij12v9lc%3D
> > &amp;reserved=0
> > >
> > >
> > > Internet-Drafts are also available by rsync at rsync.ietf.org::internet-drafts
> > >
> > >
> > > _______________________________________________
> > > BIER mailing list
> > > BIER@ietf.org
> > >
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> > w.ietf.org%2Fmailman%2Flistinfo%2Fbier&amp;data=05%7C01%7Chuaimo.c
> > hen%40futurewei.com%7C5bbd38c256024261ea5608da71a546c0%7C0fee8ff
> > 2a3b240189c753a1d5591fedc%7C1%7C0%7C637947251926210034%7CUnkno
> > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1
> > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=em5K2lvVvXwkSl
> > ye1egSX%2BgtdfeqDArSsAycQJTPArI%3D&amp;reserved=0
> > 
> > _______________________________________________
> > BIER mailing list
> > BIER@ietf.org
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
> > w.ietf.org%2Fmailman%2Flistinfo%2Fbier&amp;data=05%7C01%7Chuaimo.c
> > hen%40futurewei.com%7C5bbd38c256024261ea5608da71a546c0%7C0fee8ff
> > 2a3b240189c753a1d5591fedc%7C1%7C0%7C637947251926210034%7CUnkno
> > wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1
> > haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=em5K2lvVvXwkSl
> > ye1egSX%2BgtdfeqDArSsAycQJTPArI%3D&amp;reserved=0
> > 
> > _______________________________________________
> > BIER mailing list
> > BIER@ietf.org
> > https://www.ietf.org/mailman/listinfo/bier
> 

-- 
---
tte@cs.fau.de