Re: [bmwg] [Last-Call] Genart telechat review of draft-ietf-bmwg-ngfw-performance-13

Lars Eggert <lars@eggert.org> Thu, 03 February 2022 13:41 UTC

Return-Path: <lars@eggert.org>
X-Original-To: bmwg@ietfa.amsl.com
Delivered-To: bmwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9901A3A182C; Thu, 3 Feb 2022 05:41:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=eggert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZHUEXET_TCRW; Thu, 3 Feb 2022 05:41:08 -0800 (PST)
Received: from mail.eggert.org (mail.eggert.org [91.190.195.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9FDA53A1829; Thu, 3 Feb 2022 05:41:07 -0800 (PST)
Received: from smtpclient.apple (unknown [IPv6:2a00:ac00:4000:400:3483:e6e7:fbe7:7efc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.eggert.org (Postfix) with ESMTPSA id 813751D410A; Thu, 3 Feb 2022 15:40:53 +0200 (EET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eggert.org; s=dkim; t=1643895653; bh=upMDG6Zjk0K8lOidLKTDubL94csFVYTJZBOP8FbBqx8=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=yDQNE76jYQ5U8GYRFVej5z1bySWfSHIcu1t7OL/CkXIHyvEsp2C0pL2PMZmCO538u kpWm3XUEOnD6cgImkWix/mc0z57tYBRgebArQ1rBoA1JlDepBajpd9Pcb9UflDo3hr AiQ25JB7s4k57AG1cHaK4FrzT7wgwxfWJ27HLlkQ=
Content-Type: multipart/signed; boundary="Apple-Mail=_558C6A3C-D982-426C-8063-26C4F178121F"; protocol="application/pgp-signature"; micalg="pgp-sha512"
Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.60.0.1.1\))
From: Lars Eggert <lars@eggert.org>
In-Reply-To: <164373365337.23647.13599772226951368639@ietfa.amsl.com>
Date: Thu, 03 Feb 2022 15:40:51 +0200
Cc: gen-art@ietf.org, last-call@ietf.org, draft-ietf-bmwg-ngfw-performance.all@ietf.org, bmwg@ietf.org
Message-Id: <226A5253-14C8-486B-95AA-66D740287D0F@eggert.org>
References: <164373365337.23647.13599772226951368639@ietfa.amsl.com>
To: Matt Joras <matt.joras@gmail.com>
X-MailScanner-ID: 813751D410A.A2DA5
X-MailScanner: Found to be clean
X-MailScanner-From: lars@eggert.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/bmwg/MA-OVI0UY4lI6f-ZWlI8VzuuhYo>
Subject: Re: [bmwg] [Last-Call] Genart telechat review of draft-ietf-bmwg-ngfw-performance-13
X-BeenThere: bmwg@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Benchmarking Methodology Working Group <bmwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bmwg>, <mailto:bmwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bmwg/>
List-Post: <mailto:bmwg@ietf.org>
List-Help: <mailto:bmwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bmwg>, <mailto:bmwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2022 13:41:14 -0000

Matt, thank you for your review. I have entered a Discuss ballot for this document based on my own review.

Lars


> On 2022-2-1, at 18:40, Matt Joras via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Matt Joras
> Review result: Ready with Issues
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair. Please wait for direction from your
> document shepherd or AD before posting a new version of the draft.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-bmwg-ngfw-performance-13
> Reviewer: Matt Joras
> Review Date: 2022-01-31
> IETF LC End Date: 2021-12-29
> IESG Telechat date: 2022-02-03
> 
> Nits/editorial comments:
> 
> Section 4.3.1.1
> This section details TCP stack attributes in great detail. However,
> subsequently HTTP/3 and QUIC are both mentioned in 4.3.1.3.. QUIC is in need of
> tuning just as much as TCP, if not more.
> 
> " HTTP/3 emulated browser uses QUIC ([RFC9000]) as transport protocol." should
> be reworded, and I'm not exactly sure what it is trying to convey.
> 
> "Depending on test scenarios and selected HTTP version, HTTP header compression
> MAY be set to enable or disable." should probably read " be enabled or
> disabled."
> 
> Similarly in sections 7, there is a lot of specific mention of TCP connections,
> TCP RSTs, FINs, etc. and continued mentioning of HTTP. Since QUIC is a
> significant carrier of HTTP traffic it seems these sections should not be so
> specific to TCP. Especially since it seems as though for these kinds of devices
> their limits may very well be different for UDP or TCP flows.
> 
> 
> --
> last-call mailing list
> last-call@ietf.org
> https://www.ietf.org/mailman/listinfo/last-call