Re: [bmwg] Genart last call review of draft-ietf-bmwg-ipv6-tran-tech-benchmarking-06

Marius Georgescu <marius.georgescu@rcs-rds.ro> Sat, 29 April 2017 07:49 UTC

Return-Path: <marius.georgescu@rcs-rds.ro>
X-Original-To: bmwg@ietfa.amsl.com
Delivered-To: bmwg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3D604129B5A; Sat, 29 Apr 2017 00:49:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=rcs-rds.ro
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9XS4QChOOzzf; Sat, 29 Apr 2017 00:49:41 -0700 (PDT)
Received: from mailproxy5.rcs-rds.ro (mailproxy5.rcs-rds.ro [212.54.124.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 44AC5129568; Sat, 29 Apr 2017 00:47:22 -0700 (PDT)
Received: from [10.252.6.123] (unknown [10.252.6.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mailproxy5.rcs-rds.ro (Postfix) with ESMTPSA id F0E262836A1; Sat, 29 Apr 2017 10:47:18 +0300 (EEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=rcs-rds.ro; s=MailProxy; t=1493452039; bh=Zb8otDAsXI/AYQAqTa++lYnEj6tDRePlfRNT1gEps+E=; h=Subject:To:References:Cc:From:Date:In-Reply-To; b=aY0Um0bFsdNK2zVbOn4Q7zu+/6QtbUWypmp/mUcvcIrgdWiMK4WNzel9YF6zE2j4u KYXd8B7K+DLjRemnhVImorOVYi6SD1UZlXe38DJfZxjikFPvvcMd2K1hHBUNfH0wAv rcUklW2plV3m7Hi6CkwwEY+KSvxPc/wTUsJtAc4w=
To: Robert Sparks <rjsparks@nostrum.com>, gen-art@ietf.org
References: <149322271242.5954.6564310624067283031@ietfa.amsl.com>
Cc: draft-ietf-bmwg-ipv6-tran-tech-benchmarking.all@ietf.org, ietf@ietf.org, bmwg@ietf.org
From: Marius Georgescu <marius.georgescu@rcs-rds.ro>
Message-ID: <303391a2-84f1-31dc-1b67-e3cc8b0aea3c@rcs-rds.ro>
Date: Sat, 29 Apr 2017 10:52:23 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <149322271242.5954.6564310624067283031@ietfa.amsl.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://mailarchive.ietf.org/arch/msg/bmwg/bTAlin0oVtwOxTKeJOlM2oNKhGs>
Subject: Re: [bmwg] Genart last call review of draft-ietf-bmwg-ipv6-tran-tech-benchmarking-06
X-BeenThere: bmwg@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Benchmarking Methodology Working Group <bmwg.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/bmwg>, <mailto:bmwg-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/bmwg/>
List-Post: <mailto:bmwg@ietf.org>
List-Help: <mailto:bmwg-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/bmwg>, <mailto:bmwg-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Apr 2017 07:49:44 -0000

Hello Robert,

Thank you very much for your detailed review.

We have revised the draft according to your comments.

The result was uploaded as:

https://tools.ietf.org/html/draft-ietf-bmwg-ipv6-tran-tech-benchmarking-07

Please find inline a punctual overview of the changes.

On 4/26/2017 7:05 PM, Robert Sparks wrote:
> Reviewer: Robert Sparks
> Review result: Ready with Issues
>
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
>
> For more information, please see the FAQ at
>
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>
> Document: draft-ietf-bmwg-ipv6-tran-tech-benchmarking-06
> Reviewer: Robert Sparks
> Review Date: 2017-04-26
> IETF LC End Date: 2017-05-02
> IESG Telechat date: Not scheduled for a telechat
>
> Summary: Essentially Ready for publication as an Informational RFC,
> but with some minor issues to address before publication
>
> This document is (with exceptions noted below) straightforward and
> easy to follow
>
> Minor Issues:
>
> Section 8 is very confusing - I suspect it has been made so by
> removing things that were in it earlier. Right now it claims to
> provide additional tests, but the only content is about testing things
> with firewalls, along with a statement that this document is only
> targeting network devices that do not have a firewall function. I
> think you can keep most of the text here (except the statement that
> you aren't talking about things with firewalls) and remove the
> confusion by changing the section heading to something like "Tests in
> the presence of a firewall function".
- we have removed the second paragraph , which was indeed confusing.
The point, which may be clearer in Section 1.1 is that we need
additional benchmarks for stateful IPv6 transition technologies,
which may be (or not) labeled as having a firewall function.  
> It's unclear how to apply the formula in Section 10.2.1 to the results
> that come out of, say, Section 7.3.2, where you are reporting a
> (minimum, median, maximum) tuple. Some discussion about the
> applicability of the tests where you recommend against reporting a
> single number to the methods in this section would help.
+ we added a note in the reporting format part stating: "

*In the case of benchmarks for which more than one value is reported
(e.g. IPDV Section 7.3.2), a column for each of the values SHOULD be
included.*

"
>  It would also
> help to point out that the Xpd result can be go negative (it will go
> negative for things that become smaller as the number of flows
> increase, and positive for things that get bigger). If I read this
> correctly, if throughput (for example) goes to 0 as n increases, Xpd
> will go to -100%. Similary if latency doubles as n increases, Xpd will
> go to +100% (and will go to +200% if latency triples).
+ This was one of the important points which needed clarification. Thank
you for pointing it out.
In order to keep the  performance degradation results in the Lower is
better  direction, we proposed a secondary calculation formula for
higher is better benchmarks (e.g. Throughput). This makes, in our
opinion, the results easier to interpret.

> Nits:
>
> There are several places where you point to Section 6 where I think
> you meant to point to Section 7. See the Procedure: line in 10.2.1 for
> an example. Also make sure 9 is correct where you say "Sections 6
> through 9" in section 12.
+Corrected
>
> Please double-check that you meant "larger MTU" in the last paragraph
> of 5.1. It might be correct, but I find the paragraph confusing.
We find this part to be correct. However, keeping only the 1280 +
overhead recommendation might make it less confusing.
Do you think that would be a viable solution?
> In 8.1 you meant to point to 5.2, not 5.3
>
> Please try to simplify this sentence: 
>   "The duration of each trial SHOULD be at least 60 seconds to reduce
> the potential gain of a DNS64 server, which is able to exhibit higher
> performance by storing the requests and thus utilizing also the
> timeout time for answering them."
+corrected
>
> (Style comment - please feel free to ignore): Consider deleting "as
> well" everywhere it occurs in the document - most of the places it is
> used, the sentence works just as well, and sometimes better, without
> it.
+corrected
> Typos:
> end of section 5.1.1: Appendix A1 should be Appendix A
+corrected

Best regards,
Marius